Jingga/phpOMS
1
0
Fork 0
mirror of https://github.com/Karaka-Management/phpOMS.git synced 2026-02-03 11:18:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

remove issue todos

Browse Source
This commit is contained in:
Dennis Eichhorn 2020-02-07 23:20:54 +01:00
parent 426be81077
commit f8f85b0092
3 changed files with 0 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Account/PermissionHandlingTrait.php
View File

@ -21,10 +21,6 @@ namespace phpOMS\Account;
* @license OMS License 1.0 * @license OMS License 1.0
* @link https://orange-management.org * @link https://orange-management.org
* @since 1.0.0 * @since 1.0.0
*
* @todo Orange-Management/phpOMS#200
* Implement remove permission functionality
* Currently only adding permissions is possible but it should also be possible to remove permissions from an account.
*/ */
trait PermissionHandlingTrait trait PermissionHandlingTrait
{ {

8
DataStorage/Database/DataMapperAbstract.php
View File

@ -124,14 +124,6 @@ use phpOMS\Utils\ArrayUtils;
* Instead of using int the NullModel should be used which has a constructor that allows to define the int. * Instead of using int the NullModel should be used which has a constructor that allows to define the int.
* As a result the datamapper has to be rewritten for the select and insert/update. * As a result the datamapper has to be rewritten for the select and insert/update.
* The select needs to set the null model as value and the insert/update needs to extract the id from the null and ignore all other empty values from the null model which obviously are the default values. * The select needs to set the null model as value and the insert/update needs to extract the id from the null and ignore all other empty values from the null model which obviously are the default values.
*
* @todo Orange-Management/phpOMS#236
* Consider unifing hasMany and ownsOwn
* Maybe unify these relations and handle them based on their definition of src and dst.
* 1. `src` and `dst` are defined = relation is defined in relation table
* 2. `dst` is defined = relation is defined in own table
* 3. `src` is defined = relation is defined in external table
* Disclaimer: I may have mixed up the meaning of dst and src (the names are bad)
*/ */
class DataMapperAbstract implements DataMapperInterface class DataMapperAbstract implements DataMapperInterface
{ {

20
Router/WebRouter.php
View File

@ -21,26 +21,6 @@ namespace phpOMS\Router;
* @license OMS License 1.0 * @license OMS License 1.0
* @link https://orange-management.org * @link https://orange-management.org
* @since 1.0.0 * @since 1.0.0
*
* @todo Orange-Management/phpOMS#191
* Implement routing parameters
* Most routing implementations have parameters in their route e.g.
* 'route' => '/your/url/{@id}/something'
* This is very easy to read but slows down performance.
* 'route' => [
* 'match' => '/your/url/.*?/something',
* 'parameters'=> [
* 'id' => ['type' => 'path', 'index' => 2]
* ]
* ]
* The parameters should then be passed to the method in the $data = [] variable.
*
* @todo Orange-Management/phpOMS#192
* Implement form/api data validation
* Similar to permission validation it could be possible to add data constraints which are expected for certain routes which then could be checked during routing and dispatching.
* For example it would be possible to define required data fields, their type, their pattern etc.
* This would make the routing definitions much bigger but also dramatically reduce the work which needs to be done in the controllers.
* It could even be written in a way which hardly effects performance.
*/ */
final class WebRouter implements RouterInterface final class WebRouter implements RouterInterface
{ {