From f8f85b009249a414f38fcfda2e46ea6b80c706ee Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nes.com@googlemail.com>
Date: Fri, 7 Feb 2020 23:20:54 +0100
Subject: [PATCH] remove issue todos

---
 Account/PermissionHandlingTrait.php         |  4 ----
 DataStorage/Database/DataMapperAbstract.php |  8 --------
 Router/WebRouter.php                        | 20 --------------------
 3 files changed, 32 deletions(-)

diff --git a/Account/PermissionHandlingTrait.php b/Account/PermissionHandlingTrait.php
index bb6272391..2f4e93821 100644
--- a/Account/PermissionHandlingTrait.php
+++ b/Account/PermissionHandlingTrait.php
@@ -21,10 +21,6 @@ namespace phpOMS\Account;
  * @license OMS License 1.0
  * @link    https://orange-management.org
  * @since   1.0.0
- *
- * @todo Orange-Management/phpOMS#200
- *  Implement remove permission functionality
- *  Currently only adding permissions is possible but it should also be possible to remove permissions from an account.
  */
 trait PermissionHandlingTrait
 {
diff --git a/DataStorage/Database/DataMapperAbstract.php b/DataStorage/Database/DataMapperAbstract.php
index c600439cc..14946e0e1 100644
--- a/DataStorage/Database/DataMapperAbstract.php
+++ b/DataStorage/Database/DataMapperAbstract.php
@@ -124,14 +124,6 @@ use phpOMS\Utils\ArrayUtils;
  *  Instead of using int the NullModel should be used which has a constructor that allows to define the int.
  *  As a result the datamapper has to be rewritten for the select and insert/update.
  *  The select needs to set the null model as value and the insert/update needs to extract the id from the null and ignore all other empty values from the null model which obviously are the default values.
- *
- * @todo Orange-Management/phpOMS#236
- *  Consider unifing hasMany and ownsOwn
- *  Maybe unify these relations and handle them based on their definition of src and dst.
- *      1. `src` and `dst` are defined = relation is defined in relation table
- *      2. `dst` is defined = relation is defined in own table
- *      3. `src` is defined = relation is defined in external table
- *  Disclaimer: I may have mixed up the meaning of dst and src (the names are bad)
  */
 class DataMapperAbstract implements DataMapperInterface
 {
diff --git a/Router/WebRouter.php b/Router/WebRouter.php
index 5297a2492..f1ba70cf6 100644
--- a/Router/WebRouter.php
+++ b/Router/WebRouter.php
@@ -21,26 +21,6 @@ namespace phpOMS\Router;
  * @license OMS License 1.0
  * @link    https://orange-management.org
  * @since   1.0.0
- *
- * @todo Orange-Management/phpOMS#191
- *  Implement routing parameters
- *  Most routing implementations have parameters in their route e.g.
- *      'route' => '/your/url/{@id}/something'
- *  This is very easy to read but slows down performance.
- *      'route' => [
- *           'match' => '/your/url/.*?/something',
- *           'parameters'=> [
- *               'id' => ['type' => 'path', 'index' => 2]
- *           ]
- *       ]
- *  The parameters should then be passed to the method in the $data = [] variable.
- *
- * @todo Orange-Management/phpOMS#192
- *  Implement form/api data validation
- *  Similar to permission validation it could be possible to add data constraints which are expected for certain routes which then could be checked during routing and dispatching.
- *  For example it would be possible to define required data fields, their type, their pattern etc.
- *  This would make the routing definitions much bigger but also dramatically reduce the work which needs to be done in the controllers.
- *  It could even be written in a way which hardly effects performance.
  */
 final class WebRouter implements RouterInterface
 {