Jingga/phpOMS
1
0
Fork 0
mirror of https://github.com/Karaka-Management/phpOMS.git synced 2026-01-11 09:48:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

continue optimizing todos

Browse Source
This commit is contained in:
Dennis Eichhorn 2020-01-05 21:39:24 +01:00
parent d8bf78c7b4
commit 13fe7f1061
6 changed files with 16 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
DataStorage/Database/Connection/PostgresConnection.php
View File

@ -83,6 +83,7 @@ final class PostgresConnection extends ConnectionAbstract
} catch (\PDOException $e) {
unset($this->con);
$this->status = DatabaseStatus::MISSING_DATABASE;
throw new InvalidConnectionConfigException((string) \json_encode($this->dbdata));
} finally {
$this->dbdata['password'] = '****';
}

3
Stdlib/Map/MultiMap.php
View File

@ -125,9 +125,6 @@ final class MultiMap implements \Countable
$this->values[$id] = $value;
}
// todo: is this really required???? - i don't think so!
//$this->garbageCollect();
return $inserted;
}

10
System/File/Ftp/Directory.php
View File

@ -541,7 +541,7 @@ class Directory extends FileAbstract implements FtpContainerInterface, Directory
*/
public function getParent() : ContainerInterface
{
// TODO: Implement getParent() method.
// todo: Implement getParent() method.
}
/**
@ -549,7 +549,7 @@ class Directory extends FileAbstract implements FtpContainerInterface, Directory
*/
public function copyNode(string $to, bool $overwrite = false) : bool
{
// TODO: Implement copyNode() method.
// todo: Implement copyNode() method.
}
/**
@ -557,7 +557,7 @@ class Directory extends FileAbstract implements FtpContainerInterface, Directory
*/
public function moveNode(string $to, bool $overwrite = false) : bool
{
// TODO: Implement moveNode() method.
// todo: Implement moveNode() method.
}
/**
@ -565,7 +565,7 @@ class Directory extends FileAbstract implements FtpContainerInterface, Directory
*/
public function deleteNode() : bool
{
// TODO: Implement deleteNode() method.
// todo: Implement deleteNode() method.
}
/**
@ -651,6 +651,6 @@ class Directory extends FileAbstract implements FtpContainerInterface, Directory
*/
public function offsetGet($offset)
{
// TODO: Implement offsetGet() method.
// todo: Implement offsetGet() method.
}
}

18
System/File/Ftp/File.php
View File

@ -434,7 +434,7 @@ class File extends FileAbstract implements FileInterface
*/
public function copyNode(string $to, bool $overwrite = false) : bool
{
// TODO: Implement copyNode() method.
// todo: Implement copyNode() method.
}
/**
@ -449,7 +449,7 @@ class File extends FileAbstract implements FileInterface
*/
public function moveNode(string $to, bool $overwrite = false) : bool
{
// TODO: Implement moveNode() method.
// todo: Implement moveNode() method.
}
/**
@ -461,7 +461,7 @@ class File extends FileAbstract implements FileInterface
*/
public function deleteNode() : bool
{
// TODO: Implement deleteNode() method.
// todo: Implement deleteNode() method.
}
/**
@ -476,7 +476,7 @@ class File extends FileAbstract implements FileInterface
*/
public function putContent(string $content, int $mode = ContentPutMode::APPEND | ContentPutMode::CREATE) : bool
{
// TODO: Implement putContent() method.
// todo: Implement putContent() method.
}
/**
@ -492,7 +492,7 @@ class File extends FileAbstract implements FileInterface
*/
public function setContent(string $content) : bool
{
// TODO: Implement setContent() method.
// todo: Implement setContent() method.
}
/**
@ -508,7 +508,7 @@ class File extends FileAbstract implements FileInterface
*/
public function appendContent(string $content) : bool
{
// TODO: Implement appendContent() method.
// todo: Implement appendContent() method.
}
/**
@ -524,7 +524,7 @@ class File extends FileAbstract implements FileInterface
*/
public function prependContent(string $content) : bool
{
// TODO: Implement prependContent() method.
// todo: Implement prependContent() method.
}
/**
@ -536,7 +536,7 @@ class File extends FileAbstract implements FileInterface
*/
public function getContent() : string
{
// TODO: Implement getContent() method.
// todo: Implement getContent() method.
}
/**
@ -548,6 +548,6 @@ class File extends FileAbstract implements FileInterface
*/
public function getExtension() : string
{
// TODO: Implement getExtension() method.
// todo: Implement getExtension() method.
}
}

2
System/File/Local/Directory.php
View File

@ -620,6 +620,6 @@ final class Directory extends FileAbstract implements LocalContainerInterface, D
*/
public function offsetGet($offset) : void
{
// TODO: Implement offsetGet() method.
// todo: Implement offsetGet() method.
}
}

12
tests/DataStorage/Database/Connection/PostgresConnectionTest.php
View File

@ -144,16 +144,4 @@ class PostgresConnectionTest extends \PHPUnit\Framework\TestCase
$db['db'] = 'invalid';
$psql = new PostgresConnection($db);
}
/**
* todo: apparently this doesn't throw an exception in postgresql?!
* @group framework
*/
public function testInvalidDatabaseName() : void
{
$db = $GLOBALS['CONFIG']['db']['core']['postgresql']['admin'];
$db['database'] = ';`$';
$mysql = new PostgresConnection($db);
}
}