diff --git a/DataStorage/Database/Connection/PostgresConnection.php b/DataStorage/Database/Connection/PostgresConnection.php index e1044532f..4e789b414 100644 --- a/DataStorage/Database/Connection/PostgresConnection.php +++ b/DataStorage/Database/Connection/PostgresConnection.php @@ -83,6 +83,7 @@ final class PostgresConnection extends ConnectionAbstract } catch (\PDOException $e) { unset($this->con); $this->status = DatabaseStatus::MISSING_DATABASE; + throw new InvalidConnectionConfigException((string) \json_encode($this->dbdata)); } finally { $this->dbdata['password'] = '****'; } diff --git a/Stdlib/Map/MultiMap.php b/Stdlib/Map/MultiMap.php index ec0259863..ffb10327a 100644 --- a/Stdlib/Map/MultiMap.php +++ b/Stdlib/Map/MultiMap.php @@ -125,9 +125,6 @@ final class MultiMap implements \Countable $this->values[$id] = $value; } - // todo: is this really required???? - i don't think so! - //$this->garbageCollect(); - return $inserted; } diff --git a/System/File/Ftp/Directory.php b/System/File/Ftp/Directory.php index 55b271412..86ea2b3ec 100644 --- a/System/File/Ftp/Directory.php +++ b/System/File/Ftp/Directory.php @@ -541,7 +541,7 @@ class Directory extends FileAbstract implements FtpContainerInterface, Directory */ public function getParent() : ContainerInterface { - // TODO: Implement getParent() method. + // todo: Implement getParent() method. } /** @@ -549,7 +549,7 @@ class Directory extends FileAbstract implements FtpContainerInterface, Directory */ public function copyNode(string $to, bool $overwrite = false) : bool { - // TODO: Implement copyNode() method. + // todo: Implement copyNode() method. } /** @@ -557,7 +557,7 @@ class Directory extends FileAbstract implements FtpContainerInterface, Directory */ public function moveNode(string $to, bool $overwrite = false) : bool { - // TODO: Implement moveNode() method. + // todo: Implement moveNode() method. } /** @@ -565,7 +565,7 @@ class Directory extends FileAbstract implements FtpContainerInterface, Directory */ public function deleteNode() : bool { - // TODO: Implement deleteNode() method. + // todo: Implement deleteNode() method. } /** @@ -651,6 +651,6 @@ class Directory extends FileAbstract implements FtpContainerInterface, Directory */ public function offsetGet($offset) { - // TODO: Implement offsetGet() method. + // todo: Implement offsetGet() method. } } diff --git a/System/File/Ftp/File.php b/System/File/Ftp/File.php index 965973078..5ea9bd8aa 100644 --- a/System/File/Ftp/File.php +++ b/System/File/Ftp/File.php @@ -434,7 +434,7 @@ class File extends FileAbstract implements FileInterface */ public function copyNode(string $to, bool $overwrite = false) : bool { - // TODO: Implement copyNode() method. + // todo: Implement copyNode() method. } /** @@ -449,7 +449,7 @@ class File extends FileAbstract implements FileInterface */ public function moveNode(string $to, bool $overwrite = false) : bool { - // TODO: Implement moveNode() method. + // todo: Implement moveNode() method. } /** @@ -461,7 +461,7 @@ class File extends FileAbstract implements FileInterface */ public function deleteNode() : bool { - // TODO: Implement deleteNode() method. + // todo: Implement deleteNode() method. } /** @@ -476,7 +476,7 @@ class File extends FileAbstract implements FileInterface */ public function putContent(string $content, int $mode = ContentPutMode::APPEND | ContentPutMode::CREATE) : bool { - // TODO: Implement putContent() method. + // todo: Implement putContent() method. } /** @@ -492,7 +492,7 @@ class File extends FileAbstract implements FileInterface */ public function setContent(string $content) : bool { - // TODO: Implement setContent() method. + // todo: Implement setContent() method. } /** @@ -508,7 +508,7 @@ class File extends FileAbstract implements FileInterface */ public function appendContent(string $content) : bool { - // TODO: Implement appendContent() method. + // todo: Implement appendContent() method. } /** @@ -524,7 +524,7 @@ class File extends FileAbstract implements FileInterface */ public function prependContent(string $content) : bool { - // TODO: Implement prependContent() method. + // todo: Implement prependContent() method. } /** @@ -536,7 +536,7 @@ class File extends FileAbstract implements FileInterface */ public function getContent() : string { - // TODO: Implement getContent() method. + // todo: Implement getContent() method. } /** @@ -548,6 +548,6 @@ class File extends FileAbstract implements FileInterface */ public function getExtension() : string { - // TODO: Implement getExtension() method. + // todo: Implement getExtension() method. } } diff --git a/System/File/Local/Directory.php b/System/File/Local/Directory.php index 4c5c7d91e..1053b6f75 100644 --- a/System/File/Local/Directory.php +++ b/System/File/Local/Directory.php @@ -620,6 +620,6 @@ final class Directory extends FileAbstract implements LocalContainerInterface, D */ public function offsetGet($offset) : void { - // TODO: Implement offsetGet() method. + // todo: Implement offsetGet() method. } } diff --git a/tests/DataStorage/Database/Connection/PostgresConnectionTest.php b/tests/DataStorage/Database/Connection/PostgresConnectionTest.php index e8b036968..8d2dd3dc8 100644 --- a/tests/DataStorage/Database/Connection/PostgresConnectionTest.php +++ b/tests/DataStorage/Database/Connection/PostgresConnectionTest.php @@ -144,16 +144,4 @@ class PostgresConnectionTest extends \PHPUnit\Framework\TestCase $db['db'] = 'invalid'; $psql = new PostgresConnection($db); } - - /** - * todo: apparently this doesn't throw an exception in postgresql?! - * @group framework - */ - public function testInvalidDatabaseName() : void - { - $db = $GLOBALS['CONFIG']['db']['core']['postgresql']['admin']; - $db['database'] = ';`$'; - - $mysql = new PostgresConnection($db); - } }