static code analysis fixes

This commit is contained in:
Dennis Eichhorn 2022-04-05 20:04:47 +02:00
parent 920177e148
commit 92cf778117
2 changed files with 8 additions and 8 deletions

View File

@ -357,8 +357,8 @@ final class ApiController extends Controller
*/ */
public function apiTemplateCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void public function apiTemplateCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
{ {
$dbFiles = $request->getDataJson('media-list') ?? []; $dbFiles = $request->getDataJson('media-list');
$uploadedFiles = $request->getFiles() ?? []; $uploadedFiles = $request->getFiles();
$files = []; $files = [];
if (!empty($val = $this->validateTemplateCreate($request))) { if (!empty($val = $this->validateTemplateCreate($request))) {
@ -377,8 +377,8 @@ final class ApiController extends Controller
/** @var \Modules\Media\Models\Media[] $uploaded */ /** @var \Modules\Media\Models\Media[] $uploaded */
$uploaded = $this->app->moduleManager->get('Media')->uploadFiles( $uploaded = $this->app->moduleManager->get('Media')->uploadFiles(
$request->getDataList('names') ?? [], $request->getDataList('names'),
$request->getDataList('filenames') ?? [], $request->getDataList('filenames'),
$uploadedFiles, $uploadedFiles,
$request->header->account, $request->header->account,
__DIR__ . '/../../../Modules/Media/Files' __DIR__ . '/../../../Modules/Media/Files'
@ -451,7 +451,7 @@ final class ApiController extends Controller
{ {
$val = []; $val = [];
if (($val['name'] = empty($request->getData('name'))) if (($val['name'] = empty($request->getData('name')))
|| ($val['files'] = empty($request->getFiles() ?? [])) || ($val['files'] = empty($request->getFiles()))
) { ) {
return $val; return $val;
} }
@ -537,8 +537,8 @@ final class ApiController extends Controller
} }
$files = $this->app->moduleManager->get('Media')->uploadFiles( $files = $this->app->moduleManager->get('Media')->uploadFiles(
$request->getDataList('names') ?? [], $request->getDataList('names'),
$request->getDataList('filenames') ?? [], $request->getDataList('filenames'),
$request->getFiles(), $request->getFiles(),
$request->header->account, $request->header->account,
__DIR__ . '/../../../Modules/Media/Files' __DIR__ . '/../../../Modules/Media/Files'

View File

@ -12,7 +12,7 @@
"friendsofphp/php-cs-fixer": ">=3.2", "friendsofphp/php-cs-fixer": ">=3.2",
"squizlabs/php_codesniffer": ">=3.6", "squizlabs/php_codesniffer": ">=3.6",
"phpmd/phpmd": ">=2.9", "phpmd/phpmd": ">=2.9",
"phpstan/phpstan": ">=0.12.58", "phpstan/phpstan": ">=1.5.4",
"phan/phan": ">=3.2.6" "phan/phan": ">=3.2.6"
}, },
"minimum-stability": "dev", "minimum-stability": "dev",