From 92cf778117a551a7200d4f114397105b321613a3 Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nes.com@googlemail.com>
Date: Tue, 5 Apr 2022 20:04:47 +0200
Subject: [PATCH] static code analysis fixes

---
 Controller/ApiController.php | 14 +++++++-------
 composer.json                |  2 +-
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/Controller/ApiController.php b/Controller/ApiController.php
index b9ea56b..4c80456 100755
--- a/Controller/ApiController.php
+++ b/Controller/ApiController.php
@@ -357,8 +357,8 @@ final class ApiController extends Controller
      */
     public function apiTemplateCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
     {
-        $dbFiles       = $request->getDataJson('media-list') ?? [];
-        $uploadedFiles = $request->getFiles() ?? [];
+        $dbFiles       = $request->getDataJson('media-list');
+        $uploadedFiles = $request->getFiles();
         $files         = [];
 
         if (!empty($val = $this->validateTemplateCreate($request))) {
@@ -377,8 +377,8 @@ final class ApiController extends Controller
 
         /** @var \Modules\Media\Models\Media[] $uploaded */
         $uploaded = $this->app->moduleManager->get('Media')->uploadFiles(
-            $request->getDataList('names') ?? [],
-            $request->getDataList('filenames') ?? [],
+            $request->getDataList('names'),
+            $request->getDataList('filenames'),
             $uploadedFiles,
             $request->header->account,
             __DIR__ . '/../../../Modules/Media/Files'
@@ -451,7 +451,7 @@ final class ApiController extends Controller
     {
         $val = [];
         if (($val['name'] = empty($request->getData('name')))
-            || ($val['files'] = empty($request->getFiles() ?? []))
+            || ($val['files'] = empty($request->getFiles()))
         ) {
             return $val;
         }
@@ -537,8 +537,8 @@ final class ApiController extends Controller
         }
 
         $files = $this->app->moduleManager->get('Media')->uploadFiles(
-            $request->getDataList('names') ?? [],
-            $request->getDataList('filenames') ?? [],
+            $request->getDataList('names'),
+            $request->getDataList('filenames'),
             $request->getFiles(),
             $request->header->account,
             __DIR__ . '/../../../Modules/Media/Files'
diff --git a/composer.json b/composer.json
index b90cb5e..10044a1 100755
--- a/composer.json
+++ b/composer.json
@@ -12,7 +12,7 @@
         "friendsofphp/php-cs-fixer": ">=3.2",
         "squizlabs/php_codesniffer": ">=3.6",
         "phpmd/phpmd": ">=2.9",
-        "phpstan/phpstan": ">=0.12.58",
+        "phpstan/phpstan": ">=1.5.4",
         "phan/phan": ">=3.2.6"
     },
     "minimum-stability": "dev",