Jingga/oms-SalesAnalysis
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-SalesAnalysis.git synced 2026-01-11 03:18:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

update

Browse Source
This commit is contained in:
Dennis Eichhorn 2024-02-04 20:34:12 +00:00
parent 91fe5b5af8
commit 680ef21f21
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Controller/BackendController.php
View File

@ -64,8 +64,10 @@ final class BackendController extends Controller
$view->setTemplate('/Modules/SalesAnalysis/Theme/Backend/analysis-overview-dashboard');
$view->data['nav'] = $this->app->moduleManager->get('Navigation')->createNavigationMid(1005401001, $request, $response);
// @todo limit bill type (invoice/credit note) (customers only)
// @todo limit bill status
// @bug Only analyze bills with a status and type that is relevant
// For types it should be $isAccounting = true
// For status it should be ARCHIVED
// https://github.com/Karaka-Management/oms-SalesAnalysis/issues/34
$businessStart = 1;
$startOfYear = SmartDateTime::createFromDateTime(SmartDateTime::startOfYear($businessStart));

2
Models/RegionMapper.php
View File

@ -288,7 +288,7 @@ class RegionMapper extends DataMapperFactory
}
// @todo remove businessStart, that should be baked into the historyStart
// Explanation: in the past I had to compare periods which werent even business years!!!
// Explanation: in the past I had to compare periods which weren't even business years!!!
public static function salesProfitCountry(
SmartDateTime $historyStart,
SmartDateTime $historyEnd,