From 680ef21f21e5e8d45eedb1673d3557accd6cecae Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Sun, 4 Feb 2024 20:34:12 +0000 Subject: [PATCH] update --- Controller/BackendController.php | 6 ++++-- Models/RegionMapper.php | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Controller/BackendController.php b/Controller/BackendController.php index 5ce0674..56549d2 100755 --- a/Controller/BackendController.php +++ b/Controller/BackendController.php @@ -64,8 +64,10 @@ final class BackendController extends Controller $view->setTemplate('/Modules/SalesAnalysis/Theme/Backend/analysis-overview-dashboard'); $view->data['nav'] = $this->app->moduleManager->get('Navigation')->createNavigationMid(1005401001, $request, $response); - // @todo limit bill type (invoice/credit note) (customers only) - // @todo limit bill status + // @bug Only analyze bills with a status and type that is relevant + // For types it should be $isAccounting = true + // For status it should be ARCHIVED + // https://github.com/Karaka-Management/oms-SalesAnalysis/issues/34 $businessStart = 1; $startOfYear = SmartDateTime::createFromDateTime(SmartDateTime::startOfYear($businessStart)); diff --git a/Models/RegionMapper.php b/Models/RegionMapper.php index dc3fb8f..e4f9a50 100755 --- a/Models/RegionMapper.php +++ b/Models/RegionMapper.php @@ -288,7 +288,7 @@ class RegionMapper extends DataMapperFactory } // @todo remove businessStart, that should be baked into the historyStart - // Explanation: in the past I had to compare periods which werent even business years!!! + // Explanation: in the past I had to compare periods which weren't even business years!!! public static function salesProfitCountry( SmartDateTime $historyStart, SmartDateTime $historyEnd,