Jingga/oms-Marketing
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Marketing.git synced 2026-02-10 15:38:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cs fixes, bug fixes, code coverage

Browse Source
This commit is contained in:
Dennis Eichhorn 2021-11-16 00:05:43 +01:00
parent b30f51fd96
commit 0e4eb561d6
4 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CONTRIBUTING.md
View File

@ -12,9 +12,7 @@ If you have a good idea for improvement feel free to create a new issue with all
### Issues
Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the `Project.md` file in the `Docs` repository.
The issue information can be used to provide additional information such as priority, difficulty and type. For your first issue try to find a issue marked `[d:first]` or `[d:beginner]`.
Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the code marked with `@todo` or in the [PROJECT.md](https://github.com/Orange-Management/Docs/blob/master/Project/PROJECT.md) file.
### Code Style

2
Models/Promotion.php
View File

@ -17,8 +17,8 @@ namespace Modules\Marketing\Models;
use Modules\Admin\Models\Account;
use Modules\Admin\Models\NullAccount;
use Modules\Calendar\Models\Calendar;
use Modules\Tasks\Models\Task;
use Modules\Tasks\Models\NullTask;
use Modules\Tasks\Models\Task;
use phpOMS\Localization\Money;
/**

5
tests/Models/PromotionMapperTest.php
View File

@ -15,13 +15,12 @@ declare(strict_types=1);
namespace Modules\Marketing\tests\Models;
use Modules\Admin\Models\NullAccount;
use Modules\Marketing\Models\ProgressType;
use Modules\Marketing\Models\Promotion;
use Modules\Marketing\Models\PromotionMapper;
use Modules\Marketing\Models\ProgressType;
use Modules\Media\Models\Media;
use Modules\Tasks\Models\Task;
use phpOMS\Localization\Money;
use phpOMS\Utils\RnG\Text;
/**
* @internal
@ -36,7 +35,7 @@ final class PromotionMapperTest extends \PHPUnit\Framework\TestCase
{
$promotion = new Promotion();
$promotion->name = 'Promotionname';
$promotion->name = 'Promotionname';
$promotion->description = 'Description';
$promotion->createdBy = new NullAccount(1);
$promotion->start = new \DateTime('2000-05-05');

4
tests/Models/PromotionTest.php
View File

@ -14,8 +14,8 @@ declare(strict_types=1);
namespace Modules\Marketing\tests\Models;
use Modules\Marketing\Models\Promotion;
use Modules\Marketing\Models\ProgressType;
use Modules\Marketing\Models\Promotion;
use Modules\Media\Models\Media;
use Modules\Tasks\Models\Task;
use phpOMS\Localization\Money;
@ -154,7 +154,7 @@ final class PromotionTest extends \PHPUnit\Framework\TestCase
$this->promotion->description = 'Description';
$this->promotion->start = new \DateTime();
$this->promotion->end = new \DateTime();
$this->promotion->progress = 10;
$this->promotion->progress = 10;
$this->promotion->setProgressType(ProgressType::TASKS);
$serialized = $this->promotion->jsonSerialize();