diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cab9f5e..ad8944e 100755 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -12,9 +12,7 @@ If you have a good idea for improvement feel free to create a new issue with all ### Issues -Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the `Project.md` file in the `Docs` repository. - -The issue information can be used to provide additional information such as priority, difficulty and type. For your first issue try to find a issue marked `[d:first]` or `[d:beginner]`. +Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the code marked with `@todo` or in the [PROJECT.md](https://github.com/Orange-Management/Docs/blob/master/Project/PROJECT.md) file. ### Code Style diff --git a/Models/Promotion.php b/Models/Promotion.php index 1e61c3f..a42b97b 100755 --- a/Models/Promotion.php +++ b/Models/Promotion.php @@ -17,8 +17,8 @@ namespace Modules\Marketing\Models; use Modules\Admin\Models\Account; use Modules\Admin\Models\NullAccount; use Modules\Calendar\Models\Calendar; -use Modules\Tasks\Models\Task; use Modules\Tasks\Models\NullTask; +use Modules\Tasks\Models\Task; use phpOMS\Localization\Money; /** diff --git a/tests/Models/PromotionMapperTest.php b/tests/Models/PromotionMapperTest.php index 4f5310d..8ab2be1 100755 --- a/tests/Models/PromotionMapperTest.php +++ b/tests/Models/PromotionMapperTest.php @@ -15,13 +15,12 @@ declare(strict_types=1); namespace Modules\Marketing\tests\Models; use Modules\Admin\Models\NullAccount; +use Modules\Marketing\Models\ProgressType; use Modules\Marketing\Models\Promotion; use Modules\Marketing\Models\PromotionMapper; -use Modules\Marketing\Models\ProgressType; use Modules\Media\Models\Media; use Modules\Tasks\Models\Task; use phpOMS\Localization\Money; -use phpOMS\Utils\RnG\Text; /** * @internal @@ -36,7 +35,7 @@ final class PromotionMapperTest extends \PHPUnit\Framework\TestCase { $promotion = new Promotion(); - $promotion->name = 'Promotionname'; + $promotion->name = 'Promotionname'; $promotion->description = 'Description'; $promotion->createdBy = new NullAccount(1); $promotion->start = new \DateTime('2000-05-05'); diff --git a/tests/Models/PromotionTest.php b/tests/Models/PromotionTest.php index 4492932..5e2ff36 100755 --- a/tests/Models/PromotionTest.php +++ b/tests/Models/PromotionTest.php @@ -14,8 +14,8 @@ declare(strict_types=1); namespace Modules\Marketing\tests\Models; -use Modules\Marketing\Models\Promotion; use Modules\Marketing\Models\ProgressType; +use Modules\Marketing\Models\Promotion; use Modules\Media\Models\Media; use Modules\Tasks\Models\Task; use phpOMS\Localization\Money; @@ -154,7 +154,7 @@ final class PromotionTest extends \PHPUnit\Framework\TestCase $this->promotion->description = 'Description'; $this->promotion->start = new \DateTime(); $this->promotion->end = new \DateTime(); - $this->promotion->progress = 10; + $this->promotion->progress = 10; $this->promotion->setProgressType(ProgressType::TASKS); $serialized = $this->promotion->jsonSerialize();