Jingga/oms-Billing
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Billing.git synced 2026-02-17 00:38:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

impl. todos or move to Project.md

Browse Source
This commit is contained in:
Dennis Eichhorn 2021-09-27 23:14:00 +02:00
parent cfe0332f43
commit e70b45551f
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Controller/ApiController.php
View File

@ -175,6 +175,7 @@ final class ApiController extends Controller
* @return BillElement * @return BillElement
* *
* @since 1.0.0 * @since 1.0.0
* @todo in the database the customer localized version should be stored because this is the version which went out
*/ */
public function createBillElementFromRequest(RequestAbstract $request, ResponseAbstract $response, $data = null) : BillElement public function createBillElementFromRequest(RequestAbstract $request, ResponseAbstract $response, $data = null) : BillElement
{ {
@ -187,7 +188,6 @@ final class ApiController extends Controller
} }
$item = ItemMapper::with('language', $response->getLanguage())::get($element->item); $item = ItemMapper::with('language', $response->getLanguage())::get($element->item);
// @todo: which item name should be stored in the database? server language (problem for international company with subsidiaries)? customer default language/customer invoice language?
$element->itemNumber = $item->number; $element->itemNumber = $item->number;
$element->itemName = $item->getL11n('name1')->description; $element->itemName = $item->getL11n('name1')->description;
$element->quantity = $request->getData('quantity', 'int'); $element->quantity = $request->getData('quantity', 'int');

2
Models/Bill.php
View File

@ -1102,8 +1102,6 @@ BillType $type = 0;
* *
* @return void * @return void
* *
* @todo do same for actual tracking information per trackign id
*
* @since 1.0.0 * @since 1.0.0
*/ */
public function addTracking(string $tracking) : void public function addTracking(string $tracking) : void