From e70b45551f278b0f59f5297ff6859e121efed4c3 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Mon, 27 Sep 2021 23:14:00 +0200 Subject: [PATCH] impl. todos or move to Project.md --- Controller/ApiController.php | 2 +- Models/Bill.php | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/Controller/ApiController.php b/Controller/ApiController.php index 0dae57b..02d1647 100755 --- a/Controller/ApiController.php +++ b/Controller/ApiController.php @@ -175,6 +175,7 @@ final class ApiController extends Controller * @return BillElement * * @since 1.0.0 + * @todo in the database the customer localized version should be stored because this is the version which went out */ public function createBillElementFromRequest(RequestAbstract $request, ResponseAbstract $response, $data = null) : BillElement { @@ -187,7 +188,6 @@ final class ApiController extends Controller } $item = ItemMapper::with('language', $response->getLanguage())::get($element->item); - // @todo: which item name should be stored in the database? server language (problem for international company with subsidiaries)? customer default language/customer invoice language? $element->itemNumber = $item->number; $element->itemName = $item->getL11n('name1')->description; $element->quantity = $request->getData('quantity', 'int'); diff --git a/Models/Bill.php b/Models/Bill.php index 5618fe9..ea38ca4 100755 --- a/Models/Bill.php +++ b/Models/Bill.php @@ -1102,8 +1102,6 @@ BillType $type = 0; * * @return void * - * @todo do same for actual tracking information per trackign id - * * @since 1.0.0 */ public function addTracking(string $tracking) : void