Went through todos

This commit is contained in:
Dennis Eichhorn 2024-05-02 22:54:36 +00:00
parent 428031ab18
commit a3f13a20e6
11 changed files with 26 additions and 46 deletions

View File

@ -53,6 +53,11 @@ use phpOMS\Model\Message\FormValidation;
* @license OMS License 2.0 * @license OMS License 2.0
* @link https://jingga.app * @link https://jingga.app
* @since 1.0.0 * @since 1.0.0
*
* @feature Implement accounting forensics
* Benfords Law, cent value distribution analysis, amount of bookings between specific amounts,
* amount * bookings between specific amounts, etc.
* https://github.com/Karaka-Management/oms-Accounting/issues/1
*/ */
final class ApiController extends Controller final class ApiController extends Controller
{ {
@ -73,6 +78,9 @@ final class ApiController extends Controller
* *
* @return void * @return void
* *
* @todo Implement automatic posting of archived bill
* https://github.com/Karaka-Management/oms-Accounting/issues/10
*
* @since 1.0.0 * @since 1.0.0
*/ */
public function eventBillArchive( public function eventBillArchive(
@ -348,6 +356,9 @@ final class ApiController extends Controller
// @feature Create a way to let admins create a default account format for clients/suppliers // @feature Create a way to let admins create a default account format for clients/suppliers
// https://github.com/Karaka-Management/oms-Accounting/issues/8 // https://github.com/Karaka-Management/oms-Accounting/issues/8
// @feature Add multiple accounts for a client/supplier (see BillTypeCategory)
// https://github.com/Karaka-Management/oms-Accounting/issues/9
$request->header->account = $account; $request->header->account = $account;
$request->setData('code', $new->number . '-1'); $request->setData('code', $new->number . '-1');
$request->setData('content', \rtrim($new->account->name1 . ' ' . $new->account->name2)); $request->setData('content', \rtrim($new->account->name1 . ' ' . $new->account->name2));

View File

@ -16,7 +16,7 @@ use phpOMS\Uri\UriFactory;
/** /**
* @var \phpOMS\Views\View $this * @var \phpOMS\Views\View $this
* @var \Modules\Tag\Models\CostCenter[] $costcenter * @var \Modules\Accounting\Models\CostCenter[] $costcenter
*/ */
$costcenter = $this->data['costcenter']; $costcenter = $this->data['costcenter'];

View File

@ -11,7 +11,10 @@ echo $this->data['nav']->render(); ?>
<div class="row"> <div class="row">
<div class="col-xs-12 col-md-6"> <div class="col-xs-12 col-md-6">
<section class="portlet"> <section class="portlet">
<form method="<?= $isNew ? 'PUT' : 'POST'; ?>" action="<?= UriFactory::build('{/api}accounting/costcenter?csrf={$CSRF}'); ?>"> <form id="iCostCenterForm"
method="<?= $isNew ? 'PUT' : 'POST'; ?>"
action="<?= UriFactory::build('{/api}accounting/costcenter?csrf={$CSRF}'); ?>"
<?= $isNew ? 'data-redirect="' . UriFactory::build('{/base}/accounting/costcenter/view') . '?id={/0/response/id}"' : ''; ?>>
<div class="portlet-head"><?= $this->getHtml('CostCenter'); ?></div> <div class="portlet-head"><?= $this->getHtml('CostCenter'); ?></div>
<div class="portlet-body"> <div class="portlet-body">
<div class="form-group"> <div class="form-group">

View File

@ -16,7 +16,7 @@ use phpOMS\Uri\UriFactory;
/** /**
* @var \phpOMS\Views\View $this * @var \phpOMS\Views\View $this
* @var \Modules\Tag\Models\CostObject[] $costobject * @var \Modules\Accounting\Models\CostObject[] $costobject
*/ */
$costobject = $this->data['costobject']; $costobject = $this->data['costobject'];

View File

@ -11,7 +11,10 @@ echo $this->data['nav']->render(); ?>
<div class="row"> <div class="row">
<div class="col-xs-12 col-md-6"> <div class="col-xs-12 col-md-6">
<section class="portlet"> <section class="portlet">
<form method="<?= $isNew ? 'PUT' : 'POST'; ?>" action="<?= UriFactory::build('{/api}accounting/costobject?csrf={$CSRF}'); ?>"> <form id="iCostObjectForm"
method="<?= $isNew ? 'PUT' : 'POST'; ?>"
action="<?= UriFactory::build('{/api}accounting/costobject?csrf={$CSRF}'); ?>"
<?= $isNew ? 'data-redirect="' . UriFactory::build('{/base}/accounting/costobject/view') . '?id={/0/response/id}"' : ''; ?>>
<div class="portlet-head"><?= $this->getHtml('CostCenter'); ?></div> <div class="portlet-head"><?= $this->getHtml('CostCenter'); ?></div>
<div class="portlet-body"> <div class="portlet-body">
<div class="form-group"> <div class="form-group">

View File

@ -13,13 +13,6 @@
declare(strict_types=1); declare(strict_types=1);
//echo $this->data['nav']->render(); //echo $this->data['nav']->render();
$footerView = new \phpOMS\Views\PaginationView($this->l11nManager, $this->request, $this->response);
$footerView->setTemplate('/Web/Templates/Lists/Footer/PaginationBig');
$footerView->setPages(25);
$footerView->setPage(1);
$footerView->setResults(1);
?> ?>
<div class="row"> <div class="row">

View File

@ -15,14 +15,6 @@ declare(strict_types=1);
/** /**
* @var \phpOMS\Views\View $this * @var \phpOMS\Views\View $this
*/ */
$footerView = new \phpOMS\Views\PaginationView($this->l11nManager, $this->request, $this->response);
$footerView->setTemplate('/Web/Templates/Lists/Footer/PaginationBig');
$footerView->setPages(25);
$footerView->setPage(1);
$footerView->setResults(1);
echo $this->data['nav']->render(); ?> echo $this->data['nav']->render(); ?>
<div class="box w-100"> <div class="box w-100">
@ -34,7 +26,7 @@ echo $this->data['nav']->render(); ?>
<td class="wf-100"><?= $this->getHtml('Name'); ?> <td class="wf-100"><?= $this->getHtml('Name'); ?>
<tbody> <tbody>
<?php $c = 0; foreach ([] as $key => $value) : ++$c; <?php $c = 0; foreach ([] as $key => $value) : ++$c;
$url = \phpOMS\Uri\UriFactory::build('{/base}/admin/group/settings?{?}&id=' . $value->id); ?> $url = \phpOMS\Uri\UriFactory::build('{/base}/admin/group/view?{?}&id=' . $value->id); ?>
<tr> <tr>
<td><a href="<?= $url; ?>"><?= $value->id; ?></a> <td><a href="<?= $url; ?>"><?= $value->id; ?></a>
<td><a href="<?= $url; ?>"><?= $this->printHtml($value->name); ?></a> <td><a href="<?= $url; ?>"><?= $this->printHtml($value->name); ?></a>

View File

@ -116,7 +116,7 @@ echo $this->data['nav']->render(); ?>
<td data-label="<?= $this->getHtml('Country'); ?>"><a href="<?= $url; ?>"><?= $this->printHtml($value->mainAddress->country); ?></a> <td data-label="<?= $this->getHtml('Country'); ?>"><a href="<?= $url; ?>"><?= $this->printHtml($value->mainAddress->country); ?></a>
<?php endforeach; ?> <?php endforeach; ?>
<?php if ($count === 0) : ?> <?php if ($count === 0) : ?>
<tr><td colspan="8" class="empty"><?= $this->getHtml('Empty', '0', '0'); ?> <tr><td colspan="6" class="empty"><?= $this->getHtml('Empty', '0', '0'); ?>
<?php endif; ?> <?php endif; ?>
</table> </table>
</div> </div>

View File

@ -16,13 +16,6 @@ declare(strict_types=1);
* @var \phpOMS\Views\View $this * @var \phpOMS\Views\View $this
*/ */
$footerView = new \phpOMS\Views\PaginationView($this->l11nManager, $this->request, $this->response);
$footerView->setTemplate('/Web/Templates/Lists/Footer/PaginationBig');
$footerView->setPages(25);
$footerView->setPage(1);
$footerView->setResults(1);
echo $this->data['nav']->render(); ?> echo $this->data['nav']->render(); ?>
<div class="box w-100"> <div class="box w-100">
@ -36,7 +29,7 @@ echo $this->data['nav']->render(); ?>
<td><?= $this->getHtml('Created'); ?> <td><?= $this->getHtml('Created'); ?>
<tbody> <tbody>
<?php $c = 0; foreach ([] as $key => $value) : ++$c; <?php $c = 0; foreach ([] as $key => $value) : ++$c;
$url = \phpOMS\Uri\UriFactory::build('{/base}/admin/group/settings?{?}&id=' . $value->id); ?> $url = \phpOMS\Uri\UriFactory::build('{/base}/admin/group/view?{?}&id=' . $value->id); ?>
<tr> <tr>
<td><a href="<?= $url; ?>"><?= $value->id; ?></a> <td><a href="<?= $url; ?>"><?= $value->id; ?></a>
<td><a href="<?= $url; ?>"><?= $this->printHtml($value->name); ?></a> <td><a href="<?= $url; ?>"><?= $this->printHtml($value->name); ?></a>

View File

@ -15,14 +15,6 @@ declare(strict_types=1);
/** /**
* @var \phpOMS\Views\View $this * @var \phpOMS\Views\View $this
*/ */
$footerView = new \phpOMS\Views\PaginationView($this->l11nManager, $this->request, $this->response);
$footerView->setTemplate('/Web/Templates/Lists/Footer/PaginationBig');
$footerView->setPages(25);
$footerView->setPage(1);
$footerView->setResults(1);
echo $this->data['nav']->render(); ?> echo $this->data['nav']->render(); ?>
<div class="row"> <div class="row">
@ -38,7 +30,7 @@ echo $this->data['nav']->render(); ?>
<td><?= $this->getHtml('Created'); ?> <td><?= $this->getHtml('Created'); ?>
<tbody> <tbody>
<?php $c = 0; foreach ([] as $key => $value) : ++$c; <?php $c = 0; foreach ([] as $key => $value) : ++$c;
$url = \phpOMS\Uri\UriFactory::build('{/base}/admin/group/settings?{?}&id=' . $value->id); ?> $url = \phpOMS\Uri\UriFactory::build('{/base}/admin/group/view?{?}&id=' . $value->id); ?>
<tr> <tr>
<td><a href="<?= $url; ?>"><?= $value->id; ?></a> <td><a href="<?= $url; ?>"><?= $value->id; ?></a>
<td><a href="<?= $url; ?>"><?= $this->printHtml($value->name); ?></a> <td><a href="<?= $url; ?>"><?= $this->printHtml($value->name); ?></a>

View File

@ -16,13 +16,6 @@ declare(strict_types=1);
* @var \phpOMS\Views\View $this * @var \phpOMS\Views\View $this
*/ */
$footerView = new \phpOMS\Views\PaginationView($this->l11nManager, $this->request, $this->response);
$footerView->setTemplate('/Web/Templates/Lists/Footer/PaginationBig');
$footerView->setPages(25);
$footerView->setPage(1);
$footerView->setResults(1);
echo $this->data['nav']->render(); ?> echo $this->data['nav']->render(); ?>
<div class="box w-100"> <div class="box w-100">
@ -37,7 +30,7 @@ echo $this->data['nav']->render(); ?>
<td><?= $this->getHtml('Created'); ?> <td><?= $this->getHtml('Created'); ?>
<tbody> <tbody>
<?php $c = 0; foreach ([] as $key => $value) : ++$c; <?php $c = 0; foreach ([] as $key => $value) : ++$c;
$url = \phpOMS\Uri\UriFactory::build('{/base}/admin/group/settings?{?}&id=' . $value->id); ?> $url = \phpOMS\Uri\UriFactory::build('{/base}/admin/group/view?{?}&id=' . $value->id); ?>
<tr> <tr>
<td><a href="<?= $url; ?>"><?= $value->id; ?></a> <td><a href="<?= $url; ?>"><?= $value->id; ?></a>
<td><a href="<?= $url; ?>"><?= $this->printHtml($value->name); ?></a> <td><a href="<?= $url; ?>"><?= $this->printHtml($value->name); ?></a>