From a3f13a20e6626c764ba7a4645fb95bdae985a25d Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Thu, 2 May 2024 22:54:36 +0000 Subject: [PATCH] Went through todos --- Controller/ApiController.php | 11 +++++++++++ Theme/Backend/costcenter-list.tpl.php | 2 +- Theme/Backend/costcenter-view.tpl.php | 5 ++++- Theme/Backend/costobject-list.tpl.php | 2 +- Theme/Backend/costobject-view.tpl.php | 5 ++++- Theme/Backend/entries.tpl.php | 7 ------- Theme/Backend/journal-list.tpl.php | 10 +--------- Theme/Backend/personal-list.tpl.php | 2 +- Theme/Backend/stack-archive-list.tpl.php | 9 +-------- Theme/Backend/stack-list.tpl.php | 10 +--------- Theme/Backend/stack-predefined-list.tpl.php | 9 +-------- 11 files changed, 26 insertions(+), 46 deletions(-) diff --git a/Controller/ApiController.php b/Controller/ApiController.php index 36fcf6d..edf7d1a 100755 --- a/Controller/ApiController.php +++ b/Controller/ApiController.php @@ -53,6 +53,11 @@ use phpOMS\Model\Message\FormValidation; * @license OMS License 2.0 * @link https://jingga.app * @since 1.0.0 + * + * @feature Implement accounting forensics + * Benfords Law, cent value distribution analysis, amount of bookings between specific amounts, + * amount * bookings between specific amounts, etc. + * https://github.com/Karaka-Management/oms-Accounting/issues/1 */ final class ApiController extends Controller { @@ -73,6 +78,9 @@ final class ApiController extends Controller * * @return void * + * @todo Implement automatic posting of archived bill + * https://github.com/Karaka-Management/oms-Accounting/issues/10 + * * @since 1.0.0 */ public function eventBillArchive( @@ -348,6 +356,9 @@ final class ApiController extends Controller // @feature Create a way to let admins create a default account format for clients/suppliers // https://github.com/Karaka-Management/oms-Accounting/issues/8 + // @feature Add multiple accounts for a client/supplier (see BillTypeCategory) + // https://github.com/Karaka-Management/oms-Accounting/issues/9 + $request->header->account = $account; $request->setData('code', $new->number . '-1'); $request->setData('content', \rtrim($new->account->name1 . ' ' . $new->account->name2)); diff --git a/Theme/Backend/costcenter-list.tpl.php b/Theme/Backend/costcenter-list.tpl.php index 6678f4d..d0463b7 100755 --- a/Theme/Backend/costcenter-list.tpl.php +++ b/Theme/Backend/costcenter-list.tpl.php @@ -16,7 +16,7 @@ use phpOMS\Uri\UriFactory; /** * @var \phpOMS\Views\View $this - * @var \Modules\Tag\Models\CostCenter[] $costcenter + * @var \Modules\Accounting\Models\CostCenter[] $costcenter */ $costcenter = $this->data['costcenter']; diff --git a/Theme/Backend/costcenter-view.tpl.php b/Theme/Backend/costcenter-view.tpl.php index 1883a62..f7227c1 100644 --- a/Theme/Backend/costcenter-view.tpl.php +++ b/Theme/Backend/costcenter-view.tpl.php @@ -11,7 +11,10 @@ echo $this->data['nav']->render(); ?>
-
+ >
getHtml('CostCenter'); ?>
diff --git a/Theme/Backend/costobject-list.tpl.php b/Theme/Backend/costobject-list.tpl.php index 8fad2dd..a1d8d38 100755 --- a/Theme/Backend/costobject-list.tpl.php +++ b/Theme/Backend/costobject-list.tpl.php @@ -16,7 +16,7 @@ use phpOMS\Uri\UriFactory; /** * @var \phpOMS\Views\View $this - * @var \Modules\Tag\Models\CostObject[] $costobject + * @var \Modules\Accounting\Models\CostObject[] $costobject */ $costobject = $this->data['costobject']; diff --git a/Theme/Backend/costobject-view.tpl.php b/Theme/Backend/costobject-view.tpl.php index 71dbd77..bbfc033 100644 --- a/Theme/Backend/costobject-view.tpl.php +++ b/Theme/Backend/costobject-view.tpl.php @@ -11,7 +11,10 @@ echo $this->data['nav']->render(); ?>
- + >
getHtml('CostCenter'); ?>
diff --git a/Theme/Backend/entries.tpl.php b/Theme/Backend/entries.tpl.php index 0bf3c6c..8096e01 100755 --- a/Theme/Backend/entries.tpl.php +++ b/Theme/Backend/entries.tpl.php @@ -13,13 +13,6 @@ declare(strict_types=1); //echo $this->data['nav']->render(); - -$footerView = new \phpOMS\Views\PaginationView($this->l11nManager, $this->request, $this->response); -$footerView->setTemplate('/Web/Templates/Lists/Footer/PaginationBig'); - -$footerView->setPages(25); -$footerView->setPage(1); -$footerView->setResults(1); ?>
diff --git a/Theme/Backend/journal-list.tpl.php b/Theme/Backend/journal-list.tpl.php index 6de73fd..3495f83 100755 --- a/Theme/Backend/journal-list.tpl.php +++ b/Theme/Backend/journal-list.tpl.php @@ -15,14 +15,6 @@ declare(strict_types=1); /** * @var \phpOMS\Views\View $this */ - -$footerView = new \phpOMS\Views\PaginationView($this->l11nManager, $this->request, $this->response); -$footerView->setTemplate('/Web/Templates/Lists/Footer/PaginationBig'); - -$footerView->setPages(25); -$footerView->setPage(1); -$footerView->setResults(1); - echo $this->data['nav']->render(); ?>
@@ -34,7 +26,7 @@ echo $this->data['nav']->render(); ?> getHtml('Name'); ?> $value) : ++$c; - $url = \phpOMS\Uri\UriFactory::build('{/base}/admin/group/settings?{?}&id=' . $value->id); ?> + $url = \phpOMS\Uri\UriFactory::build('{/base}/admin/group/view?{?}&id=' . $value->id); ?> id; ?> printHtml($value->name); ?> diff --git a/Theme/Backend/personal-list.tpl.php b/Theme/Backend/personal-list.tpl.php index fdee5f5..18a79ab 100644 --- a/Theme/Backend/personal-list.tpl.php +++ b/Theme/Backend/personal-list.tpl.php @@ -116,7 +116,7 @@ echo $this->data['nav']->render(); ?> printHtml($value->mainAddress->country); ?> - getHtml('Empty', '0', '0'); ?> + getHtml('Empty', '0', '0'); ?>
diff --git a/Theme/Backend/stack-archive-list.tpl.php b/Theme/Backend/stack-archive-list.tpl.php index a437246..c219b27 100755 --- a/Theme/Backend/stack-archive-list.tpl.php +++ b/Theme/Backend/stack-archive-list.tpl.php @@ -16,13 +16,6 @@ declare(strict_types=1); * @var \phpOMS\Views\View $this */ -$footerView = new \phpOMS\Views\PaginationView($this->l11nManager, $this->request, $this->response); -$footerView->setTemplate('/Web/Templates/Lists/Footer/PaginationBig'); - -$footerView->setPages(25); -$footerView->setPage(1); -$footerView->setResults(1); - echo $this->data['nav']->render(); ?>
@@ -36,7 +29,7 @@ echo $this->data['nav']->render(); ?> getHtml('Created'); ?> $value) : ++$c; - $url = \phpOMS\Uri\UriFactory::build('{/base}/admin/group/settings?{?}&id=' . $value->id); ?> + $url = \phpOMS\Uri\UriFactory::build('{/base}/admin/group/view?{?}&id=' . $value->id); ?> id; ?> printHtml($value->name); ?> diff --git a/Theme/Backend/stack-list.tpl.php b/Theme/Backend/stack-list.tpl.php index 6a5f95e..f1d2698 100755 --- a/Theme/Backend/stack-list.tpl.php +++ b/Theme/Backend/stack-list.tpl.php @@ -15,14 +15,6 @@ declare(strict_types=1); /** * @var \phpOMS\Views\View $this */ - -$footerView = new \phpOMS\Views\PaginationView($this->l11nManager, $this->request, $this->response); -$footerView->setTemplate('/Web/Templates/Lists/Footer/PaginationBig'); - -$footerView->setPages(25); -$footerView->setPage(1); -$footerView->setResults(1); - echo $this->data['nav']->render(); ?>
@@ -38,7 +30,7 @@ echo $this->data['nav']->render(); ?> getHtml('Created'); ?> $value) : ++$c; - $url = \phpOMS\Uri\UriFactory::build('{/base}/admin/group/settings?{?}&id=' . $value->id); ?> + $url = \phpOMS\Uri\UriFactory::build('{/base}/admin/group/view?{?}&id=' . $value->id); ?> id; ?> printHtml($value->name); ?> diff --git a/Theme/Backend/stack-predefined-list.tpl.php b/Theme/Backend/stack-predefined-list.tpl.php index 99c7b69..44cd0e4 100755 --- a/Theme/Backend/stack-predefined-list.tpl.php +++ b/Theme/Backend/stack-predefined-list.tpl.php @@ -16,13 +16,6 @@ declare(strict_types=1); * @var \phpOMS\Views\View $this */ -$footerView = new \phpOMS\Views\PaginationView($this->l11nManager, $this->request, $this->response); -$footerView->setTemplate('/Web/Templates/Lists/Footer/PaginationBig'); - -$footerView->setPages(25); -$footerView->setPage(1); -$footerView->setResults(1); - echo $this->data['nav']->render(); ?>
@@ -37,7 +30,7 @@ echo $this->data['nav']->render(); ?> getHtml('Created'); ?> $value) : ++$c; - $url = \phpOMS\Uri\UriFactory::build('{/base}/admin/group/settings?{?}&id=' . $value->id); ?> + $url = \phpOMS\Uri\UriFactory::build('{/base}/admin/group/view?{?}&id=' . $value->id); ?> id; ?> printHtml($value->name); ?>