Jingga/phpOMS
1
0
Fork 0
mirror of https://github.com/Karaka-Management/phpOMS.git synced 2026-02-12 23:08:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

optimize isset

Browse Source
This commit is contained in:
Dennis Eichhorn 2017-05-29 21:26:14 +02:00
parent 098fe4130a
commit f86d8d8622
6 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
DataStorage/Database/DataMapperAbstract.php
View File

@ -1843,7 +1843,7 @@ class DataMapperAbstract implements DataMapperInterface
$query = static::getQuery(); $query = static::getQuery();
$query->limit($limit); $query->limit($limit);
if (isset($from) && isset($to) && !empty(static::getCreatedAt())) { if (isset($from, $to) && !empty(static::getCreatedAt())) {
$query->where(static::getCreatedAt(), '>=', $from); $query->where(static::getCreatedAt(), '>=', $from);
$query->where(static::getCreatedAt(), '<=', $to); $query->where(static::getCreatedAt(), '<=', $to);
} }

2
Localization/L11nManager.php
View File

@ -151,7 +151,7 @@ class L11nManager
{ {
if (!isset($module) && isset($this->language[$language])) { if (!isset($module) && isset($this->language[$language])) {
return $this->language[$language]; return $this->language[$language];
} elseif (isset($this->language[$language]) && isset($this->language[$language][$module])) { } elseif (isset($this->language[$language], $this->language[$language][$module])) {
return $this->language[$language][$module]; return $this->language[$language][$module];
} else { } else {
return []; return [];

2
Stdlib/Graph/BinaryTree.php
View File

@ -217,7 +217,7 @@ class BinaryTree extends Tree
$right2 = isset($node2) ? $this->getRight($node1) : $this->getRight($node2); $right2 = isset($node2) ? $this->getRight($node1) : $this->getRight($node2);
// todo: compare values? true symmetry requires the values to be the same // todo: compare values? true symmetry requires the values to be the same
if(isset($node1) && isset($node2)) { if(isset($node1, $node2)) {
return $this->isSymmetric($left1, $right2) && $this->isSymmetric($right1, $left2); return $this->isSymmetric($left1, $right2) && $this->isSymmetric($right1, $left2);
} }

2
Stdlib/Map/MultiMap.php
View File

@ -370,7 +370,7 @@ class MultiMap implements \Countable
return false; return false;
} }
if (isset($this->keys[$old]) && isset($this->keys[$new])) { if (isset($this->keys[$old], $this->keys[$new])) {
$this->keys[$old] = $this->keys[$new]; $this->keys[$old] = $this->keys[$new];
$this->garbageCollect(); $this->garbageCollect();

2
System/File/Ftp/FtpStorage.php
View File

@ -51,7 +51,7 @@ class FtpStorage extends StorageAbstract
ftp_pasv($this->con, $mode); ftp_pasv($this->con, $mode);
if(isset($login) && isset($pass)) { if(isset($login, $pass)) {
ftp_login($this->con, $login, $pass); ftp_login($this->con, $login, $pass);
} }
} }

2
Utils/Barcode/C25.php
View File

@ -127,7 +127,7 @@ class C25 extends C128Abstract
} }
for ($posX = 1; $posX <= $length; $posX += 2) { for ($posX = 1; $posX <= $length; $posX += 2) {
if (isset($temp[$posX]) && isset($temp[($posX + 1)])) { if (isset($temp[$posX], $temp[($posX + 1)])) {
$temp1 = explode('-', $temp[$posX]); $temp1 = explode('-', $temp[$posX]);
$temp2 = explode('-', $temp[($posX + 1)]); $temp2 = explode('-', $temp[($posX + 1)]);