From ec49bf2dc190badcf57d2e5c362b15f3626ab9e1 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Tue, 24 Oct 2023 18:39:14 +0000 Subject: [PATCH] fix tests --- Stdlib/Tree/BinarySearchTree.php | 8 ++++---- tests/Stdlib/Tree/BinarySearchTreeTest.php | 22 +++++++++++----------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/Stdlib/Tree/BinarySearchTree.php b/Stdlib/Tree/BinarySearchTree.php index 5c3935ef0..921eb99c0 100644 --- a/Stdlib/Tree/BinarySearchTree.php +++ b/Stdlib/Tree/BinarySearchTree.php @@ -247,7 +247,7 @@ class BinarySearchTree } $temp = null; - if ($node->right !== null) { + if ($node->left === null) { $temp = $node->right->root; if ($temp === null) { return; @@ -272,7 +272,7 @@ class BinarySearchTree return; } - if ($node->left !== null) { + if ($node->right === null) { $temp = $node->left->root; if ($temp === null) { return; @@ -306,11 +306,11 @@ class BinarySearchTree /** * To array * - * @return array + * @return null|array * * @since 1.0.0 */ - public function toArray() : array + public function toArray() : ?array { return $this->root?->toArray() ?? null; } diff --git a/tests/Stdlib/Tree/BinarySearchTreeTest.php b/tests/Stdlib/Tree/BinarySearchTreeTest.php index 3df924ace..8c6d5a6b3 100644 --- a/tests/Stdlib/Tree/BinarySearchTreeTest.php +++ b/tests/Stdlib/Tree/BinarySearchTreeTest.php @@ -124,20 +124,20 @@ final class BinarySearchTreeTest extends \PHPUnit\Framework\TestCase 'key' => 'O', 0 => null, 1 => [ - 'key' => 'R', - 0 => null, - 1 => [ - 'key' => 'U', - 0 => [ + 'key' => 'U', + 0 => [ + 'key' => 'R', + 0 => null, + 1 => [ 'key' => 'T', 0 => null, 1 => null - ], - 1 => [ - 'key' => 'Z', - 0 => null, - 1 => null - ], + ] + ], + 1 => [ + 'key' => 'Z', + 0 => null, + 1 => null ], ], ],