From d5643868b6d2970ed564b082c8f4c0f221140c4f Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nes.com@googlemail.com>
Date: Tue, 31 Mar 2020 19:00:58 +0200
Subject: [PATCH] add todo/question for global conditionals

---
 DataStorage/Database/DataMapperAbstract.php | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/DataStorage/Database/DataMapperAbstract.php b/DataStorage/Database/DataMapperAbstract.php
index 7ae47c15c..dfc8f9e75 100644
--- a/DataStorage/Database/DataMapperAbstract.php
+++ b/DataStorage/Database/DataMapperAbstract.php
@@ -46,6 +46,14 @@ use phpOMS\Utils\ArrayUtils;
  * @todo Orange-Management/Modules#99
  *  Use binds
  *  Currently databinds are not used. Currently injections are possible.
+ *
+ * @todo Orange-Management/phpOMS#241
+ *      [DataMapper] Consider global conditionals
+ *      In some cases conditionals in the mapper are typed again and again
+ *          e.g. language conditional for localization purposes
+ *      This is very annoying and maybe could be defined once in a `$conditionalsGlobal = [];` array.
+ *      This array then populates the `$conditionals` array in the mapper.
+ *      Overwriting the global conditionals could be possible by defining a conditional as `null`.
  */
 class DataMapperAbstract implements DataMapperInterface
 {