Jingga/phpOMS
1
0
Fork 0
mirror of https://github.com/Karaka-Management/phpOMS.git synced 2026-02-12 06:48:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix lock(). make member

Browse Source
This commit is contained in:
Dennis Eichhorn 2018-11-30 22:06:03 +01:00
parent ce939eb7de
commit d47f3aa19d
3 changed files with 6 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Message/Console/Header.php
View File

@ -69,7 +69,7 @@ final class Header extends HeaderAbstract
*/ */
public function set(string $key, string $header, bool $overwrite = false) : bool public function set(string $key, string $header, bool $overwrite = false) : bool
{ {
if (self::$isLocked) { if ($this->isLocked) {
return false; return false;
} }
@ -109,7 +109,7 @@ final class Header extends HeaderAbstract
*/ */
public function remove($key) : bool public function remove($key) : bool
{ {
if (self::$isLocked) { if ($this->isLocked) {
return false; return false;
} }

12
tests/Message/Console/HeaderTest.php
View File

@ -59,20 +59,16 @@ class HeaderTest extends \PHPUnit\Framework\TestCase
public function testLockedHeaderSet() public function testLockedHeaderSet()
{ {
$header = new Header(); $header = new Header();
Header::lock(); $header->lock();
self::assertTrue(Header::isLocked()); self::assertTrue($header->isLocked());
self::assertFalse($header->set('key', 'value')); self::assertFalse($header->set('key', 'value'));
TestUtils::setMember('phpOMS\Message\Console\Header', 'isLocked', false);
} }
public function testLockedHeaderRemove() public function testLockedHeaderRemove()
{ {
$header = new Header(); $header = new Header();
Header::lock(); $header->lock();
self::assertTrue(Header::isLocked()); self::assertTrue($header->isLocked());
self::assertFalse($header->remove('key')); self::assertFalse($header->remove('key'));
TestUtils::setMember('phpOMS\Message\Console\Header', 'isLocked', false);
} }
} }

5
tests/Message/Http/HeaderTest.php
View File

@ -41,7 +41,6 @@ class HeaderTest extends \PHPUnit\Framework\TestCase
self::assertTrue(Header::isSecurityHeader('X-xss-protection')); self::assertTrue(Header::isSecurityHeader('X-xss-protection'));
self::assertTrue(Header::isSecurityHeader('x-conTent-tYpe-options')); self::assertTrue(Header::isSecurityHeader('x-conTent-tYpe-options'));
self::assertTrue(Header::isSecurityHeader('x-frame-options')); self::assertTrue(Header::isSecurityHeader('x-frame-options'));
self::assertFalse(Header::isSecurityHeader('x-frame-optionss')); self::assertFalse(Header::isSecurityHeader('x-frame-optionss'));
} }
@ -73,8 +72,6 @@ class HeaderTest extends \PHPUnit\Framework\TestCase
$header->lock(); $header->lock();
self::assertTrue($header->isLocked()); self::assertTrue($header->isLocked());
self::assertFalse($header->set('key', 'value')); self::assertFalse($header->set('key', 'value'));
TestUtils::setMember('phpOMS\Message\Http\Header', 'isLocked', false);
} }
public function testLockedHeaderRemove() public function testLockedHeaderRemove()
@ -83,8 +80,6 @@ class HeaderTest extends \PHPUnit\Framework\TestCase
$header->lock(); $header->lock();
self::assertTrue($header->isLocked()); self::assertTrue($header->isLocked());
self::assertFalse($header->remove('key')); self::assertFalse($header->remove('key'));
TestUtils::setMember('phpOMS\Message\Http\Header', 'isLocked', false);
} }
public function testGeneration() public function testGeneration()