Jingga/phpOMS
1
0
Fork 0
mirror of https://github.com/Karaka-Management/phpOMS.git synced 2026-02-09 21:48:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Simplify output

Browse Source
This commit is contained in:
Dennis Eichhorn 2018-12-09 16:24:24 +01:00
parent 79ddd42321
commit c125937f05
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Message/Http/Response.php
View File

@ -20,6 +20,7 @@ use phpOMS\Message\ResponseAbstract;
use phpOMS\System\MimeType; use phpOMS\System\MimeType;
use phpOMS\Views\View; use phpOMS\Views\View;
use phpOMS\Log\FileLogger; use phpOMS\Log\FileLogger;
use phpOMS\Utils\StringUtils;
/** /**
* Response class. * Response class.
@ -128,15 +129,7 @@ final class Response extends ResponseAbstract implements RenderableInterface
$render = ''; $render = '';
foreach ($this->response as $key => $response) { foreach ($this->response as $key => $response) {
if ($response instanceOf \Serializable) { $render .= StringUtils::stringify($response);
$render .= $response->serialize();
} elseif (\is_string($response) || \is_numeric($response)) {
$render .= $response;
} elseif (\is_array($response)) {
$render .= \json_encode($response);
} else {
throw new \Exception('Wrong response type');
}
} }
return $this->removeWhitespaceAndLineBreak($render); return $this->removeWhitespaceAndLineBreak($render);
@ -163,6 +156,7 @@ final class Response extends ResponseAbstract implements RenderableInterface
/** /**
* {@inheritdoc} * {@inheritdoc}
* @todo: this whole workflow with json got improved a little bit but this part looks bad. do i really need so much code or could i simplify it
*/ */
public function toArray() : array public function toArray() : array
{ {