From bbab09b0ea192fbc5c965d883f7af0a3ddc9a8fb Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Tue, 2 Nov 2021 21:57:10 +0100 Subject: [PATCH] add unit tests --- DataStorage/Database/DataMapperAbstract.php | 2 +- Message/Http/HttpHeader.php | 3 +-- tests/phpunit_no_coverage.xml | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/DataStorage/Database/DataMapperAbstract.php b/DataStorage/Database/DataMapperAbstract.php index 9640e509a..774515800 100644 --- a/DataStorage/Database/DataMapperAbstract.php +++ b/DataStorage/Database/DataMapperAbstract.php @@ -2932,7 +2932,7 @@ class DataMapperAbstract implements DataMapperInterface */ public static function getNewest(int $limit = 1, Builder $query = null, int $relations = RelationType::ALL, int $depth = 3) : array { - $query ??= self::getQuery(null, [], $relations, $depth); + $query = self::getQuery($query, [], $relations, $depth); $query->limit($limit); if (!empty(static::$createdAt)) { diff --git a/Message/Http/HttpHeader.php b/Message/Http/HttpHeader.php index 7d787ea4e..4803c7076 100644 --- a/Message/Http/HttpHeader.php +++ b/Message/Http/HttpHeader.php @@ -62,12 +62,11 @@ final class HttpHeader extends HeaderAbstract return false; } + $key = \strtolower($key); if (self::isSecurityHeader($key) && isset($this->header[$key])) { return false; } - $key = \strtolower($key); - if (!$overwrite && isset($this->header[$key])) { return false; } diff --git a/tests/phpunit_no_coverage.xml b/tests/phpunit_no_coverage.xml index b77acb1e9..ce297f211 100644 --- a/tests/phpunit_no_coverage.xml +++ b/tests/phpunit_no_coverage.xml @@ -1,5 +1,5 @@ - + .*