fix return types

This commit is contained in:
Dennis Eichhorn 2017-09-08 19:34:33 +02:00
parent c2e5dd8105
commit ad3f91bf24

View File

@ -15,8 +15,6 @@ declare(strict_types=1);
namespace phpOMS\DataStorage\Database; namespace phpOMS\DataStorage\Database;
use phpOMS\DataStorage\Database\Schema\Exception\TableException;
/** /**
* Database exception factory. * Database exception factory.
* *
@ -33,17 +31,17 @@ class DatabaseExceptionFactory
* *
* @param \PDOException $e Exception * @param \PDOException $e Exception
* *
* @return \PDOException * @return string
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public static function createException(\PDOException $e) : \PDOException public static function createException(\PDOException $e) : string
{ {
switch ($e->getCode()) { switch ($e->getCode()) {
case '42S02': case '42S02':
return self::createTableViewException($e); return '\phpOMS\DataStorage\Database\Schema\Exception\TableException';
default: default:
return $e; return '\PDOException';
} }
} }
@ -52,31 +50,17 @@ class DatabaseExceptionFactory
* *
* @param \PDOException $e Exception * @param \PDOException $e Exception
* *
* @return \PDOException * @return string
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public static function createExceptionMessage(\PDOException $e) : \PDOException public static function createExceptionMessage(\PDOException $e) : string
{ {
switch ($e->getCode()) { switch ($e->getCode()) {
case '42S02': case '42S02':
return self::createTableViewExceptionMessage($e); return TableException::findTable($e->getMessage());
default: default:
return $e; return $e->getMessage();
} }
} }
/**
* Create table exception.
*
* @param \PDOException $e Exception
*
* @return \PDOException
*
* @since 1.0.0
*/
private static function createTableViewException(\PDOException $e) : string
{
return TableException::findTable($e->getMessage());
}
} }