From a4b6411fcdefea708142462a2c2bef96538ed81d Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nes.com@googlemail.com>
Date: Sun, 3 Jun 2018 10:33:27 +0200
Subject: [PATCH] Implement NullCommit

---
 Utils/Git/NullCommit.php | 27 +++++++++++++++++++++++++++
 Utils/Git/Repository.php | 13 +++++--------
 2 files changed, 32 insertions(+), 8 deletions(-)
 create mode 100644 Utils/Git/NullCommit.php

diff --git a/Utils/Git/NullCommit.php b/Utils/Git/NullCommit.php
new file mode 100644
index 000000000..60a341b0b
--- /dev/null
+++ b/Utils/Git/NullCommit.php
@@ -0,0 +1,27 @@
+<?php
+/**
+ * Orange Management
+ *
+ * PHP Version 7.2
+ *
+ * @package    phpOMS\Utils\Git
+ * @copyright  Dennis Eichhorn
+ * @license    OMS License 1.0
+ * @version    1.0.0
+ * @link       http://website.orange-management.de
+ */
+declare(strict_types=1);
+
+namespace phpOMS\Utils\Git;
+
+/**
+ * Gray encoding class
+ *
+ * @package    phpOMS\Utils\Git
+ * @license    OMS License 1.0
+ * @link       http://website.orange-management.de
+ * @since      1.0.0
+ */
+class NullCommit extends Commit
+{
+}
diff --git a/Utils/Git/Repository.php b/Utils/Git/Repository.php
index 46117aad5..d8e34f367 100644
--- a/Utils/Git/Repository.php
+++ b/Utils/Git/Repository.php
@@ -864,8 +864,7 @@ class Repository
         $count = count($lines);
 
         if (empty($lines)) {
-            // todo: return null commit
-            return new Commit();
+            return new NullCommit();
         }
 
         \preg_match('/[0-9ABCDEFabcdef]{40}/', $lines[0], $matches);
@@ -878,10 +877,9 @@ class Repository
             return new Commit();
         }
 
-        // todo: validate if array values are all initialized
-        $author = \explode(':', $lines[1]);
-        $author = \explode('<', trim($author[1]));
-        $date   = substr($lines[2], 6);
+        $author = \explode(':', $lines[1] ?? '');
+        $author = \explode('<', trim($author[1] ?? ''));
+        $date   = substr($lines[2] ?? '', 6);
 
         $commit = new Commit($matches[0]);
         $commit->setAuthor(new Author(trim($author[0] ?? ''), rtrim($author[1] ?? '', '>')));
@@ -914,8 +912,7 @@ class Repository
         $lines = $this->run('log -n ' . $limit);
 
         if (empty($lines)) {
-            // todo: return nullcommit
-            return new Commit();
+            return new NullCommit();
         }
 
         \preg_match('/[0-9ABCDEFabcdef]{40}/', $lines[0], $matches);