Jingga/phpOMS
1
0
Fork 0
mirror of https://github.com/Karaka-Management/phpOMS.git synced 2026-01-11 17:58:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix scrutinizer tips

Browse Source
This commit is contained in:
Dennis Eichhorn 2017-10-27 17:24:33 +02:00
parent f652a900d0
commit 91eb1f261f
29 changed files with 52 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Account/Account.php
View File

@ -136,7 +136,7 @@ class Account implements ArrayableInterface, \JsonSerializable
/**
* Account type.
*
* @var AccountType|int
* @var int
* @since 1.0.0
*/
protected $type = AccountType::USER;
@ -144,7 +144,7 @@ class Account implements ArrayableInterface, \JsonSerializable
/**
* Account status.
*
* @var AccountStatus|int
* @var int
* @since 1.0.0
*/
protected $status = AccountStatus::INACTIVE;
@ -624,8 +624,8 @@ class Account implements ArrayableInterface, \JsonSerializable
/**
* Json serialize.
*
* @return string
*
* @return array
*
* @since 1.0.0
*/

2
Account/Group.php
View File

@ -208,7 +208,7 @@ class Group implements ArrayableInterface, \JsonSerializable
/**
* Json serialize.
*
* @return string
* @return array
*
* @since 1.0.0
*/

2
Account/PermissionAbstract.php
View File

@ -340,7 +340,7 @@ class PermissionAbstract
*
* @param int $permission Permission
*
* @return void
* @return bool
*
* @since 1.0.0
*/

2
AutoloadException.php
View File

@ -31,7 +31,7 @@ class AutoloadException extends \RuntimeException
*
* @param string $message Exception message
* @param int $code Exception code
* @param \Exception Previous exception
* @param \Exception $previous Previous exception
*
* @since 1.0.0
*/

2
DataStorage/Cache/CachePool.php
View File

@ -39,7 +39,7 @@ class CachePool implements OptionsInterface
/**
* MemCache instance.
*
* @var \phpOMS\DataStorage\Cache\CacheInterface
* @var \phpOMS\DataStorage\Cache\CacheInterface[]
* @since 1.0.0
*/
private $pool = null;

6
DataStorage/Database/Connection/ConnectionAbstract.php
View File

@ -65,15 +65,15 @@ abstract class ConnectionAbstract implements ConnectionInterface
/**
* Database type.
*
* @var \phpOMS\DataStorage\Database\DatabaseType
* @var string
* @since 1.0.0
*/
protected $type = null;
protected $type = 'undefined';
/**
* Database status.
*
* @var DatabaseStatus
* @var int
* @since 1.0.0
*/
protected $status = DatabaseStatus::CLOSED;

2
DataStorage/Database/Exception/InvalidConnectionConfigException.php
View File

@ -31,7 +31,7 @@ class InvalidConnectionConfigException extends \InvalidArgumentException
*
* @param string $message Exception message
* @param int $code Exception code
* @param \Exception Previous exception
* @param \Exception $previous Previous exception
*
* @since 1.0.0
*/

2
DataStorage/Database/Exception/InvalidMapperException.php
View File

@ -31,7 +31,7 @@ class InvalidMapperException extends \RuntimeException
*
* @param string $message Exception message
* @param int $code Exception code
* @param \Exception Previous exception
* @param \Exception $previous Previous exception
*
* @since 1.0.0
*/

2
DataStorage/Database/Schema/Exception/TableException.php
View File

@ -31,7 +31,7 @@ class TableException extends \PDOException
*
* @param string $message Exception message
* @param int $code Exception code
* @param \Exception Previous exception
* @param \Exception $previous Previous exception
*
* @since 1.0.0
*/

2
DataStorage/LockException.php
View File

@ -31,7 +31,7 @@ class LockException extends \RuntimeException
*
* @param string $message Exception message
* @param int $code Exception code
* @param \Exception Previous exception
* @param \Exception $previous Previous exception
*
* @since 1.0.0
*/

2
Math/Exception/ZeroDevisionException.php
View File

@ -31,7 +31,7 @@ class ZeroDevisionException extends \UnexpectedValueException
*
* @param string $message Exception message
* @param int $code Exception code
* @param \Exception Previous exception
* @param \Exception $previous Previous exception
*
* @since 1.0.0
*/

8
Math/Functions/Functions.php
View File

@ -250,15 +250,15 @@ class Functions
* @example The relative fiscal month (August) in a company where the fiscal year starts in July.
* @example 2 = getRelativeDegree(8, 12, 7);
*
* @param mixed $value Value to get degree
* @param mixed $length Circle size
* @param mixed $start Start value
* @param int $value Value to get degree
* @param int $length Circle size
* @param int $start Start value
*
* @return int Lowest value is 0 and highest value is length - 1
*
* @since 1.0.0
*/
public static function getRelativeDegree($value, $length, $start = 0) : int
public static function getRelativeDegree(int $value, int $length, int $start = 0) : int
{
return abs(self::mod($value - $start, $length));
}

2
Math/Matrix/Exception/InvalidDimensionException.php
View File

@ -31,7 +31,7 @@ class InvalidDimensionException extends \UnexpectedValueException
*
* @param string $message Exception message
* @param int $code Exception code
* @param \Exception Previous exception
* @param \Exception $previous Previous exception
*
* @since 1.0.0
*/

4
Math/Statistic/Average.php
View File

@ -185,12 +185,12 @@ class Average
*
* @since 1.0.0
*/
public static function mode($values)
public static function mode(array $values)
{
$count = array_count_values($values);
$best = max($count);
return array_keys($count, $best);
return (float) (array_keys($count, $best)[0] ?? 0.0);
}
/**

2
Message/RequestAbstract.php
View File

@ -74,7 +74,7 @@ abstract class RequestAbstract implements MessageInterface
/**
* Request type.
*
* @var \phpOMS\Message\RequestSource
* @var int
* @since 1.0.0
*/
protected $source = RequestSource::UNDEFINED;

2
Module/Exception/InvalidModuleException.php
View File

@ -31,7 +31,7 @@ class InvalidModuleException extends \UnexpectedValueException
*
* @param string $message Exception message
* @param int $code Exception code
* @param \Exception Previous exception
* @param \Exception $previous Previous exception
*
* @since 1.0.0
*/

2
Module/Exception/InvalidThemeException.php
View File

@ -31,7 +31,7 @@ class InvalidThemeException extends \UnexpectedValueException
*
* @param string $message Exception message
* @param int $code Exception code
* @param \Exception Previous exception
* @param \Exception $previous Previous exception
*
* @since 1.0.0
*/

2
Module/ModuleAbstract.php
View File

@ -76,7 +76,7 @@ abstract class ModuleAbstract
/**
* Dependencies.
*
* @var string
* @var string[]
* @since 1.0.0
*/
protected static $dependencies = [];

8
Module/PackageManager.php
View File

@ -70,7 +70,7 @@ class PackageManager
* Constructor.
*
* @param string $path Package source path e.g. path after download.
* @param string basePath Path of the application
* @param string $basePath Path of the application
*
* @since 1.0.0
*/
@ -85,11 +85,11 @@ class PackageManager
*
* @param string $path Temporary extract path
*
* @return bool
*
* @return void
*
* @since 1.0.0
*/
public function extract(string $path) : bool
public function extract(string $path) /* : void */
{
$this->extractPath = $path;
Zip::unpack($this->path, $this->extractPath);

2
Router/Router.php
View File

@ -96,7 +96,7 @@ class Router
* @param string|RequestAbstract $request Request to route
* @param int $verb Route verb
*
* @return string[]
* @return array[]
*
* @throws \InvalidArgumentException
*

2
Stdlib/Base/Exception/InvalidEnumName.php
View File

@ -34,7 +34,7 @@ class InvalidEnumName extends \UnexpectedValueException
*
* @param string $message Exception message
* @param int $code Exception code
* @param \Exception Previous exception
* @param \Exception $previous Previous exception
*
* @since 1.0.0
*/

2
Stdlib/Base/Exception/InvalidEnumValue.php
View File

@ -34,7 +34,7 @@ class InvalidEnumValue extends \UnexpectedValueException
*
* @param string $message Exception message
* @param int $code Exception code
* @param \Exception Previous exception
* @param \Exception $previous Previous exception
*
* @since 1.0.0
*/

18
Stdlib/Map/MultiMap.php
View File

@ -92,7 +92,7 @@ class MultiMap implements \Countable
$inserted = false;
if ($this->keyType !== KeyType::SINGLE) {
$keys = [implode($keys, ':')];
$keys = [implode(':', $keys)];
}
foreach ($keys as $key) {
@ -186,14 +186,14 @@ class MultiMap implements \Countable
$keys = Permutation::permut($key);
foreach ($keys as $key => $value) {
$key = implode($value, ':');
$key = implode(':', $value);
if (isset($this->keys[$key])) {
return $this->values[$this->keys[$key]];
}
}
} else {
$key = implode($key, ':');
$key = implode(':', $key);
}
}
@ -235,12 +235,12 @@ class MultiMap implements \Countable
$permutation = Permutation::permut($key);
foreach ($permutation as $permut) {
if ($this->set(implode($permut, ':'), $value)) {
if ($this->set(implode(':', $permut), $value)) {
return true;
}
}
} else {
return $this->set(implode($key, ':'), $value);
return $this->set(implode(':', $key), $value);
}
return false;
@ -302,12 +302,12 @@ class MultiMap implements \Countable
$removed = false;
foreach ($keys as $key => $value) {
$removed |= $this->remove(implode($value, ':'));
$removed |= $this->remove(implode(':', $value));
}
return $removed;
} else {
return $this->remove(implode($key, ':'));
return $this->remove(implode(':', $key));
}
}
@ -403,12 +403,12 @@ class MultiMap implements \Countable
$removed = false;
foreach ($keys as $key => $value) {
$removed |= $this->removeKey(implode($value, ':'));
$removed |= $this->removeKey(implode(':', $value));
}
return $removed;
} else {
return $this->removeKey(implode($key, ':'));
return $this->removeKey(implode(':', $key));
}
}

2
System/File/PathException.php
View File

@ -31,7 +31,7 @@ class PathException extends \UnexpectedValueException
*
* @param string $message Exception message
* @param int $code Exception code
* @param \Exception Previous exception
* @param \Exception $previous Previous exception
*
* @since 1.0.0
*/

2
System/File/PermissionException.php
View File

@ -31,7 +31,7 @@ class PermissionException extends \RuntimeException
*
* @param string $message Exception message
* @param int $code Exception code
* @param \Exception Previous exception
* @param \Exception $previous Previous exception
*
* @since 1.0.0
*/

5
System/SystemUtils.php
View File

@ -46,10 +46,12 @@ class SystemUtils
*/
public static function getRAM() : int
{
$mem = null;
$mem = 0;
if (stristr(PHP_OS, 'WIN')) {
exec('wmic memorychip get capacity', $mem);
/** @var array $mem */
$mem = array_sum($mem) / 1024;
} elseif (stristr(PHP_OS, 'LINUX')) {
$fh = fopen('/proc/meminfo', 'r');
@ -62,6 +64,7 @@ class SystemUtils
break;
}
}
fclose($fh);
}

2
Uri/InvalidUriException.php
View File

@ -31,7 +31,7 @@ class InvalidUriException extends \UnexpectedValueException
*
* @param string $message Exception message
* @param int $code Exception code
* @param \Exception Previous exception
* @param \Exception $previous Previous exception
*
* @since 1.0.0
*/

2
Utils/IO/Json/InvalidJsonException.php
View File

@ -31,7 +31,7 @@ class InvalidJsonException extends \UnexpectedValueException
*
* @param string $message Exception message
* @param int $code Exception code
* @param \Exception Previous exception
* @param \Exception $previous Previous exception
*
* @since 1.0.0
*/

2
Views/ViewAbstract.php
View File

@ -182,7 +182,7 @@ abstract class ViewAbstract implements \Serializable
public function serialize()
{
if (empty($this->template)) {
return $this->toArray();
return json_encode($this->toArray());
}
return $this->render();