add sqlsrv and fix system escaping

DataStorage/Database/GrammarAbstract.php

@@ -48,7 +48,15 @@ abstract class GrammarAbstract
      * @var string
      * @since 1.0.0
      */
-    protected string $systemIdentifier = '"';
+    protected string $systemIdentifierStart = '"';
+
+    /**
+     * System identifier.
+     *
+     * @var string
+     * @since 1.0.0
+     */
+    protected string $systemIdentifierEnd = '"';
 
     /**
      * And operator.
@@ -201,11 +209,13 @@ abstract class GrammarAbstract
      */
     protected function compileSystem(string $system) : string
     {
-        $identifier = $this->systemIdentifier;
+        $identifierStart = $this->systemIdentifierStart;
+        $identifierEnd   = $this->systemIdentifierEnd;
 
         foreach ($this->specialKeywords as $keyword) {
             if (\strrpos($system, $keyword, -\strlen($system)) !== false) {
-                $identifier = '';
+                $identifierStart = '';
+                $identifierEnd   = '';
 
                 break;
             }
@@ -216,9 +226,9 @@ abstract class GrammarAbstract
 
         foreach ($split as $key => $system) {
             $fullSystem .= '.'
-                . ($system !== '*' ? $identifier : '')
+                . ($system !== '*' ? $identifierStart : '')
                 . $system
-                . ($system !== '*' ? $identifier : '');
+                . ($system !== '*' ? $identifierEnd : '');
         }
 
         return \ltrim($fullSystem, '.');

DataStorage/Database/Query/Grammar/MysqlGrammar.php

@@ -32,7 +32,15 @@ class MysqlGrammar extends Grammar
      * @var string
      * @since 1.0.0
      */
-    protected string $systemIdentifier = '`';
+    protected string $systemIdentifierStart = '`';
+
+    /**
+     * System identifier.
+     *
+     * @var string
+     * @since 1.0.0
+     */
+    protected string $systemIdentifierEnd = '`';
 
     /**
      * Compile random.

DataStorage/Database/Query/Grammar/SQLiteGrammar.php

@@ -32,7 +32,15 @@ class SQLiteGrammar extends Grammar
      * @var string
      * @since 1.0.0
      */
-    public string $systemIdentifier = '`';
+    public string $systemIdentifierStart = '`';
+
+    /**
+     * System identifier.
+     *
+     * @var string
+     * @since 1.0.0
+     */
+    protected string $systemIdentifierEnd = '`';
 
     /**
      * Compile random.

DataStorage/Database/Query/Grammar/SqlServerGrammar.php

@@ -26,6 +26,22 @@ use phpOMS\DataStorage\Database\Query\Builder;
  */
 class SqlServerGrammar extends Grammar
 {
+    /**
+     * System identifier.
+     *
+     * @var string
+     * @since 1.0.0
+     */
+    protected string $systemIdentifierStart = '[';
+
+    /**
+     * System identifier.
+     *
+     * @var string
+     * @since 1.0.0
+     */
+    protected string $systemIdentifierEnd = ']';
+
     /**
      * Compile random.
      *

DataStorage/Database/Schema/Grammar/MysqlGrammar.php

@@ -37,7 +37,15 @@ class MysqlGrammar extends Grammar
      * @var string
      * @since 1.0.0
      */
-    protected string $systemIdentifier = '`';
+    protected string $systemIdentifierStart = '`';
+
+    /**
+     * System identifier.
+     *
+     * @var string
+     * @since 1.0.0
+     */
+    protected string $systemIdentifierEnd = '`';
 
     /**
      * Compile remove

DataStorage/Database/Schema/Grammar/SQLiteGrammar.php

@@ -30,5 +30,13 @@ class SQLiteGrammar extends Grammar
      * @var string
      * @since 1.0.0
      */
-    protected string $systemIdentifier = '`';
+    protected string $systemIdentifierStart = '`';
+
+    /**
+     * System identifier.
+     *
+     * @var string
+     * @since 1.0.0
+     */
+    protected string $systemIdentifierEnd = '`';
 }

DataStorage/Database/Schema/Grammar/SqlServerGrammar.php

@@ -24,4 +24,19 @@ namespace phpOMS\DataStorage\Database\Schema\Grammar;
  */
 class SqlServerGrammar extends Grammar
 {
+    /**
+     * System identifier.
+     *
+     * @var string
+     * @since 1.0.0
+     */
+    protected string $systemIdentifierStart = '[';
+
+    /**
+     * System identifier.
+     *
+     * @var string
+     * @since 1.0.0
+     */
+    protected string $systemIdentifierEnd = ']';
 }

tests/DataStorage/Database/Query/Grammar/MysqlGrammarTest.php

@@ -31,6 +31,7 @@ class MysqlGrammarTest extends \PHPUnit\Framework\TestCase
     public function testDefault() : void
     {
         self::assertInstanceOf('\phpOMS\DataStorage\Database\Query\Grammar\Grammar', new MysqlGrammar());
-        self::assertEquals('`', TestUtils::getMember(new MysqlGrammar(), 'systemIdentifier'));
+        self::assertEquals('`', TestUtils::getMember(new MysqlGrammar(), 'systemIdentifierStart'));
+        self::assertEquals('`', TestUtils::getMember(new MysqlGrammar(), 'systemIdentifierEnd'));
     }
 }

tests/DataStorage/Database/Query/Grammar/SQLiteGrammarTest.php

@@ -31,6 +31,7 @@ class SQLiteGrammarTest extends \PHPUnit\Framework\TestCase
     public function testDefault() : void
     {
         self::assertInstanceOf('\phpOMS\DataStorage\Database\Query\Grammar\Grammar', new SqliteGrammar());
-        self::assertEquals('`', TestUtils::getMember(new SqliteGrammar(), 'systemIdentifier'));
+        self::assertEquals('`', TestUtils::getMember(new SqliteGrammar(), 'systemIdentifierStart'));
+        self::assertEquals('`', TestUtils::getMember(new SqliteGrammar(), 'systemIdentifierEnd'));
     }
 }

tests/DataStorage/Database/Schema/Grammar/MysqlGrammarTest.php

@@ -42,7 +42,8 @@ class MysqlGrammarTest extends \PHPUnit\Framework\TestCase
     public function testDefault() : void
     {
         self::assertInstanceOf('\phpOMS\DataStorage\Database\Schema\Grammar\Grammar', new MysqlGrammar());
-        self::assertEquals('`', TestUtils::getMember(new MysqlGrammar(), 'systemIdentifier'));
+        self::assertEquals('`', TestUtils::getMember(new MysqlGrammar(), 'systemIdentifierStart'));
+        self::assertEquals('`', TestUtils::getMember(new MysqlGrammar(), 'systemIdentifierEnd'));
     }
 
     /**

tests/DataStorage/Database/Schema/Grammar/SQLiteGrammarTest.php

@@ -30,6 +30,7 @@ class SQLiteGrammarTest extends \PHPUnit\Framework\TestCase
     public function testDefault() : void
     {
         self::assertInstanceOf('\phpOMS\DataStorage\Database\Schema\Grammar\Grammar', new SQLiteGrammar());
-        self::assertEquals('`', TestUtils::getMember(new SQLiteGrammar(), 'systemIdentifier'));
+        self::assertEquals('`', TestUtils::getMember(new SQLiteGrammar(), 'systemIdentifierStart'));
+        self::assertEquals('`', TestUtils::getMember(new SQLiteGrammar(), 'systemIdentifierEnd'));
     }
 }