From 35b45cbb5bdecfdb5d9cb73c553b2a37a5da436b Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Wed, 14 Mar 2018 09:50:58 +0100 Subject: [PATCH 1/3] Remove nullable for default null para --- Account/Account.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Account/Account.php b/Account/Account.php index 4c106ac61..0e6b88f38 100644 --- a/Account/Account.php +++ b/Account/Account.php @@ -318,7 +318,7 @@ class Account implements ArrayableInterface, \JsonSerializable * * @since 1.0.0 */ - public function hasPermission(int $permission, ?int $unit = null, ?string $app = null, ?string $module = null, ?int $type = null, ?int $element = null, ?int $component = null) : bool + public function hasPermission(int $permission, int $unit = null, string $app = null, string $module = null, int $type = null, int $element = null, int $component = null) : bool { $app = $app !== null ? strtolower($app) : $app; From 1bc4593654a2ac9d7ab6fe1e542f0f69dabb619e Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Wed, 14 Mar 2018 09:57:41 +0100 Subject: [PATCH 2/3] Remove empty construct --- Business/Marketing/NetPromoterScore.php | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/Business/Marketing/NetPromoterScore.php b/Business/Marketing/NetPromoterScore.php index ec589cc8b..6cdf180b3 100644 --- a/Business/Marketing/NetPromoterScore.php +++ b/Business/Marketing/NetPromoterScore.php @@ -35,16 +35,6 @@ class NetPromoterScore */ private $scores = []; - /** - * Constructor. - * - * @since 1.0.0 - */ - public function __construct() - { - - } - /** * Add score. * From d3258357e0695adaca36b6d5497e1c3324728fbb Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Wed, 14 Mar 2018 10:00:04 +0100 Subject: [PATCH 3/3] Fix return type docblock --- Log/LoggerInterface.php | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/Log/LoggerInterface.php b/Log/LoggerInterface.php index 07e0c4933..5630c4a5f 100644 --- a/Log/LoggerInterface.php +++ b/Log/LoggerInterface.php @@ -31,7 +31,7 @@ interface LoggerInterface * @param string $message Logging message schema * @param array $context Context to log * - * @return null + * @return void */ public function emergency(string $message, array $context = []); /* : void */ @@ -44,7 +44,7 @@ interface LoggerInterface * @param string $message Logging message schema * @param array $context Context to log * - * @return null + * @return void */ public function alert(string $message, array $context = []); /* : void */ @@ -56,7 +56,7 @@ interface LoggerInterface * @param string $message Logging message schema * @param array $context Context to log * - * @return null + * @return void */ public function critical(string $message, array $context = []); /* : void */ @@ -67,7 +67,7 @@ interface LoggerInterface * @param string $message Logging message schema * @param array $context Context to log * - * @return null + * @return void */ public function error(string $message, array $context = []); /* : void */ @@ -80,7 +80,7 @@ interface LoggerInterface * @param string $message Logging message schema * @param array $context Context to log * - * @return null + * @return void */ public function warning(string $message, array $context = []); /* : void */ @@ -90,7 +90,7 @@ interface LoggerInterface * @param string $message Logging message schema * @param array $context Context to log * - * @return null + * @return void */ public function notice(string $message, array $context = []); /* : void */ @@ -102,7 +102,7 @@ interface LoggerInterface * @param string $message Logging message schema * @param array $context Context to log * - * @return null + * @return void */ public function info(string $message, array $context = []); /* : void */ @@ -112,7 +112,7 @@ interface LoggerInterface * @param string $message Logging message schema * @param array $context Context to log * - * @return null + * @return void */ public function debug(string $message, array $context = []); /* : void */ @@ -123,7 +123,7 @@ interface LoggerInterface * @param string $message Logging message schema * @param array $context Context to log * - * @return null + * @return void */ public function log(string $level, string $message, array $context = []); /* : void */ }