Jingga/phpOMS
1
0
Fork 0
mirror of https://github.com/Karaka-Management/phpOMS.git synced 2026-02-05 12:08:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

add todo and fix docblock

Browse Source
This commit is contained in:
Dennis Eichhorn 2020-02-04 19:50:41 +01:00
parent 00d9b3eb47
commit 47cd969f10
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
DataStorage/Database/DataMapperAbstract.php
View File

@ -131,6 +131,18 @@ use Throwable;
* Instead of using int the NullModel should be used which has a constructor that allows to define the int. * Instead of using int the NullModel should be used which has a constructor that allows to define the int.
* As a result the datamapper has to be rewritten for the select and insert/update. * As a result the datamapper has to be rewritten for the select and insert/update.
* The select needs to set the null model as value and the insert/update needs to extract the id from the null and ignore all other empty values from the null model which obviously are the default values. * The select needs to set the null model as value and the insert/update needs to extract the id from the null and ignore all other empty values from the null model which obviously are the default values.
*
* @todo Orange-Management/phpOMS#235
* The relationship keywords `dst` and `src` are difficult to understand and should be renamed.
* E.g. `self` and `ext`
*
* @todo Orange-Management/phpOMS#236
* Consider unifing hasMany and ownsOwn
* Maybe unify these relations and handle them based on their definition of src and dst.
* 1. `src` and `dst` are defined = relation is defined in relation table
* 2. `dst` is defined = relation is defined in own table
* 3. `src` is defined = relation is defined in external table
* Disclaimer: I may have mixed up the meaning of dst and src (the names are bad)
*/ */
class DataMapperAbstract implements DataMapperInterface class DataMapperAbstract implements DataMapperInterface
{ {
@ -211,13 +223,6 @@ class DataMapperAbstract implements DataMapperInterface
protected static array $ownsOne = []; protected static array $ownsOne = [];
/** /**
* Relations.
*
* Relation is defined in current mapper
*
* @var string[]
* @since 1.0.0
*/ /**
* Belongs to. * Belongs to.
* *
* @var array<string, array<string, string>> * @var array<string, array<string, string>>