From e8cbf89dd312a35f710c93fa2d2c01b7b53065f3 Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nes.com@googlemail.com>
Date: Tue, 5 Apr 2022 20:04:48 +0200
Subject: [PATCH] static code analysis fixes

---
 Controller/ApiController.php | 8 ++++----
 composer.json                | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/Controller/ApiController.php b/Controller/ApiController.php
index bd034f0..393c0d3 100644
--- a/Controller/ApiController.php
+++ b/Controller/ApiController.php
@@ -370,7 +370,7 @@ final class ApiController extends Controller
      */
     public function apiWorkflowTemplateCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
     {
-        $uploadedFiles = $request->getFiles() ?? [];
+        $uploadedFiles = $request->getFiles();
         $files         = [];
 
         if (!empty($val = $this->validateTemplateCreate($request))) {
@@ -389,8 +389,8 @@ final class ApiController extends Controller
 
         /** @var \Modules\Media\Models\Media[] $uploaded */
         $uploaded = $this->app->moduleManager->get('Media')->uploadFiles(
-            $request->getDataList('names') ?? [],
-            $request->getDataList('filenames') ?? [],
+            $request->getDataList('names'),
+            $request->getDataList('filenames'),
             $uploadedFiles,
             $request->header->account,
             __DIR__ . '/../../../Modules/Media/Files'
@@ -477,7 +477,7 @@ final class ApiController extends Controller
     {
         $val = [];
         if (($val['name'] = empty($request->getData('name')))
-            || ($val['files'] = empty($request->getFiles() ?? []))
+            || ($val['files'] = empty($request->getFiles()))
         ) {
             return $val;
         }
diff --git a/composer.json b/composer.json
index b90cb5e..10044a1 100755
--- a/composer.json
+++ b/composer.json
@@ -12,7 +12,7 @@
         "friendsofphp/php-cs-fixer": ">=3.2",
         "squizlabs/php_codesniffer": ">=3.6",
         "phpmd/phpmd": ">=2.9",
-        "phpstan/phpstan": ">=0.12.58",
+        "phpstan/phpstan": ">=1.5.4",
         "phan/phan": ">=3.2.6"
     },
     "minimum-stability": "dev",