Jingga/oms-Workflow
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Workflow.git synced 2026-02-13 04:38:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix phpstan lvl 9 bugs

Browse Source
This commit is contained in:
Dennis Eichhorn 2022-12-26 20:52:58 +01:00
parent a6aed611d7
commit 963ba58d7c
2 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
Controller/ApiController.php
View File

@ -81,13 +81,14 @@ final class ApiController extends Controller
continue; continue;
} }
$hooks = \json_decode($hooksContent); $hooks = \json_decode($hooksContent, true);
if ($hooks === false || $hooks === null) { if ($hooks === false || $hooks === null) {
continue; continue;
} }
/** @var array $hooks */
foreach ($hooks as $hook) { foreach ($hooks as $hook) {
/** @var array{':triggerGroup'?:string} $data */ /** @var array{'@triggerGroup'?:string} $data */
$triggerIsRegex = \stripos($data['@triggerGroup'], '/') === 0; $triggerIsRegex = \stripos($data['@triggerGroup'], '/') === 0;
$matched = false; $matched = false;
@ -220,6 +221,9 @@ final class ApiController extends Controller
*/ */
private function setWorkflowResponseHeader(View $view, string $name, RequestAbstract $request, ResponseAbstract $response) : void private function setWorkflowResponseHeader(View $view, string $name, RequestAbstract $request, ResponseAbstract $response) : void
{ {
/** @var array{lang?:\Modules\Media\Models\Media, cfg?:\Modules\Media\Models\Media, excel?:\Modules\Media\Models\Media, word?:\Modules\Media\Models\Media, powerpoint?:\Modules\Media\Models\Media, pdf?:\Modules\Media\Models\Media, csv?:\Modules\Media\Models\Media, json?:\Modules\Media\Models\Media, template?:\Modules\Media\Models\Media, css?:array<string, \Modules\Media\Models\Media>, js?:array<string, \Modules\Media\Models\Media>, db?:array<string, \Modules\Media\Models\Media>, other?:array<string, \Modules\Media\Models\Media>} $tcoll */
$tcoll = $view->getData('tcoll') ?? [];
switch ($request->getData('type')) { switch ($request->getData('type')) {
case 'pdf': case 'pdf':
$response->header->set( $response->header->set(
@ -229,7 +233,7 @@ final class ApiController extends Controller
. '"' . '"'
, true); , true);
$response->header->set('Content-Type', MimeType::M_PDF, true); $response->header->set('Content-Type', MimeType::M_PDF, true);
$view->setTemplate('/' . \substr($view->getData('tcoll')['pdf']?->getPath(), 0, -8), 'pdf.php'); $view->setTemplate('/' . \substr($tcoll['pdf']->getPath(), 0, -8), 'pdf.php');
break; break;
case 'csv': case 'csv':
$response->header->set( $response->header->set(
@ -239,7 +243,7 @@ final class ApiController extends Controller
. '"' . '"'
, true); , true);
$response->header->set('Content-Type', MimeType::M_CONF, true); $response->header->set('Content-Type', MimeType::M_CONF, true);
$view->setTemplate('/' . \substr($view->getData('tcoll')['csv']?->getPath(), 0, -8), 'csv.php'); $view->setTemplate('/' . \substr($tcoll['csv']->getPath(), 0, -8), 'csv.php');
break; break;
case 'xls': case 'xls':
case 'xlsx': case 'xlsx':
@ -250,7 +254,7 @@ final class ApiController extends Controller
. '"' . '"'
, true); , true);
$response->header->set('Content-Type', MimeType::M_XLSX, true); $response->header->set('Content-Type', MimeType::M_XLSX, true);
$view->setTemplate('/' . \substr($view->getData('tcoll')['excel']?->getPath(), 0, -8), 'xls.php'); $view->setTemplate('/' . \substr($tcoll['excel']->getPath(), 0, -8), 'xls.php');
break; break;
case 'doc': case 'doc':
case 'docx': case 'docx':
@ -261,7 +265,7 @@ final class ApiController extends Controller
. '"' . '"'
, true); , true);
$response->header->set('Content-Type', MimeType::M_XLSX, true); $response->header->set('Content-Type', MimeType::M_XLSX, true);
$view->setTemplate('/' . \substr($view->getData('tcoll')['word']?->getPath(), 0, -8), 'doc.php'); $view->setTemplate('/' . \substr($tcoll['word']->getPath(), 0, -8), 'doc.php');
break; break;
case 'ppt': case 'ppt':
case 'pptx': case 'pptx':
@ -272,15 +276,15 @@ final class ApiController extends Controller
. '"' . '"'
, true); , true);
$response->header->set('Content-Type', MimeType::M_XLSX, true); $response->header->set('Content-Type', MimeType::M_XLSX, true);
$view->setTemplate('/' . \substr($view->getData('tcoll')['powerpoint']?->getPath(), 0, -8), 'ppt.php'); $view->setTemplate('/' . \substr($tcoll['powerpoint']->getPath(), 0, -8), 'ppt.php');
break; break;
case 'json': case 'json':
$response->header->set('Content-Type', MimeType::M_JSON, true); $response->header->set('Content-Type', MimeType::M_JSON, true);
$view->setTemplate('/' . \substr($view->getData('tcoll')['json']?->getPath(), 0, -9), 'json.php'); $view->setTemplate('/' . \substr($tcoll['json']->getPath(), 0, -9), 'json.php');
break; break;
default: default:
$response->header->set('Content-Type', 'text/html; charset=utf-8'); $response->header->set('Content-Type', 'text/html; charset=utf-8');
$view->setTemplate('/' . \substr($view->getData('tcoll')['template']?->getPath(), 0, -8)); $view->setTemplate('/' . \substr($tcoll['template']->getPath(), 0, -8));
} }
} }
@ -518,7 +522,7 @@ final class ApiController extends Controller
private function createTemplateFromRequest(RequestAbstract $request, int $collectionId) : WorkflowTemplate private function createTemplateFromRequest(RequestAbstract $request, int $collectionId) : WorkflowTemplate
{ {
$workflowTemplate = new WorkflowTemplate(); $workflowTemplate = new WorkflowTemplate();
$workflowTemplate->name = $request->getData('name') ?? ''; $workflowTemplate->name = (string) ($request->getData('name') ?? '');
$workflowTemplate->description = Markdown::parse((string) ($request->getData('description') ?? '')); $workflowTemplate->description = Markdown::parse((string) ($request->getData('description') ?? ''));
$workflowTemplate->descriptionRaw = (string) ($request->getData('description') ?? ''); $workflowTemplate->descriptionRaw = (string) ($request->getData('description') ?? '');
@ -568,6 +572,7 @@ final class ApiController extends Controller
return; // @codeCoverageIgnore return; // @codeCoverageIgnore
} }
/** @var array $definitions */
foreach ($definitions as $definition) { foreach ($definitions as $definition) {
SchemaBuilder::createFromSchema($definition, $this->app->dbPool->get('schema'))->execute(); SchemaBuilder::createFromSchema($definition, $this->app->dbPool->get('schema'))->execute();
} }

1
Controller/BackendController.php
View File

@ -90,6 +90,7 @@ final class BackendController extends Controller
$view = new View($this->app->l11nManager, $request, $response); $view = new View($this->app->l11nManager, $request, $response);
$view->addData('nav', $this->app->moduleManager->get('Navigation')->createNavigationMid(1005501001, $request, $response)); $view->addData('nav', $this->app->moduleManager->get('Navigation')->createNavigationMid(1005501001, $request, $response));
/** @var \Modules\Workflow\Models\WorkflowTemplate $template */
$template = WorkflowTemplateMapper::get() $template = WorkflowTemplateMapper::get()
->with('source') ->with('source')
->with('source/sources') ->with('source/sources')