Jingga/oms-Workflow
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Workflow.git synced 2026-01-11 14:58:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix billing process

Browse Source
This commit is contained in:
Dennis Eichhorn 2023-04-08 04:36:26 +02:00
parent a888c6bc76
commit 2831616258
3 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
.github/user_bug_report.md vendored
View File

@ -8,9 +8,11 @@ assignees: ''
--- ---
# Bug Description # Bug Description
A clear and concise description of what the bug is. A clear and concise description of what the bug is.
# How to Reproduce # How to Reproduce
Steps to reproduce the behavior: Steps to reproduce the behavior:
1. Go to '...' 1. Go to '...'
@ -19,16 +21,20 @@ Steps to reproduce the behavior:
4. See error 4. See error
# Expected Behavior # Expected Behavior
A clear and concise description of what you expected to happen. A clear and concise description of what you expected to happen.
# Screenshots # Screenshots
If applicable, add screenshots to help explain your problem. If applicable, add screenshots to help explain your problem.
# System Information # System Information
- System: [e.g. PC or iPhone11, ...]
- OS: [e.g. iOS] - System: [e.g. PC or iPhone11, ...]
- Browser [e.g. chrome, safari] - OS: [e.g. iOS]
- KarakaVersion [e.g. 22] - Browser [e.g. chrome, safari]
- KarakaVersion [e.g. 22]
# Additional Information # Additional Information
Add any other context about the problem here. Add any other context about the problem here.

8
Controller/ApiController.php
View File

@ -166,7 +166,7 @@ final class ApiController extends Controller
PermissionType::READ, $this->app->unitId, null, self::NAME, PermissionCategory::INSTANCE, $instance->getId() PermissionType::READ, $this->app->unitId, null, self::NAME, PermissionCategory::INSTANCE, $instance->getId()
) )
|| ($isExport && !$this->app->accountManager->get($accountId)->hasPermission( || ($isExport && !$this->app->accountManager->get($accountId)->hasPermission(
PermissionType::READ, $this->app->unitId, $this->app->appName, self::NAME, PermissionCategory::EXPORT PermissionType::READ, $this->app->unitId, $this->app->appId, self::NAME, PermissionCategory::EXPORT
)) ))
) { ) {
$response->header->status = RequestStatusCode::R_403; $response->header->status = RequestStatusCode::R_403;
@ -198,7 +198,7 @@ final class ApiController extends Controller
private function validateExport(RequestAbstract $request) : array private function validateExport(RequestAbstract $request) : array
{ {
$val = []; $val = [];
if (($val['id'] = empty($request->getData('id')))) { if (($val['id'] = !$request->hasData('id'))) {
return $val; return $val;
} }
@ -531,7 +531,7 @@ final class ApiController extends Controller
private function validateTemplateCreate(RequestAbstract $request) : array private function validateTemplateCreate(RequestAbstract $request) : array
{ {
$val = []; $val = [];
if (($val['name'] = empty($request->getData('name')))) { if (($val['name'] = !$request->hasData('name'))) {
return $val; return $val;
} }
@ -661,7 +661,7 @@ final class ApiController extends Controller
private function validateInstanceCreate(RequestAbstract $request) : array private function validateInstanceCreate(RequestAbstract $request) : array
{ {
$val = []; $val = [];
if (($val['template'] = empty($request->getData('template')))) { if (($val['template'] = !$request->hasData('template'))) {
return $val; return $val;
} }

2
Controller/CliController.php
View File

@ -134,7 +134,7 @@ final class CliController extends Controller
private function validateInstanceCreate(RequestAbstract $request) : array private function validateInstanceCreate(RequestAbstract $request) : array
{ {
$val = []; $val = [];
if (($val['j'] = empty($request->getData('j')))) { if (($val['j'] = !$request->hasData('j'))) {
return $val; return $val;
} }