From df3e039ab21dc9dee0c2cd88dbed57c4884e38d4 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Mon, 16 Oct 2023 22:25:58 +0000 Subject: [PATCH 01/15] auto generate NullTests --- tests/Models/NullStockLocationTest.php | 52 ++++++++++++++++++++++++++ tests/Models/NullStockShelfTest.php | 52 ++++++++++++++++++++++++++ tests/Models/NullStockTest.php | 52 ++++++++++++++++++++++++++ 3 files changed, 156 insertions(+) create mode 100644 tests/Models/NullStockLocationTest.php create mode 100644 tests/Models/NullStockShelfTest.php create mode 100644 tests/Models/NullStockTest.php diff --git a/tests/Models/NullStockLocationTest.php b/tests/Models/NullStockLocationTest.php new file mode 100644 index 0000000..1ea4903 --- /dev/null +++ b/tests/Models/NullStockLocationTest.php @@ -0,0 +1,52 @@ +getId()); + } + + /** + * @covers Modules\WarehouseManagement\Models\NullStockLocation + * @group framework + */ + public function testJsonSerialize() : void + { + $null = new NullStockLocation(2); + self::assertEquals(['id' => 2], $null); + } +} diff --git a/tests/Models/NullStockShelfTest.php b/tests/Models/NullStockShelfTest.php new file mode 100644 index 0000000..ad149d8 --- /dev/null +++ b/tests/Models/NullStockShelfTest.php @@ -0,0 +1,52 @@ +getId()); + } + + /** + * @covers Modules\WarehouseManagement\Models\NullStockShelf + * @group framework + */ + public function testJsonSerialize() : void + { + $null = new NullStockShelf(2); + self::assertEquals(['id' => 2], $null); + } +} diff --git a/tests/Models/NullStockTest.php b/tests/Models/NullStockTest.php new file mode 100644 index 0000000..5b21c60 --- /dev/null +++ b/tests/Models/NullStockTest.php @@ -0,0 +1,52 @@ +getId()); + } + + /** + * @covers Modules\WarehouseManagement\Models\NullStock + * @group framework + */ + public function testJsonSerialize() : void + { + $null = new NullStock(2); + self::assertEquals(['id' => 2], $null); + } +} From 90a0cd5fd0ea08b8cae3f2cd1199531bdbf91423 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Mon, 16 Oct 2023 23:39:39 +0000 Subject: [PATCH 02/15] Add test cases for null models --- tests/Models/NullStockLocationTest.php | 6 +++--- tests/Models/NullStockShelfTest.php | 6 +++--- tests/Models/NullStockTest.php | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/Models/NullStockLocationTest.php b/tests/Models/NullStockLocationTest.php index 1ea4903..9d76f0f 100644 --- a/tests/Models/NullStockLocationTest.php +++ b/tests/Models/NullStockLocationTest.php @@ -23,7 +23,7 @@ final class NullStockLocationTest extends \PHPUnit\Framework\TestCase { /** * @covers Modules\WarehouseManagement\Models\NullStockLocation - * @group framework + * @group module */ public function testNull() : void { @@ -32,7 +32,7 @@ final class NullStockLocationTest extends \PHPUnit\Framework\TestCase /** * @covers Modules\WarehouseManagement\Models\NullStockLocation - * @group framework + * @group module */ public function testId() : void { @@ -42,7 +42,7 @@ final class NullStockLocationTest extends \PHPUnit\Framework\TestCase /** * @covers Modules\WarehouseManagement\Models\NullStockLocation - * @group framework + * @group module */ public function testJsonSerialize() : void { diff --git a/tests/Models/NullStockShelfTest.php b/tests/Models/NullStockShelfTest.php index ad149d8..f78e186 100644 --- a/tests/Models/NullStockShelfTest.php +++ b/tests/Models/NullStockShelfTest.php @@ -23,7 +23,7 @@ final class NullStockShelfTest extends \PHPUnit\Framework\TestCase { /** * @covers Modules\WarehouseManagement\Models\NullStockShelf - * @group framework + * @group module */ public function testNull() : void { @@ -32,7 +32,7 @@ final class NullStockShelfTest extends \PHPUnit\Framework\TestCase /** * @covers Modules\WarehouseManagement\Models\NullStockShelf - * @group framework + * @group module */ public function testId() : void { @@ -42,7 +42,7 @@ final class NullStockShelfTest extends \PHPUnit\Framework\TestCase /** * @covers Modules\WarehouseManagement\Models\NullStockShelf - * @group framework + * @group module */ public function testJsonSerialize() : void { diff --git a/tests/Models/NullStockTest.php b/tests/Models/NullStockTest.php index 5b21c60..4f3ef20 100644 --- a/tests/Models/NullStockTest.php +++ b/tests/Models/NullStockTest.php @@ -23,7 +23,7 @@ final class NullStockTest extends \PHPUnit\Framework\TestCase { /** * @covers Modules\WarehouseManagement\Models\NullStock - * @group framework + * @group module */ public function testNull() : void { @@ -32,7 +32,7 @@ final class NullStockTest extends \PHPUnit\Framework\TestCase /** * @covers Modules\WarehouseManagement\Models\NullStock - * @group framework + * @group module */ public function testId() : void { @@ -42,7 +42,7 @@ final class NullStockTest extends \PHPUnit\Framework\TestCase /** * @covers Modules\WarehouseManagement\Models\NullStock - * @group framework + * @group module */ public function testJsonSerialize() : void { From a9bb1d5217ac995776f6608262e66e8225718b54 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Mon, 16 Oct 2023 23:44:00 +0000 Subject: [PATCH 03/15] Remove getId() function call from null models --- tests/Models/NullStockLocationTest.php | 2 +- tests/Models/NullStockShelfTest.php | 2 +- tests/Models/NullStockTest.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Models/NullStockLocationTest.php b/tests/Models/NullStockLocationTest.php index 9d76f0f..3cd3625 100644 --- a/tests/Models/NullStockLocationTest.php +++ b/tests/Models/NullStockLocationTest.php @@ -37,7 +37,7 @@ final class NullStockLocationTest extends \PHPUnit\Framework\TestCase public function testId() : void { $null = new NullStockLocation(2); - self::assertEquals(2, $null->getId()); + self::assertEquals(2, $null->id); } /** diff --git a/tests/Models/NullStockShelfTest.php b/tests/Models/NullStockShelfTest.php index f78e186..686a75c 100644 --- a/tests/Models/NullStockShelfTest.php +++ b/tests/Models/NullStockShelfTest.php @@ -37,7 +37,7 @@ final class NullStockShelfTest extends \PHPUnit\Framework\TestCase public function testId() : void { $null = new NullStockShelf(2); - self::assertEquals(2, $null->getId()); + self::assertEquals(2, $null->id); } /** diff --git a/tests/Models/NullStockTest.php b/tests/Models/NullStockTest.php index 4f3ef20..6a14091 100644 --- a/tests/Models/NullStockTest.php +++ b/tests/Models/NullStockTest.php @@ -37,7 +37,7 @@ final class NullStockTest extends \PHPUnit\Framework\TestCase public function testId() : void { $null = new NullStock(2); - self::assertEquals(2, $null->getId()); + self::assertEquals(2, $null->id); } /** From 147e1b59fa63cde12fc89f50afcb148760a15345 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Tue, 17 Oct 2023 00:13:58 +0000 Subject: [PATCH 04/15] fix jsonSerialize function call --- tests/Models/NullStockLocationTest.php | 2 +- tests/Models/NullStockShelfTest.php | 2 +- tests/Models/NullStockTest.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Models/NullStockLocationTest.php b/tests/Models/NullStockLocationTest.php index 3cd3625..cb2ca90 100644 --- a/tests/Models/NullStockLocationTest.php +++ b/tests/Models/NullStockLocationTest.php @@ -47,6 +47,6 @@ final class NullStockLocationTest extends \PHPUnit\Framework\TestCase public function testJsonSerialize() : void { $null = new NullStockLocation(2); - self::assertEquals(['id' => 2], $null); + self::assertEquals(['id' => 2], $null->jsonSerialize()); } } diff --git a/tests/Models/NullStockShelfTest.php b/tests/Models/NullStockShelfTest.php index 686a75c..19cf483 100644 --- a/tests/Models/NullStockShelfTest.php +++ b/tests/Models/NullStockShelfTest.php @@ -47,6 +47,6 @@ final class NullStockShelfTest extends \PHPUnit\Framework\TestCase public function testJsonSerialize() : void { $null = new NullStockShelf(2); - self::assertEquals(['id' => 2], $null); + self::assertEquals(['id' => 2], $null->jsonSerialize()); } } diff --git a/tests/Models/NullStockTest.php b/tests/Models/NullStockTest.php index 6a14091..17dac74 100644 --- a/tests/Models/NullStockTest.php +++ b/tests/Models/NullStockTest.php @@ -47,6 +47,6 @@ final class NullStockTest extends \PHPUnit\Framework\TestCase public function testJsonSerialize() : void { $null = new NullStock(2); - self::assertEquals(['id' => 2], $null); + self::assertEquals(['id' => 2], $null->jsonSerialize()); } } From 23a9041fc308fca0a16c16b466c67944b05c7690 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Thu, 19 Oct 2023 17:54:59 +0000 Subject: [PATCH 05/15] update readme --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index af4f138..4cb40c2 100755 --- a/README.md +++ b/README.md @@ -51,7 +51,7 @@ Currently Karaka is still developing the first Alpha version. As soon as we have General updates can be found in our info section at https://jingga.app/info and developer updates can be found in our developer section at https://jingga.app/dev. In our developer section you can also check out the automatically generated reports such as code coverage, code style, static analysis etc. as well as our code style guide lines and developer documentation. -* [Project Status](https://github.com/Karaka-Management/Organization-Guide/blob/master/Project/PROJECT.md) +* [Project Status](https://github.com/orgs/Karaka-Management/projects/10) ## Tech stack @@ -62,7 +62,7 @@ General updates can be found in our info section at https://jingga.app/info and ## Become a contributor -Karaka has a very open culture and we always welcome new people who share our philosophy in providing create solutions which just work. You can find the development process description which also describes how to become a contributer in the [Organization documentation](https://github.com/Karaka-Management/Organization-Guide/blob/master/Processes/Development.md). +Karaka has a very open culture and we always welcome new people who share our philosophy in providing create solutions which just work. You can find the development process description which also describes how to become a contributer in the [Organization documentation](https://github.com/Karaka-Management/Organization-Guide/blob/master/Processes/01_Development.md). ## Misc From 82e4ca10245d854e076b8e4c0d0e60a84c16f877 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Thu, 19 Oct 2023 21:44:09 +0000 Subject: [PATCH 06/15] change icon font to google icons --- Admin/Install/Navigation.install.json | 2 +- Theme/Backend/stock-list.tpl.php | 2 +- Theme/Backend/stock-location-list.tpl.php | 2 +- Theme/Backend/stock-type-list.tpl.php | 2 +- Theme/Backend/stock-type-profile.tpl.php | 16 ++++++++-------- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/Admin/Install/Navigation.install.json b/Admin/Install/Navigation.install.json index 5d9fa7a..13239fa 100755 --- a/Admin/Install/Navigation.install.json +++ b/Admin/Install/Navigation.install.json @@ -7,7 +7,7 @@ "name": "Warehousing", "uri": null, "target": "self", - "icon": "fa fa-cube", + "icon": "deployed_code", "order": 50, "from": "WarehouseManagement", "permission": { "permission": 2, "category": null, "element": null }, diff --git a/Theme/Backend/stock-list.tpl.php b/Theme/Backend/stock-list.tpl.php index efdd558..1582bbd 100755 --- a/Theme/Backend/stock-list.tpl.php +++ b/Theme/Backend/stock-list.tpl.php @@ -21,7 +21,7 @@ echo $this->data['nav']->render(); ?>
-
getHtml('Stocks'); ?>
+
getHtml('Stocks'); ?>download
diff --git a/Theme/Backend/stock-location-list.tpl.php b/Theme/Backend/stock-location-list.tpl.php index f5907fd..6ef94e8 100755 --- a/Theme/Backend/stock-location-list.tpl.php +++ b/Theme/Backend/stock-location-list.tpl.php @@ -21,7 +21,7 @@ echo $this->data['nav']->render(); ?>
-
getHtml('Locations'); ?>
+
getHtml('Locations'); ?>download
diff --git a/Theme/Backend/stock-type-list.tpl.php b/Theme/Backend/stock-type-list.tpl.php index 5627633..96bc843 100644 --- a/Theme/Backend/stock-type-list.tpl.php +++ b/Theme/Backend/stock-type-list.tpl.php @@ -21,7 +21,7 @@ echo $this->data['nav']->render(); ?>
-
getHtml('Stocks'); ?>
+
getHtml('Stocks'); ?>download
diff --git a/Theme/Backend/stock-type-profile.tpl.php b/Theme/Backend/stock-type-profile.tpl.php index f684710..e90cd64 100644 --- a/Theme/Backend/stock-type-profile.tpl.php +++ b/Theme/Backend/stock-type-profile.tpl.php @@ -31,7 +31,7 @@ echo $this->data['nav']->render();
-
getHtml('Localizations'); ?>
+
getHtml('Localizations'); ?>download
data['nav']->render();
getHtml('ID', '0', '0'); ?> - getHtml('Name'); ?> - getHtml('Language'); ?> - getHtml('Localization'); ?> + getHtml('Name'); ?>expand_lessexpand_more + getHtml('Language'); ?>expand_lessexpand_more + getHtml('Localization'); ?>expand_lessexpand_more