bug fixes

.github/workflows/greetings.yml

@@ -9,5 +9,5 @@ jobs:
     - uses: actions/first-interaction@v1
       with:
         repo-token: ${{ secrets.GITHUB_TOKEN }}
-        issue-message: 'Thank you for createing this issue. We will check it as soon as possible.'
+        issue-message: 'Thank you for creating this issue. We will check it as soon as possible.'
         pr-message: 'Thank you for your pull request. We will check it as soon as possible.'

Admin/Installer.php

@@ -46,8 +46,6 @@ final class Installer extends InstallerAbstract
     {
         parent::install($app, $info, $cfgHandler);
 
-        self::createDefaultStock($app);
-
         /* Stock types */
         $fileContent = \file_get_contents(__DIR__ . '/Install/types.json');
         if ($fileContent === false) {
@@ -61,6 +59,8 @@ final class Installer extends InstallerAbstract
         }
 
         self::createStockTypes($app, $types);
+
+        self::createDefaultStock($app);
     }
 
     /**

Controller/ApiController.php

@@ -188,7 +188,8 @@ final class ApiController extends Controller
         $location->name  = $request->getDataString('name') ?? '';
         $location->stock = new NullStock($request->getDataInt('stock') ?? 1);
 
-        $location->type = $request->hasData('type') ? new NullStockType((int) $request->getDataInt('type')) : null;
+        // @todo Define default type instead of just 1
+        $location->type = new NullStockType($request->getDataInt('type') ?? 1);
 
         return $location;
     }

Theme/Backend/Lang/de.lang.php

@@ -21,4 +21,6 @@ return ['WarehouseManagement' => [
     'Shelf'     => 'Fach',
     'Type'      => 'Typ',
     'Location'  => 'Lagerplatz',
+    'Quantity'  => 'Menge',
+    'All'  => 'Alle',
 ]];

Theme/Backend/Lang/en.lang.php

@@ -21,4 +21,6 @@ return ['WarehouseManagement' => [
     'Shelf'     => 'Shelf',
     'Type'      => 'Type',
     'Location'  => 'Location',
+    'Quantity'  => 'Quantity',
+    'All'  => 'All',
 ]];

Theme/Backend/stock-list.tpl.php

@@ -20,7 +20,7 @@ echo $this->data['nav']->render(); ?>
 
 <div class="row">
     <div class="col-xs-12">
-        <div class="portlet">
+        <section class="portlet">
             <div class="portlet-head">
                 <?= $this->getHtml('Stocks'); ?>
                 <i class="g-icon download btn end-xs">download</i>
@@ -46,6 +46,6 @@ echo $this->data['nav']->render(); ?>
                 <?php endif; ?>
             </table>
             </div>
-        </div>
+        </section>
     </div>
 </div>

Theme/Backend/stock-location-list.tpl.php

@@ -20,7 +20,7 @@ echo $this->data['nav']->render(); ?>
 
 <div class="row">
     <div class="col-xs-12">
-        <div class="portlet">
+        <section class="portlet">
             <div class="portlet-head"><?= $this->getHtml('Locations'); ?><i class="g-icon download btn end-xs">download</i></div>
             <div class="slider">
             <table id="stockList" class="default sticky">
@@ -46,6 +46,6 @@ echo $this->data['nav']->render(); ?>
                 <?php endif; ?>
             </table>
             </div>
-        </div>
+        </section>
     </div>
 </div>

Theme/Backend/stock-type-list.tpl.php

@@ -20,7 +20,7 @@ echo $this->data['nav']->render(); ?>
 
 <div class="row">
     <div class="col-xs-12">
-        <div class="portlet">
+        <section class="portlet">
             <div class="portlet-head">
                 <?= $this->getHtml('Stocks'); ?>
                 <i class="g-icon download btn end-xs">download</i>
@@ -46,6 +46,6 @@ echo $this->data['nav']->render(); ?>
                 <?php endif; ?>
             </table>
             </div>
-        </div>
+        </section>
     </div>
 </div>