Jingga/oms-Tasks
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Tasks.git synced 2026-02-16 06:38:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

typehint fixes

Browse Source
This commit is contained in:
Dennis Eichhorn 2020-02-13 18:54:21 +01:00
parent a68a45cd23
commit fdc44f9390
3 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Controller/ApiController.php
View File

@ -119,7 +119,7 @@ final class ApiController extends Controller
$task->setDescription(Markdown::parse((string) ($request->getData('plain') ?? ''))); $task->setDescription(Markdown::parse((string) ($request->getData('plain') ?? '')));
$task->setDescriptionRaw((string) ($request->getData('plain') ?? '')); $task->setDescriptionRaw((string) ($request->getData('plain') ?? ''));
$task->setCreatedBy($request->getHeader()->getAccount()); $task->setCreatedBy($request->getHeader()->getAccount());
$task->setDue(new \DateTime((string) ($request->getData('due') ?? 'now'))); $task->setDue(new \DateTime($request->getData('due')));
$task->setStatus(TaskStatus::OPEN); $task->setStatus(TaskStatus::OPEN);
$task->setType(TaskType::SINGLE); $task->setType(TaskType::SINGLE);
$task->setPriority((int) $request->getData('priority')); $task->setPriority((int) $request->getData('priority'));

14
Models/Task.php
View File

@ -517,13 +517,13 @@ class Task implements \JsonSerializable
/** /**
* Get done date * Get done date
* *
* @return \DateTime * @return null|\DateTime
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public function getDone() : \DateTime public function getDone() : ?\DateTime
{ {
return $this->done ?? new \DateTime('now'); return $this->done;
} }
/** /**
@ -543,11 +543,11 @@ class Task implements \JsonSerializable
/** /**
* Get due date * Get due date
* *
* @return \DateTime * @return null|\DateTime
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public function getDue() : \DateTime public function getDue() : ?\DateTime
{ {
return $this->due; return $this->due;
} }
@ -555,13 +555,13 @@ class Task implements \JsonSerializable
/** /**
* Set due date * Set due date
* *
* @param \DateTime $due Due date * @param null|\DateTime $due Due date
* *
* @return void * @return void
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public function setDue(\DateTime $due) : void public function setDue(?\DateTime $due) : void
{ {
$this->due = $due; $this->due = $due;
} }

8
Models/TaskElement.php
View File

@ -263,11 +263,11 @@ class TaskElement implements \JsonSerializable
/** /**
* Get due date * Get due date
* *
* @return \DateTime * @return null|\DateTime
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public function getDue() : \DateTime public function getDue() : ?\DateTime
{ {
return $this->due; return $this->due;
} }
@ -275,13 +275,13 @@ class TaskElement implements \JsonSerializable
/** /**
* Set due date * Set due date
* *
* @param \DateTime $due Due date * @param null|\DateTime $due Due date
* *
* @return void * @return void
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public function setDue(\DateTime $due) : void public function setDue(?\DateTime $due) : void
{ {
$this->due = $due; $this->due = $due;
} }