Make classes final

This commit is contained in:
Dennis Eichhorn 2018-12-01 20:50:27 +01:00
parent c6d2d64d62
commit a9b5dfcf3e
7 changed files with 20 additions and 10 deletions

View File

@ -31,7 +31,6 @@ use phpOMS\Message\RequestAbstract;
use phpOMS\Message\ResponseAbstract;
use phpOMS\Message\NotificationLevel;
use phpOMS\Module\ModuleAbstract;
use phpOMS\Module\WebInterface;
use phpOMS\Utils\Parser\Markdown\Markdown;
use phpOMS\Views\View;
use phpOMS\Account\PermissionType;
@ -45,7 +44,7 @@ use phpOMS\DataStorage\Database\RelationType;
* @link http://website.orange-management.de
* @since 1.0.0
*/
class ApiController extends Controller
final class ApiController extends Controller
{
/**
* Validate task create request
@ -91,7 +90,10 @@ class ApiController extends Controller
$task = $this->createTaskFromRequest($request);
$this->app->eventManager->trigger('PRE:Module:Tasks-task-create', '', $task);
TaskMapper::create($task);
$this->app->eventManager->trigger('POST:Module:Tasks-task-create', '', $task);
$response->set($request->getUri()->__toString(), [
'status' => NotificationLevel::OK,
'title' => 'Task',
@ -172,8 +174,11 @@ class ApiController extends Controller
*/
public function apiTaskSet(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
{
$task = $this->updateTaskFromRequest($request);
$task = $this->updateTaskFromRequest($request);
$this->app->eventManager->trigger('PRE:Module:Tasks-task-update', '', $task);
$status = TaskMapper::update($task);
$this->app->eventManager->trigger('POST:Module:Tasks-task-update', '', $task);
$response->set($request->getUri()->__toString(), [
'status' => NotificationLevel::OK,
@ -252,8 +257,10 @@ class ApiController extends Controller
$task = TaskMapper::get($element->getTask());
$task->setStatus($element->getStatus());
$this->app->eventManager->trigger('PRE:Module:Tasks-taskelement-create', '', $element);
TaskElementMapper::create($element);
TaskMapper::update($task);
$this->app->eventManager->trigger('POST:Module:Tasks-taskelement-create', '', $element);
$response->set($request->getUri()->__toString(), [
'status' => NotificationLevel::OK,
@ -326,8 +333,11 @@ class ApiController extends Controller
*/
public function apiTaskElementSet(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
{
$task = $this->updateTaskElementFromRequest($request);
$task = $this->updateTaskElementFromRequest($request);
$this->app->eventManager->trigger('PRE:Module:Tasks-taskelement-update', '', $task);
$status = TaskElementMapper::update($task);
$this->app->eventManager->trigger('POST:Module:Tasks-taskelement-update', '', $task);
$response->set($request->getUri()->__toString(), [
'status' => NotificationLevel::OK,

View File

@ -45,7 +45,7 @@ use phpOMS\DataStorage\Database\RelationType;
* @link http://website.orange-management.de
* @since 1.0.0
*/
class BackendController extends Controller
final class BackendController extends Controller
{
/**
* @param RequestAbstract $request Request

View File

@ -25,7 +25,7 @@ use phpOMS\Stdlib\Base\Exception\InvalidEnumValue;
* @link http://website.orange-management.de
* @since 1.0.0
*/
class Task implements \JsonSerializable
final class Task implements \JsonSerializable
{
/**

View File

@ -24,7 +24,7 @@ use phpOMS\Stdlib\Base\Exception\InvalidEnumValue;
* @link http://website.orange-management.de
* @since 1.0.0
*/
class TaskElement implements \JsonSerializable
final class TaskElement implements \JsonSerializable
{
/**

View File

@ -27,7 +27,7 @@ use phpOMS\DataStorage\Database\RelationType;
* @link http://website.orange-management.de
* @since 1.0.0
*/
class TaskElementMapper extends DataMapperAbstract
final class TaskElementMapper extends DataMapperAbstract
{
/**

View File

@ -31,7 +31,7 @@ use phpOMS\DataStorage\Database\RelationType;
* @link http://website.orange-management.de
* @since 1.0.0
*/
class TaskMapper extends DataMapperAbstract
final class TaskMapper extends DataMapperAbstract
{
/**

View File

@ -22,7 +22,7 @@ namespace Modules\Tasks\Models;
* @link http://website.orange-management.de
* @since 1.0.0
*/
class TaskTemplate extends Task
final class TaskTemplate extends Task
{
/**
* Type.