Jingga/oms-Tasks
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Tasks.git synced 2026-02-13 21:28:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cs fixes, bug fixes, code coverage

Browse Source
This commit is contained in:
Dennis Eichhorn 2021-11-16 00:05:43 +01:00
parent 4093c470df
commit 9531246f09
15 changed files with 443 additions and 220 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Admin/Install/SearchCommands.php
View File

@ -19,7 +19,7 @@ use phpOMS\Router\RouteVerb;
return [ return [
'^:tag .*$' => [ '^:tag .*$' => [
[ [
'dest' => '\Modules\Tasks\Controller\SearchController:searchTags', 'dest' => '\Modules\Tasks\Controller\SearchController:searchTag',
'verb' => RouteVerb::ANY, 'verb' => RouteVerb::ANY,
'permission' => [ 'permission' => [
'module' => SearchController::NAME, 'module' => SearchController::NAME,

4
CONTRIBUTING.md
View File

@ -12,9 +12,7 @@ If you have a good idea for improvement feel free to create a new issue with all
### Issues ### Issues
Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the `Project.md` file in the `Docs` repository. Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the code marked with `@todo` or in the [PROJECT.md](https://github.com/Orange-Management/Docs/blob/master/Project/PROJECT.md) file.
The issue information can be used to provide additional information such as priority, difficulty and type. For your first issue try to find a issue marked `[d:first]` or `[d:beginner]`.
### Code Style ### Code Style

1
Controller/BackendController.php
View File

@ -86,6 +86,7 @@ final class BackendController extends Controller implements DashboardElementInte
/** /**
* {@inheritdoc} * {@inheritdoc}
* @codeCoverageIgnore
*/ */
public function viewDashboard(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface public function viewDashboard(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface
{ {

2
Controller/SearchController.php
View File

@ -41,7 +41,7 @@ final class SearchController extends Controller
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public function searchTags(RequestAbstract $request, ResponseAbstract $response, $data = null) : void public function searchTag(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
{ {
// join tags with tag l11n // join tags with tag l11n
// join tags with tasks // join tags with tasks

2
Models/RelationAbstract.php
View File

@ -49,7 +49,7 @@ abstract class RelationAbstract implements \JsonSerializable
* @var int * @var int
* @since 1.0.0 * @since 1.0.0
*/ */
protected int $element = 0; public int $element = 0;
/** /**
* Get id. * Get id.

14
Models/Task.php
View File

@ -180,7 +180,7 @@ class Task implements \JsonSerializable
* @var Schedule * @var Schedule
* @since 1.0.0 * @since 1.0.0
*/ */
protected Schedule $schedule; public Schedule $schedule;
/** /**
* Priority * Priority
@ -592,18 +592,6 @@ class Task implements \JsonSerializable
$this->type = $type; $this->type = $type;
} }
/**
* Get schedule.
*
* @return Schedule
*
* @since 1.0.0
*/
public function getSchedule() : Schedule
{
return $this->schedule;
}
/** /**
* {@inheritdoc} * {@inheritdoc}
*/ */

26
Views/TaskView.php
View File

@ -14,6 +14,8 @@ declare(strict_types=1);
namespace Modules\Tasks\Views; namespace Modules\Tasks\Views;
use Modules\Media\Models\Media;
use Modules\Media\Models\NullMedia;
use Modules\Profile\Models\ProfileMapper; use Modules\Profile\Models\ProfileMapper;
use Modules\Tasks\Models\TaskStatus; use Modules\Tasks\Models\TaskStatus;
use phpOMS\Uri\UriFactory; use phpOMS\Uri\UriFactory;
@ -29,6 +31,24 @@ use phpOMS\Views\View;
*/ */
class TaskView extends View class TaskView extends View
{ {
/**
* User profile image.
*
* @var Media
* @since 1.0.0
*/
public Media $defaultProfileImage;
/**
* Constructor
*
* @since 1.0.0
*/
public function __construct()
{
$this->defaultProfileImage = new NullMedia();
}
/** /**
* Get the profile image * Get the profile image
* *
@ -44,11 +64,11 @@ class TaskView extends View
{ {
$profile = ProfileMapper::getFor($account, 'account'); $profile = ProfileMapper::getFor($account, 'account');
if ($profile === null || $profile->image->getPath() === '') { if (($profile instanceof NullProfile) || $profile->image->getPath() === '') {
return UriFactory::build('Web/Backend/img/user_default_' . \mt_rand(1, 6) . '.png'); return UriFactory::build('{/prefix}' . $this->defaultProfileImage->getPath());
} }
return UriFactory::build($profile->image->getPath()); return UriFactory::build('{/prefix}' . $profile->image->getPath());
} }
/** /**

36
tests/ControllerTest.php → tests/Controller/ApiControllerTest.php Executable file → Normal file
View File

@ -12,7 +12,7 @@
*/ */
declare(strict_types=1); declare(strict_types=1);
namespace Modules\Task\tests; namespace Modules\Task\tests\Controller;
use Model\CoreSettings; use Model\CoreSettings;
use Modules\Admin\Models\AccountPermission; use Modules\Admin\Models\AccountPermission;
@ -28,6 +28,7 @@ use phpOMS\Message\Http\HttpRequest;
use phpOMS\Message\Http\HttpResponse; use phpOMS\Message\Http\HttpResponse;
use phpOMS\Module\ModuleManager; use phpOMS\Module\ModuleManager;
use phpOMS\Router\WebRouter; use phpOMS\Router\WebRouter;
use phpOMS\System\MimeType;
use phpOMS\Uri\HttpUri; use phpOMS\Uri\HttpUri;
use phpOMS\Utils\TestUtils; use phpOMS\Utils\TestUtils;
@ -96,6 +97,23 @@ final class ControllerTest extends \PHPUnit\Framework\TestCase
$request->setData('title', 'Controller Test Title'); $request->setData('title', 'Controller Test Title');
$request->setData('plain', 'Controller Test Description'); $request->setData('plain', 'Controller Test Description');
$request->setData('due', (new \DateTime())->format('Y-m-d H:i:s')); $request->setData('due', (new \DateTime())->format('Y-m-d H:i:s'));
$request->setData('tags', '[{"title": "TestTitle", "color": "#f0f", "language": "en"}, {"id": 1}]');
if (!\is_file(__DIR__ . '/test_tmp.md')) {
\copy(__DIR__ . '/test.md', __DIR__ . '/test_tmp.md');
}
TestUtils::setMember($request, 'files', [
'file1' => [
'name' => 'test.md',
'type' => MimeType::M_TXT,
'tmp_name' => __DIR__ . '/test_tmp.md',
'error' => \UPLOAD_ERR_OK,
'size' => \filesize(__DIR__ . '/test_tmp.md'),
],
]);
$request->setData('media', \json_encode([1]));
$this->module->apiTaskCreate($request, $response); $this->module->apiTaskCreate($request, $response);
@ -156,6 +174,22 @@ final class ControllerTest extends \PHPUnit\Framework\TestCase
$request->setData('task', 1); $request->setData('task', 1);
$request->setData('plain', 'Controller Test'); $request->setData('plain', 'Controller Test');
if (!\is_file(__DIR__ . '/test_tmp.md')) {
\copy(__DIR__ . '/test.md', __DIR__ . '/test_tmp.md');
}
TestUtils::setMember($request, 'files', [
'file1' => [
'name' => 'test.md',
'type' => MimeType::M_TXT,
'tmp_name' => __DIR__ . '/test_tmp.md',
'error' => \UPLOAD_ERR_OK,
'size' => \filesize(__DIR__ . '/test_tmp.md'),
],
]);
$request->setData('media', \json_encode([1]));
$this->module->apiTaskElementCreate($request, $response); $this->module->apiTaskElementCreate($request, $response);
self::assertEquals('Controller Test', $response->get('')['response']->descriptionRaw); self::assertEquals('Controller Test', $response->get('')['response']->descriptionRaw);

2
tests/BackendControllerTest.php → tests/Controller/BackendControllerTest.php Executable file → Normal file
View File

@ -12,7 +12,7 @@
*/ */
declare(strict_types=1); declare(strict_types=1);
namespace Modules\Task\tests; namespace Modules\Task\tests\Controller;
use Model\CoreSettings; use Model\CoreSettings;
use Modules\Admin\Models\AccountPermission; use Modules\Admin\Models\AccountPermission;

3
tests/Controller/test.md Normal file
View File

@ -0,0 +1,3 @@
# Test Title
Some **test** text.

59
tests/Models/RelationAbstractTest.php Normal file
View File

@ -0,0 +1,59 @@
<?php
/**
* Orange Management
*
* PHP Version 8.0
*
* @package tests
* @copyright Dennis Eichhorn
* @license OMS License 1.0
* @version 1.0.0
* @link https://orange-management.org
*/
declare(strict_types=1);
namespace Modules\Tasks\tests\Models;
use Modules\Tasks\Models\DutyType;
use Modules\Tasks\Models\RelationAbstract;
/**
* @internal
*/
final class RelationAbstractTest extends \PHPUnit\Framework\TestCase
{
private RelationAbstract $rel;
/**
* {@inheritdoc}
*/
protected function setUp() : void
{
$this->rel = new class() extends RelationAbstract
{
public function getRelation() { return new Modules\Admin\Models\Group(); }
public function jsonSerialize() { return []; }
};
}
/**
* @covers Modules\Tasks\Models\RelationAbstract
* @group module
*/
public function testDefault() : void
{
self::assertEquals(0, $this->rel->getId());
self::assertEquals(DutyType::TO, $this->rel->getDuty());
}
/**
* @covers Modules\Tasks\Models\RelationAbstract
* @group module
*/
public function testDutyInputOutput() : void
{
$this->rel->setDuty(DutyType::CC);
self::assertEquals(DutyType::CC, $this->rel->getDuty());
}
}

173
tests/Models/TaskElementTest.php
View File

@ -16,6 +16,7 @@ namespace Modules\Tasks\tests\Models;
use Modules\Admin\Models\NullAccount; use Modules\Admin\Models\NullAccount;
use Modules\Admin\Models\NullGroup; use Modules\Admin\Models\NullGroup;
use Modules\Media\Models\Media;
use Modules\Tasks\Models\TaskElement; use Modules\Tasks\Models\TaskElement;
use Modules\Tasks\Models\TaskPriority; use Modules\Tasks\Models\TaskPriority;
use Modules\Tasks\Models\TaskStatus; use Modules\Tasks\Models\TaskStatus;
@ -25,25 +26,33 @@ use Modules\Tasks\Models\TaskStatus;
*/ */
final class TaskElementTest extends \PHPUnit\Framework\TestCase final class TaskElementTest extends \PHPUnit\Framework\TestCase
{ {
private TaskElement $element;
/**
* {@inheritdoc}
*/
protected function setUp() : void
{
$this->element = new TaskElement();
}
/** /**
* @covers Modules\Tasks\Models\TaskElement * @covers Modules\Tasks\Models\TaskElement
* @group module * @group module
*/ */
public function testDefault() : void public function testDefault() : void
{ {
$task = new TaskElement(); self::assertEquals(0, $this->element->getId());
self::assertEquals(0, $this->element->createdBy->getId());
self::assertEquals(0, $task->getId()); self::assertEquals((new \DateTime('now'))->format('Y-m-d'), $this->element->createdAt->format('Y-m-d'));
self::assertEquals(0, $task->createdBy->getId()); self::assertEquals((new \DateTime('now'))->modify('+1 day')->format('Y-m-d'), $this->element->due->format('Y-m-d'));
self::assertEquals((new \DateTime('now'))->format('Y-m-d'), $task->createdAt->format('Y-m-d')); self::assertEquals(TaskStatus::OPEN, $this->element->getStatus());
self::assertEquals((new \DateTime('now'))->modify('+1 day')->format('Y-m-d'), $task->due->format('Y-m-d')); self::assertEquals('', $this->element->description);
self::assertEquals(TaskStatus::OPEN, $task->getStatus()); self::assertEquals('', $this->element->descriptionRaw);
self::assertEquals('', $task->description); self::assertEquals([], $this->element->getTo());
self::assertEquals('', $task->descriptionRaw); self::assertEquals([], $this->element->getCC());
self::assertEquals([], $task->getTo()); self::assertEquals(0, $this->element->task);
self::assertEquals([], $task->getCC()); self::assertEquals(TaskPriority::NONE, $this->element->getPriority());
self::assertEquals(0, $task->task);
self::assertEquals(TaskPriority::NONE, $task->getPriority());
} }
/** /**
@ -52,10 +61,8 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
*/ */
public function testCreatedByInputOutput() : void public function testCreatedByInputOutput() : void
{ {
$task = new TaskElement(); $this->element->createdBy = new NullAccount(1);
self::assertEquals(1, $this->element->createdBy->getId());
$task->createdBy = new NullAccount(1);
self::assertEquals(1, $task->createdBy->getId());
} }
/** /**
@ -64,10 +71,8 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
*/ */
public function testDueInputOutput() : void public function testDueInputOutput() : void
{ {
$task = new TaskElement(); $this->element->due = ($date = new \DateTime('2000-05-07'));
self::assertEquals($date->format('Y-m-d'), $this->element->due->format('Y-m-d'));
$task->due = ($date = new \DateTime('2000-05-07'));
self::assertEquals($date->format('Y-m-d'), $task->due->format('Y-m-d'));
} }
/** /**
@ -76,10 +81,8 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
*/ */
public function testStatusInputOutput() : void public function testStatusInputOutput() : void
{ {
$task = new TaskElement(); $this->element->setStatus(TaskStatus::DONE);
self::assertEquals(TaskStatus::DONE, $this->element->getStatus());
$task->setStatus(TaskStatus::DONE);
self::assertEquals(TaskStatus::DONE, $task->getStatus());
} }
/** /**
@ -88,10 +91,18 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
*/ */
public function testPriorityInputOutput() : void public function testPriorityInputOutput() : void
{ {
$task = new TaskElement(); $this->element->setPriority(TaskPriority::MEDIUM);
self::assertEquals(TaskPriority::MEDIUM, $this->element->getPriority());
}
$task->setPriority(TaskPriority::MEDIUM); /**
self::assertEquals(TaskPriority::MEDIUM, $task->getPriority()); * @covers Modules\Tasks\Models\TaskElement
* @group module
*/
public function testMediaInputOutput() : void
{
$this->element->addMedia(new Media());
self::assertCount(1, $this->element->getMedia());
} }
/** /**
@ -100,10 +111,8 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
*/ */
public function testDescriptionInputOutput() : void public function testDescriptionInputOutput() : void
{ {
$task = new TaskElement(); $this->element->description = 'Description';
self::assertEquals('Description', $this->element->description);
$task->description = 'Description';
self::assertEquals('Description', $task->description);
} }
/** /**
@ -112,10 +121,8 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
*/ */
public function testDescriptionRawInputOutput() : void public function testDescriptionRawInputOutput() : void
{ {
$task = new TaskElement(); $this->element->descriptionRaw = 'DescriptionRaw';
self::assertEquals('DescriptionRaw', $this->element->descriptionRaw);
$task->descriptionRaw = 'DescriptionRaw';
self::assertEquals('DescriptionRaw', $task->descriptionRaw);
} }
/** /**
@ -124,10 +131,8 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
*/ */
public function testTaskInputOutput() : void public function testTaskInputOutput() : void
{ {
$task = new TaskElement(); $this->element->task = 2;
self::assertEquals(2, $this->element->task);
$task->task = 2;
self::assertEquals(2, $task->task);
} }
/** /**
@ -136,11 +141,12 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
*/ */
public function testAccountToInputOutput() : void public function testAccountToInputOutput() : void
{ {
$task = new TaskElement(); $this->element->addTo(new NullAccount(3));
$this->element->addTo(new NullAccount(3)); // test duplicate
self::assertTrue($this->element->isToAccount(3));
$task->addTo(new NullAccount(3)); $this->element->addTo(new NullGroup(4));
$task->addTo(new NullAccount(3)); // test duplicate self::assertCount(2, $this->element->getTo());
self::assertTrue($task->isToAccount(3));
} }
/** /**
@ -149,11 +155,12 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
*/ */
public function testGroupToInputOutput() : void public function testGroupToInputOutput() : void
{ {
$task = new TaskElement(); $this->element->addGroupTo(new NullGroup(4));
$this->element->addGroupTo(new NullGroup(4)); // test duplicate
self::assertTrue($this->element->isToGroup(4));
$task->addGroupTo(new NullGroup(4)); $this->element->addTo(new NullAccount(3));
$task->addGroupTo(new NullGroup(4)); // test duplicate self::assertCount(2, $this->element->getTo());
self::assertTrue($task->isToGroup(4));
} }
/** /**
@ -162,11 +169,12 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
*/ */
public function testAccountCCInputOutput() : void public function testAccountCCInputOutput() : void
{ {
$task = new TaskElement(); $this->element->addCC(new NullAccount(5));
$this->element->addCC(new NullAccount(5)); // test duplicate
self::assertTrue($this->element->isCCAccount(5));
$task->addCC(new NullAccount(5)); $this->element->addCC(new NullGroup(6));
$task->addCC(new NullAccount(5)); // test duplicate self::assertCount(2, $this->element->getCC());
self::assertTrue($task->isCCAccount(5));
} }
/** /**
@ -175,11 +183,12 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
*/ */
public function testGroupCCInputOutput() : void public function testGroupCCInputOutput() : void
{ {
$task = new TaskElement(); $this->element->addGroupCC(new NullGroup(6));
$this->element->addGroupCC(new NullGroup(6)); // test duplicate
self::assertTrue($this->element->isCCGroup(6));
$task->addGroupCC(new NullGroup(6)); $this->element->addCC(new NullAccount(5));
$task->addGroupCC(new NullGroup(6)); // test duplicate self::assertCount(2, $this->element->getCC());
self::assertTrue($task->isCCGroup(6));
} }
/** /**
@ -188,9 +197,7 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
*/ */
public function testInvalidAccountTo() : void public function testInvalidAccountTo() : void
{ {
$task = new TaskElement(); self::assertFalse($this->element->isToAccount(7));
self::assertFalse($task->isToAccount(7));
} }
/** /**
@ -199,9 +206,7 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
*/ */
public function testInvalidAccountCC() : void public function testInvalidAccountCC() : void
{ {
$task = new TaskElement(); self::assertFalse($this->element->isCCAccount(8));
self::assertFalse($task->isCCAccount(8));
} }
/** /**
@ -210,9 +215,7 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
*/ */
public function testInvalidGroupTo() : void public function testInvalidGroupTo() : void
{ {
$task = new TaskElement(); self::assertFalse($this->element->isToGroup(9));
self::assertFalse($task->isToGroup(9));
} }
/** /**
@ -221,9 +224,7 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
*/ */
public function testInvalidGroupCC() : void public function testInvalidGroupCC() : void
{ {
$task = new TaskElement(); self::assertFalse($this->element->isCCGroup(10));
self::assertFalse($task->isCCGroup(10));
} }
/** /**
@ -233,9 +234,7 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
public function testInvalidStatus() : void public function testInvalidStatus() : void
{ {
$this->expectException(\phpOMS\Stdlib\Base\Exception\InvalidEnumValue::class); $this->expectException(\phpOMS\Stdlib\Base\Exception\InvalidEnumValue::class);
$this->element->setStatus(9999);
$task = new TaskElement();
$task->setStatus(9999);
} }
/** /**
@ -245,8 +244,36 @@ final class TaskElementTest extends \PHPUnit\Framework\TestCase
public function testInvalidPriority() : void public function testInvalidPriority() : void
{ {
$this->expectException(\phpOMS\Stdlib\Base\Exception\InvalidEnumValue::class); $this->expectException(\phpOMS\Stdlib\Base\Exception\InvalidEnumValue::class);
$this->element->setPriority(9999);
}
$task = new TaskElement(); /**
$task->setPriority(9999); * @covers Modules\Tasks\Models\TaskElement
* @group module
*/
public function testSerialize() : void
{
$this->element->task = 2;
$this->element->description = 'Test';
$this->element->descriptionRaw = 'TestRaw';
$this->element->setStatus(TaskStatus::DONE);
$serialized = $this->element->jsonSerialize();
unset($serialized['createdAt']);
unset($serialized['createdBy']);
unset($serialized['due']);
self::assertEquals(
[
'id' => 0,
'task' => 2,
'description' => 'Test',
'descriptionRaw' => 'TestRaw',
'status' => TaskStatus::DONE,
'to' => [],
'cc' => [],
],
$serialized
);
} }
} }

8
tests/Models/TaskMapperTest.php
View File

@ -48,7 +48,7 @@ final class TaskMapperTest extends \PHPUnit\Framework\TestCase
$task = new Task(); $task = new Task();
$task->setCreatedBy(new NullAccount(1)); $task->setCreatedBy(new NullAccount(1));
$task->getSchedule()->createdBy = new NullAccount(1); $task->schedule->createdBy = new NullAccount(1);
$task->start = new \DateTime('2005-05-05'); $task->start = new \DateTime('2005-05-05');
$task->title = 'Task Test'; $task->title = 'Task Test';
$task->setStatus(TaskStatus::OPEN); $task->setStatus(TaskStatus::OPEN);
@ -159,7 +159,7 @@ final class TaskMapperTest extends \PHPUnit\Framework\TestCase
$task = new Task(); $task = new Task();
$task->setCreatedBy(new NullAccount(1)); $task->setCreatedBy(new NullAccount(1));
$task->getSchedule()->createdBy = new NullAccount(1); $task->schedule->createdBy = new NullAccount(1);
$task->start = new \DateTime('2005-05-05'); $task->start = new \DateTime('2005-05-05');
$task->title = $text->generateText(\mt_rand(1, 5)); $task->title = $text->generateText(\mt_rand(1, 5));
$task->setStatus($status); $task->setStatus($status);
@ -200,7 +200,7 @@ final class TaskMapperTest extends \PHPUnit\Framework\TestCase
$task = new Task(); $task = new Task();
$task->setCreatedBy(new NullAccount(1)); $task->setCreatedBy(new NullAccount(1));
$task->getSchedule()->createdBy = new NullAccount(1); $task->schedule->createdBy = new NullAccount(1);
$task->title = $text->generateText(\mt_rand(1, 5)); $task->title = $text->generateText(\mt_rand(1, 5));
$task->setStatus($status); $task->setStatus($status);
$task->isClosable = true; $task->isClosable = true;
@ -239,7 +239,7 @@ final class TaskMapperTest extends \PHPUnit\Framework\TestCase
$task = new Task(); $task = new Task();
$task->setCreatedBy(new NullAccount(1)); $task->setCreatedBy(new NullAccount(1));
$task->getSchedule()->createdBy = new NullAccount(1); $task->schedule->createdBy = new NullAccount(1);
$task->title = $text->generateText(\mt_rand(1, 5)); $task->title = $text->generateText(\mt_rand(1, 5));
$task->setStatus($status); $task->setStatus($status);
$task->isClosable = true; $task->isClosable = true;

286
tests/Models/TaskTest.php
View File

@ -16,6 +16,8 @@ namespace Modules\Tasks\tests\Models;
use Modules\Admin\Models\NullAccount; use Modules\Admin\Models\NullAccount;
use Modules\Admin\Models\NullGroup; use Modules\Admin\Models\NullGroup;
use Modules\Media\Models\Media;
use Modules\Tag\Models\Tag;
use Modules\Tasks\Models\Task; use Modules\Tasks\Models\Task;
use Modules\Tasks\Models\TaskElement; use Modules\Tasks\Models\TaskElement;
use Modules\Tasks\Models\TaskPriority; use Modules\Tasks\Models\TaskPriority;
@ -27,34 +29,45 @@ use Modules\Tasks\Models\TaskType;
*/ */
final class TaskTest extends \PHPUnit\Framework\TestCase final class TaskTest extends \PHPUnit\Framework\TestCase
{ {
private Task $task;
/**
* {@inheritdoc}
*/
protected function setUp() : void
{
$this->task = new Task();
}
/** /**
* @covers Modules\Tasks\Models\Task * @covers Modules\Tasks\Models\Task
* @group module * @group module
*/ */
public function testDefault() : void public function testDefault() : void
{ {
$task = new Task(); self::assertEquals(0, $this->task->getId());
self::assertEquals(0, $this->task->getCreatedBy()->getId());
self::assertEquals(0, $task->getId()); self::assertEquals('', $this->task->title);
self::assertEquals(0, $task->getCreatedBy()->getId()); self::assertFalse($this->task->isToAccount(0));
self::assertEquals('', $task->title); self::assertFalse($this->task->isCCAccount(0));
self::assertFalse($task->isToAccount(0)); self::assertFalse($this->task->isToGroup(0));
self::assertFalse($task->isCCAccount(0)); self::assertFalse($this->task->isCCGroup(0));
self::assertFalse($task->isToGroup(0)); self::assertTrue($this->task->isEditable);
self::assertFalse($task->isCCGroup(0)); self::assertEquals((new \DateTime('now'))->format('Y-m-d'), $this->task->createdAt->format('Y-m-d'));
self::assertTrue($task->isEditable); self::assertEquals((new \DateTime('now'))->format('Y-m-d'), $this->task->start->format('Y-m-d'));
self::assertEquals((new \DateTime('now'))->format('Y-m-d'), $task->createdAt->format('Y-m-d')); self::assertNull($this->task->done);
self::assertEquals((new \DateTime('now'))->format('Y-m-d'), $task->start->format('Y-m-d')); self::assertEquals((new \DateTime('now'))->modify('+1 day')->format('Y-m-d'), $this->task->due->format('Y-m-d'));
self::assertNull($task->done); self::assertEquals(TaskStatus::OPEN, $this->task->getStatus());
self::assertEquals((new \DateTime('now'))->modify('+1 day')->format('Y-m-d'), $task->due->format('Y-m-d')); self::assertTrue($this->task->isClosable);
self::assertEquals(TaskStatus::OPEN, $task->getStatus()); self::assertEquals(TaskPriority::NONE, $this->task->getPriority());
self::assertTrue($task->isClosable); self::assertEquals(TaskType::SINGLE, $this->task->getType());
self::assertEquals(TaskPriority::NONE, $task->getPriority()); self::assertEquals([], $this->task->getTaskElements());
self::assertEquals(TaskType::SINGLE, $task->getType()); self::assertEquals([], $this->task->getMedia());
self::assertEquals([], $task->getTaskElements()); self::assertEquals([], $this->task->getTags());
self::assertEquals('', $task->description); self::assertEquals('', $this->task->description);
self::assertEquals('', $task->descriptionRaw); self::assertEquals('', $this->task->descriptionRaw);
self::assertInstanceOf('\Modules\Tasks\Models\NullTaskElement', $task->getTaskElement(1)); self::assertInstanceOf('\Modules\Tag\Models\NullTag', $this->task->getTag(0));
self::assertInstanceOf('\Modules\Tasks\Models\NullTaskElement', $this->task->getTaskElement(1));
} }
/** /**
@ -63,10 +76,8 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
*/ */
public function testCreatedByInputOutput() : void public function testCreatedByInputOutput() : void
{ {
$task = new Task(); $this->task->setCreatedBy(new NullAccount(1));
self::assertEquals(1, $this->task->getCreatedBy()->getId());
$task->setCreatedBy(new NullAccount(1));
self::assertEquals(1, $task->getCreatedBy()->getId());
} }
/** /**
@ -75,10 +86,8 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
*/ */
public function testStartInputOutput() : void public function testStartInputOutput() : void
{ {
$task = new Task(); $this->task->start = ($date = new \DateTime('2005-05-05'));
self::assertEquals($date->format('Y-m-d'), $this->task->start->format('Y-m-d'));
$task->start = ($date = new \DateTime('2005-05-05'));
self::assertEquals($date->format('Y-m-d'), $task->start->format('Y-m-d'));
} }
/** /**
@ -87,10 +96,8 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
*/ */
public function testTitleInputOutput() : void public function testTitleInputOutput() : void
{ {
$task = new Task(); $this->task->title = 'Title';
self::assertEquals('Title', $this->task->title);
$task->title = 'Title';
self::assertEquals('Title', $task->title);
} }
/** /**
@ -99,10 +106,8 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
*/ */
public function testDoneInputOutput() : void public function testDoneInputOutput() : void
{ {
$task = new Task(); $this->task->done = ($date = new \DateTime('2000-05-06'));
self::assertEquals($date->format('Y-m-d'), $this->task->done->format('Y-m-d'));
$task->done = ($date = new \DateTime('2000-05-06'));
self::assertEquals($date->format('Y-m-d'), $task->done->format('Y-m-d'));
} }
/** /**
@ -111,10 +116,8 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
*/ */
public function testDueInputOutput() : void public function testDueInputOutput() : void
{ {
$task = new Task(); $this->task->due = ($date = new \DateTime('2000-05-07'));
self::assertEquals($date->format('Y-m-d'), $this->task->due->format('Y-m-d'));
$task->due = ($date = new \DateTime('2000-05-07'));
self::assertEquals($date->format('Y-m-d'), $task->due->format('Y-m-d'));
} }
/** /**
@ -123,10 +126,8 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
*/ */
public function testStatusInputOutput() : void public function testStatusInputOutput() : void
{ {
$task = new Task(); $this->task->setStatus(TaskStatus::DONE);
self::assertEquals(TaskStatus::DONE, $this->task->getStatus());
$task->setStatus(TaskStatus::DONE);
self::assertEquals(TaskStatus::DONE, $task->getStatus());
} }
/** /**
@ -135,10 +136,8 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
*/ */
public function testClosableInputOutput() : void public function testClosableInputOutput() : void
{ {
$task = new Task(); $this->task->isClosable = false;
self::assertFalse($this->task->isClosable);
$task->isClosable = false;
self::assertFalse($task->isClosable);
} }
/** /**
@ -147,10 +146,8 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
*/ */
public function testPriority() : void public function testPriority() : void
{ {
$task = new Task(); $this->task->setPriority(TaskPriority::LOW);
self::assertEquals(TaskPriority::LOW, $this->task->getPriority());
$task->setPriority(TaskPriority::LOW);
self::assertEquals(TaskPriority::LOW, $task->getPriority());
} }
/** /**
@ -159,8 +156,6 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
*/ */
public function testElementInputOutput() : void public function testElementInputOutput() : void
{ {
$task = new Task();
$taskElement1 = new TaskElement(); $taskElement1 = new TaskElement();
$taskElement1->addTo(new NullAccount(2)); $taskElement1->addTo(new NullAccount(2));
$taskElement1->addGroupTo(new NullGroup(4)); $taskElement1->addGroupTo(new NullGroup(4));
@ -174,21 +169,21 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
$taskElement2->addGroupCC(new NullGroup(9)); $taskElement2->addGroupCC(new NullGroup(9));
$id = []; $id = [];
$id[] = $task->addElement($taskElement1); $id[] = $this->task->addElement($taskElement1);
$id[] = $task->addElement($taskElement2); $id[] = $this->task->addElement($taskElement2);
self::assertTrue($task->isToAccount(2)); self::assertTrue($this->task->isToAccount(2));
self::assertTrue($task->isToAccount(3)); self::assertTrue($this->task->isToAccount(3));
self::assertTrue($task->isToGroup(4)); self::assertTrue($this->task->isToGroup(4));
self::assertTrue($task->isToGroup(5)); self::assertTrue($this->task->isToGroup(5));
self::assertTrue($task->isCCAccount(6)); self::assertTrue($this->task->isCCAccount(6));
self::assertTrue($task->isCCAccount(7)); self::assertTrue($this->task->isCCAccount(7));
self::assertTrue($task->isCCGroup(8)); self::assertTrue($this->task->isCCGroup(8));
self::assertTrue($task->isCCGroup(9)); self::assertTrue($this->task->isCCGroup(9));
self::assertEquals(0, $task->getTaskElements()[0]->getId()); self::assertEquals(0, $this->task->getTaskElements()[0]->getId());
self::assertEquals(0, $task->getTaskElement(0)->getId()); self::assertEquals(0, $this->task->getTaskElement(0)->getId());
} }
/** /**
@ -197,10 +192,6 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
*/ */
public function testElementRemoval() : void public function testElementRemoval() : void
{ {
$task = new Task();
$task = new Task();
$taskElement1 = new TaskElement(); $taskElement1 = new TaskElement();
$taskElement1->addTo(new NullAccount(2)); $taskElement1->addTo(new NullAccount(2));
$taskElement1->addGroupTo(new NullGroup(4)); $taskElement1->addGroupTo(new NullGroup(4));
@ -214,22 +205,44 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
$taskElement2->addGroupCC(new NullGroup(9)); $taskElement2->addGroupCC(new NullGroup(9));
$id = []; $id = [];
$id[] = $task->addElement($taskElement1); $id[] = $this->task->addElement($taskElement1);
$id[] = $task->addElement($taskElement2); $id[] = $this->task->addElement($taskElement2);
$success = $task->removeElement($id[1]); $success = $this->task->removeElement($id[1]);
self::assertTrue($success); self::assertTrue($success);
} }
/**
* @covers Modules\Tasks\Models\Task
* @group module
*/
public function testInvertElements() : void
{
$taskElement1 = new TaskElement();
$taskElement1->addTo(new NullAccount(2));
$taskElement1->addGroupTo(new NullGroup(4));
$taskElement1->addCC(new NullAccount(6));
$taskElement1->addGroupCC(new NullGroup(8));
$taskElement2 = new TaskElement();
$taskElement2->addTo(new NullAccount(3));
$taskElement2->addGroupTo(new NullGroup(5));
$taskElement2->addCC(new NullAccount(7));
$taskElement2->addGroupCC(new NullGroup(9));
$this->task->addElement($taskElement1);
$this->task->addElement($taskElement2);
self::assertEquals([$taskElement2, $taskElement1], $this->task->invertTaskElements());
}
/** /**
* @covers Modules\Tasks\Models\Task * @covers Modules\Tasks\Models\Task
* @group module * @group module
*/ */
public function testInvalidElementRemoval() : void public function testInvalidElementRemoval() : void
{ {
$task = new Task(); $success = $this->task->removeElement(99);
$success = $task->removeElement(99);
self::assertFalse($success); self::assertFalse($success);
} }
@ -239,10 +252,8 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
*/ */
public function testDescriptionInputOutput() : void public function testDescriptionInputOutput() : void
{ {
$task = new Task(); $this->task->description = 'Description';
self::assertEquals('Description', $this->task->description);
$task->description = 'Description';
self::assertEquals('Description', $task->description);
} }
/** /**
@ -251,10 +262,8 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
*/ */
public function testDescriptionRawInputOutput() : void public function testDescriptionRawInputOutput() : void
{ {
$task = new Task(); $this->task->descriptionRaw = 'DescriptionRaw';
self::assertEquals('DescriptionRaw', $this->task->descriptionRaw);
$task->descriptionRaw = 'DescriptionRaw';
self::assertEquals('DescriptionRaw', $task->descriptionRaw);
} }
/** /**
@ -263,10 +272,57 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
*/ */
public function testEditableInputOutput() : void public function testEditableInputOutput() : void
{ {
$task = new Task(); $this->task->isEditable = false;
self::assertFalse($this->task->isEditable);
}
$task->isEditable = false; /**
self::assertFalse($task->isEditable); * @covers Modules\Tasks\Models\Task
* @group module
*/
public function testTypeInputOutput() : void
{
$this->task->setType(TaskType::TEMPLATE);
self::assertEquals(TaskType::TEMPLATE, $this->task->getType());
}
/**
* @covers Modules\Tasks\Models\Task
* @group module
*/
public function testTagInputOutput() : void
{
$tag = new Tag();
$tag->setL11n('Tag');
$this->task->addTag($tag);
self::assertEquals($tag, $this->task->getTag(0));
self::assertCount(1, $this->task->getTags());
}
/**
* @covers Modules\Tasks\Models\Task
* @group module
*/
public function testTagRemove() : void
{
$tag = new Tag();
$tag->setL11n('Tag');
$this->task->addTag($tag);
self::assertTrue($this->task->removeTag(0));
self::assertCount(0, $this->task->getTags());
self::assertFalse($this->task->removeTag(0));
}
/**
* @covers Modules\Tasks\Models\Task
* @group module
*/
public function testMediaInputOutput() : void
{
$this->task->addMedia(new Media());
self::assertCount(1, $this->task->getMedia());
} }
/** /**
@ -275,23 +331,21 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
*/ */
public function testToArray() : void public function testToArray() : void
{ {
$task = new Task();
$arr = [ $arr = [
'id' => 0, 'id' => 0,
'createdBy' => $task->getCreatedBy(), 'createdBy' => $this->task->getCreatedBy(),
'createdAt' => $task->createdAt, 'createdAt' => $this->task->createdAt,
'title' => $task->title, 'title' => $this->task->title,
'description' => $task->description, 'description' => $this->task->description,
'status' => $task->getStatus(), 'status' => $this->task->getStatus(),
'type' => $task->getType(), 'type' => $this->task->getType(),
'priority' => $task->getPriority(), 'priority' => $this->task->getPriority(),
'due' => $task->due, 'due' => $this->task->due,
'done' => $task->done, 'done' => $this->task->done,
]; ];
$isSubset = true; $isSubset = true;
$parent = $task->toArray(); $parent = $this->task->toArray();
foreach ($arr as $key => $value) { foreach ($arr as $key => $value) {
if (!\array_key_exists($key, $parent) || $parent[$key] !== $value) { if (!\array_key_exists($key, $parent) || $parent[$key] !== $value) {
$isSubset = false; $isSubset = false;
@ -307,23 +361,21 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
*/ */
public function testToJson() : void public function testToJson() : void
{ {
$task = new Task();
$arr = [ $arr = [
'id' => 0, 'id' => 0,
'createdBy' => $task->getCreatedBy(), 'createdBy' => $this->task->getCreatedBy(),
'createdAt' => $task->createdAt, 'createdAt' => $this->task->createdAt,
'title' => $task->title, 'title' => $this->task->title,
'description' => $task->description, 'description' => $this->task->description,
'status' => $task->getStatus(), 'status' => $this->task->getStatus(),
'type' => $task->getType(), 'type' => $this->task->getType(),
'priority' => $task->getPriority(), 'priority' => $this->task->getPriority(),
'due' => $task->due, 'due' => $this->task->due,
'done' => $task->done, 'done' => $this->task->done,
]; ];
$isSubset = true; $isSubset = true;
$parent = $task->jsonSerialize(); $parent = $this->task->jsonSerialize();
foreach ($arr as $key => $value) { foreach ($arr as $key => $value) {
if (!\array_key_exists($key, $parent) || $parent[$key] !== $value) { if (!\array_key_exists($key, $parent) || $parent[$key] !== $value) {
$isSubset = false; $isSubset = false;
@ -340,9 +392,7 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
public function testInvalidStatus() : void public function testInvalidStatus() : void
{ {
$this->expectException(\phpOMS\Stdlib\Base\Exception\InvalidEnumValue::class); $this->expectException(\phpOMS\Stdlib\Base\Exception\InvalidEnumValue::class);
$this->task->setStatus(9999);
$task = new Task();
$task->setStatus(9999);
} }
/** /**
@ -352,8 +402,6 @@ final class TaskTest extends \PHPUnit\Framework\TestCase
public function testInvalidPriority() : void public function testInvalidPriority() : void
{ {
$this->expectException(\phpOMS\Stdlib\Base\Exception\InvalidEnumValue::class); $this->expectException(\phpOMS\Stdlib\Base\Exception\InvalidEnumValue::class);
$this->task->setPriority(9999);
$task = new Task();
$task->setPriority(9999);
} }
} }

45
tests/Views/TaskViewTest.php Normal file
View File

@ -0,0 +1,45 @@
<?php
/**
* Orange Management
*
* PHP Version 8.0
*
* @package tests
* @copyright Dennis Eichhorn
* @license OMS License 1.0
* @version 1.0.0
* @link https://orange-management.org
*/
declare(strict_types=1);
namespace Modules\Tasks\tests\Views;
use Modules\Tasks\Views\TaskView;
/**
* @internal
*/
class TaskViewTest extends \PHPUnit\Framework\TestCase
{
/**
* @covers Modules\Tasks\Views\TaskView
* @group framework
*/
public function testDefault() : void
{
$view = new TaskView();
self::assertStringContainsString('', $view->getAccountImage(999));
}
/**
* @covers Modules\Tasks\Views\TaskView
* @group framework
*/
public function testAccountImageUrl() : void
{
$view = new TaskView();
self::assertEquals('Web/Backend/img/default-user.jpg', $view->getAccountImage(1));
}
}