code fixes

Controller/ApiController.php

@@ -25,10 +25,8 @@ use Modules\Media\Models\Reference;
 use Modules\Media\Models\ReferenceMapper;
 use Modules\Notification\Models\Notification;
 use Modules\Notification\Models\NotificationMapper;
-use Modules\Notification\Models\NotificationStatus;
 use Modules\Notification\Models\NotificationType;
 use Modules\Profile\Models\ProfileMapper;
-use Modules\Tasks\Models\DutyType;
 use Modules\Tasks\Models\PermissionCategory;
 use Modules\Tasks\Models\Task;
 use Modules\Tasks\Models\TaskElement;
@@ -133,7 +131,7 @@ final class ApiController extends Controller
      */
     public function createTaskReminderFromRequest(RequestAbstract $request) : array
     {
-        /** @var AccountRelation[] $responsible */
+        /** @var \Modules\Tasks\Models\AccountRelation[] $responsible */
         $responsible = TaskMapper::getResponsible((int) $request->getData('id'));
 
         $reminder = [];
@@ -176,7 +174,10 @@ final class ApiController extends Controller
         $task = $this->createTaskFromRequest($request);
         $this->createModel($request->header->account, $task, TaskMapper::class, 'task', $request->getOrigin());
 
-        $this->createNotifications(\reset($task->taskElements), NotificationType::CREATE, $request);
+        $first = \reset($task->taskElements);
+        if ($first !== false) {
+            $this->createNotifications($first, NotificationType::CREATE, $request);
+        }
 
         if (!empty($request->files)
             || !empty($request->getDataJson('media'))
@@ -187,6 +188,19 @@ final class ApiController extends Controller
         $this->createStandardCreateResponse($request, $response, $task);
     }
 
+    /**
+     * Create notifications for users.
+     *
+     * This is usually called when creating a task or adding a new child element.
+     *
+     * @param TaskElement     $ele     Task element
+     * @param int             $type    Notification type (e.g. new, new child element, ...)
+     * @param RequestAbstract $request Request that caused this notification to get created
+     *
+     * @return void
+     *
+     * @since 1.0.0
+     */
     private function createNotifications(TaskElement $ele, int $type, RequestAbstract $request) : void
     {
         $accChecked = [];

Controller/BackendController.php

@@ -126,7 +126,6 @@ final class BackendController extends Controller implements DashboardElementInte
                 ->execute();
         }
 
-        /** @var \Modules\Tasks\Models\TaskSeen[] $unread */
         $view->data['unread'] = TaskMapper::getUnread($request->header->account);
 
         return $view;
@@ -195,6 +194,8 @@ final class BackendController extends Controller implements DashboardElementInte
         }
 
         $view->data['task_media'] = [];
+
+        /** @var \Modules\Tasks\Models\Task $task */
         foreach ($view->data['tasks'] as $task) {
             $view->data['task_media'][$task->id] = TaskMapper::has()
                 ->with('files')
@@ -203,7 +204,6 @@ final class BackendController extends Controller implements DashboardElementInte
                 ->execute();
         }
 
-        /** @var \Modules\Tasks\Models\TaskSeen[] $unread */
         $view->data['unread'] = TaskMapper::getUnread($request->header->account);
 
         return $view;
@@ -321,7 +321,7 @@ final class BackendController extends Controller implements DashboardElementInte
                 // Shows all reminders
                 if ($unseen->reminderBy !== null
                     && ($unseen->reminderAt?->getTimestamp() ?? 0) < $request->header->getRequestTime()
-                    && ($unseen->reminderAt?->getTimestamp() ?? 0) > ($unseen->seenAt?->getTimestamp() ?? 0) - 300
+                    && ($unseen->reminderAt?->getTimestamp() ?? 0) > $unseen->seenAt->getTimestamp() - 300
                 ) {
                     $reminderStatus[] = $unseen;
 

Models/Task.php

@@ -428,6 +428,13 @@ class Task implements \JsonSerializable
         return $this->taskElements[$id] ?? new NullTaskElement();
     }
 
+    /**
+     * Get accounts that are responsible for this task
+     *
+     * @return Account[]
+     *
+     * @since 1.0.0
+     */
     public function getResponsible() : array
     {
         $responsible = [];
@@ -482,6 +489,17 @@ class Task implements \JsonSerializable
         return $this->toArray();
     }
 
+    /**
+     * Create a new task from a task template.
+     *
+     * A task template is a normal task with the type of TEMPLATE.
+     *
+     * @param self $task Task to "clone"
+     *
+     * @return self
+     *
+     * @since 1.0.0
+     */
     public static function fromTemplate(self $task) : self
     {
         $now = new \DateTimeImmutable('now');

Models/TaskMapper.php

@@ -411,7 +411,7 @@ final class TaskMapper extends DataMapperFactory
                 ->innerJoin(AccountRelationMapper::TABLE)
                     ->on(TaskElementMapper::TABLE . '.' . TaskElementMapper::PRIMARYFIELD, '=', AccountRelationMapper::TABLE . '.task_account_task_element')
                 ->leftJoin(TaskSeenMapper::TABLE)
-                    ->on(TaskMapper::TABLE . '.' . TaskMapper::PRIMARYFIELD, '=', TaskSeenMapper::TABLE . '.task_seen_task')
+                    ->on(self::TABLE . '.' . self::PRIMARYFIELD, '=', TaskSeenMapper::TABLE . '.task_seen_task')
                 ->where(self::TABLE . '.task_status', '=', TaskStatus::OPEN)
                 ->andWhere(AccountRelationMapper::TABLE . '.task_account_account', '=', $user)
                 ->andWhere(TaskSeenMapper::TABLE . '.task_seen_task', '=', null);