From 6878ba1fdfd62f823f18e924f6bbacff54572eae Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Thu, 8 Oct 2020 15:12:24 +0200 Subject: [PATCH] fix tests and replace file_exists --- tests/BackendControllerTest.php | 4 ++ tests/ControllerTest.php | 4 ++ tests/Models/AccountRelationTest.php | 8 +++ tests/Models/GroupRelationTest.php | 8 +++ tests/Models/TaskElementTest.php | 72 ++++++++++++++++++++++++++ tests/Models/TaskTest.php | 76 ++++++++++++++++++++++++++++ 6 files changed, 172 insertions(+) diff --git a/tests/BackendControllerTest.php b/tests/BackendControllerTest.php index 6a2d488..5fe4009 100755 --- a/tests/BackendControllerTest.php +++ b/tests/BackendControllerTest.php @@ -75,6 +75,10 @@ class BackendControllerTest extends \PHPUnit\Framework\TestCase TestUtils::setMember($this->module, 'app', $this->app); } + /** + * @covers Modules\Tasks\Controller\BackendController + * @group module + */ public function testNavigation() : void { self::assertEquals(0, $this->module->openNav(999)); diff --git a/tests/ControllerTest.php b/tests/ControllerTest.php index 5b89561..d148afa 100755 --- a/tests/ControllerTest.php +++ b/tests/ControllerTest.php @@ -195,6 +195,10 @@ class ControllerTest extends \PHPUnit\Framework\TestCase self::assertEquals('This is a changed description', $response->get('')['response']->getDescriptionRaw()); } + /** + * @covers Modules\Tasks\Controller\ApiController + * @group module + */ public function testInvalidTaskCreate() : void { $response = new HttpResponse(); diff --git a/tests/Models/AccountRelationTest.php b/tests/Models/AccountRelationTest.php index 9b432f9..fbefc9d 100755 --- a/tests/Models/AccountRelationTest.php +++ b/tests/Models/AccountRelationTest.php @@ -23,6 +23,10 @@ use Modules\Tasks\Models\DutyType; */ class AccountRelationTest extends \PHPUnit\Framework\TestCase { + /** + * @covers Modules\Tasks\Models\AccountRelation + * @group module + */ public function testDefault() : void { $obj = new AccountRelation(); @@ -31,6 +35,10 @@ class AccountRelationTest extends \PHPUnit\Framework\TestCase self::assertEquals(DutyType::TO, $obj->getDuty()); } + /** + * @covers Modules\Tasks\Models\AccountRelation + * @group module + */ public function testSetGet() : void { $obj = new AccountRelation($a = new NullAccount(1), DutyType::CC); diff --git a/tests/Models/GroupRelationTest.php b/tests/Models/GroupRelationTest.php index 56b6fab..7ec7ca9 100755 --- a/tests/Models/GroupRelationTest.php +++ b/tests/Models/GroupRelationTest.php @@ -23,6 +23,10 @@ use Modules\Tasks\Models\GroupRelation; */ class GroupRelationTest extends \PHPUnit\Framework\TestCase { + /** + * @covers Modules\Tasks\Models\GroupRelation + * @group module + */ public function testDefault() : void { $obj = new GroupRelation(); @@ -31,6 +35,10 @@ class GroupRelationTest extends \PHPUnit\Framework\TestCase self::assertEquals(DutyType::TO, $obj->getDuty()); } + /** + * @covers Modules\Tasks\Models\GroupRelation + * @group module + */ public function testSetGet() : void { $obj = new GroupRelation($g = new NullGroup(1), DutyType::CC); diff --git a/tests/Models/TaskElementTest.php b/tests/Models/TaskElementTest.php index 8f67c96..76a7a30 100755 --- a/tests/Models/TaskElementTest.php +++ b/tests/Models/TaskElementTest.php @@ -25,6 +25,10 @@ use Modules\Tasks\Models\TaskStatus; */ class TaskElementTest extends \PHPUnit\Framework\TestCase { + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testDefault() : void { $task = new TaskElement(); @@ -42,6 +46,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase self::assertEquals(TaskPriority::NONE, $task->getPriority()); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testCreatedByInputOutput() : void { $task = new TaskElement(); @@ -50,6 +58,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase self::assertEquals(1, $task->getCreatedBy()->getId()); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testDueInputOutput() : void { $task = new TaskElement(); @@ -58,6 +70,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase self::assertEquals($date->format('Y-m-d'), $task->getDue()->format('Y-m-d')); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testStatusInputOutput() : void { $task = new TaskElement(); @@ -66,6 +82,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase self::assertEquals(TaskStatus::DONE, $task->getStatus()); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testPriorityInputOutput() : void { $task = new TaskElement(); @@ -74,6 +94,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase self::assertEquals(TaskPriority::MEDIUM, $task->getPriority()); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testDescriptionInputOutput() : void { $task = new TaskElement(); @@ -82,6 +106,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase self::assertEquals('Description', $task->getDescription()); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testDescriptionRawInputOutput() : void { $task = new TaskElement(); @@ -90,6 +118,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase self::assertEquals('DescriptionRaw', $task->getDescriptionRaw()); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testTaskInputOutput() : void { $task = new TaskElement(); @@ -98,6 +130,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase self::assertEquals(2, $task->getTask()); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testAccountToInputOutput() : void { $task = new TaskElement(); @@ -107,6 +143,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase self::assertTrue($task->isToAccount(3)); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testGroupToInputOutput() : void { $task = new TaskElement(); @@ -116,6 +156,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase self::assertTrue($task->isToGroup(4)); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testAccountCCInputOutput() : void { $task = new TaskElement(); @@ -125,6 +169,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase self::assertTrue($task->isCCAccount(5)); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testGroupCCInputOutput() : void { $task = new TaskElement(); @@ -134,6 +182,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase self::assertTrue($task->isCCGroup(6)); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testInvalidAccountTo() : void { $task = new TaskElement(); @@ -141,6 +193,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase self::assertFalse($task->isToAccount(7)); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testInvalidAccountCC() : void { $task = new TaskElement(); @@ -148,6 +204,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase self::assertFalse($task->isCCAccount(8)); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testInvalidGroupTo() : void { $task = new TaskElement(); @@ -155,6 +215,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase self::assertFalse($task->isToGroup(9)); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testInvalidGroupCC() : void { $task = new TaskElement(); @@ -162,6 +226,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase self::assertFalse($task->isCCGroup(10)); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testInvalidStatus() : void { $this->expectException(\phpOMS\Stdlib\Base\Exception\InvalidEnumValue::class); @@ -170,6 +238,10 @@ class TaskElementTest extends \PHPUnit\Framework\TestCase $task->setStatus(9999); } + /** + * @covers Modules\Tasks\Models\TaskElement + * @group module + */ public function testInvalidPriority() : void { $this->expectException(\phpOMS\Stdlib\Base\Exception\InvalidEnumValue::class); diff --git a/tests/Models/TaskTest.php b/tests/Models/TaskTest.php index a244c84..a66922a 100755 --- a/tests/Models/TaskTest.php +++ b/tests/Models/TaskTest.php @@ -27,6 +27,10 @@ use Modules\Tasks\Models\TaskType; */ class TaskTest extends \PHPUnit\Framework\TestCase { + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testDefault() : void { $task = new Task(); @@ -53,6 +57,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertInstanceOf('\Modules\Tasks\Models\NullTaskElement', $task->getTaskElement(1)); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testCreatedByInputOutput() : void { $task = new Task(); @@ -61,6 +69,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertEquals(1, $task->getCreatedBy()->getId()); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testStartInputOutput() : void { $task = new Task(); @@ -69,6 +81,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertEquals($date->format('Y-m-d'), $task->getStart()->format('Y-m-d')); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testTitleInputOutput() : void { $task = new Task(); @@ -77,6 +93,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertEquals('Title', $task->getTitle()); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testDoneInputOutput() : void { $task = new Task(); @@ -85,6 +105,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertEquals($date->format('Y-m-d'), $task->getDone()->format('Y-m-d')); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testDueInputOutput() : void { $task = new Task(); @@ -93,6 +117,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertEquals($date->format('Y-m-d'), $task->getDue()->format('Y-m-d')); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testStatusInputOutput() : void { $task = new Task(); @@ -101,6 +129,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertEquals(TaskStatus::DONE, $task->getStatus()); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testClosableInputOutput() : void { $task = new Task(); @@ -109,6 +141,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertFalse($task->isClosable()); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testPriority() : void { $task = new Task(); @@ -117,6 +153,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertEquals(TaskPriority::LOW, $task->getPriority()); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testElementInputOutput() : void { $task = new Task(); @@ -151,6 +191,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertEquals(0, $task->getTaskElement(0)->getId()); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testElementRemoval() : void { $task = new Task(); @@ -177,6 +221,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertTrue($success); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testInvalidElementRemoval() : void { $task = new Task(); @@ -185,6 +233,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertFalse($success); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testDescriptionInputOutput() : void { $task = new Task(); @@ -193,6 +245,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertEquals('Description', $task->getDescription()); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testDescriptionRawInputOutput() : void { $task = new Task(); @@ -201,6 +257,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertEquals('DescriptionRaw', $task->getDescriptionRaw()); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testEditableInputOutput() : void { $task = new Task(); @@ -209,6 +269,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertFalse($task->isEditable()); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testToArray() : void { $task = new Task(); @@ -237,6 +301,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertTrue($isSubset); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testToJson() : void { $task = new Task(); @@ -265,6 +333,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase self::assertTrue($isSubset); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testInvalidStatus() : void { $this->expectException(\phpOMS\Stdlib\Base\Exception\InvalidEnumValue::class); @@ -273,6 +345,10 @@ class TaskTest extends \PHPUnit\Framework\TestCase $task->setStatus(9999); } + /** + * @covers Modules\Tasks\Models\Task + * @group module + */ public function testInvalidPriority() : void { $this->expectException(\phpOMS\Stdlib\Base\Exception\InvalidEnumValue::class);