Jingga/oms-Tasks
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Tasks.git synced 2026-02-16 22:58:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

impl. todos or move to Project.md

Browse Source
This commit is contained in:
Dennis Eichhorn 2021-09-27 23:14:01 +02:00
parent 4ccc7adb80
commit 622a710378
2 changed files with 15 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
CONTRIBUTING.md
View File

@ -12,14 +12,7 @@ If you have a good idea for improvement feel free to create a new issue with all
### Issues ### Issues
Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the code and have the following structure: Feel free to grab any open issue implement it and create a new pull request. Most issues can be found in the `Project.md` file in the `Docs` repository.
```php
/**
* @todo Orange-Management/Orange-Management#ISSUE_NUMBER [d:difficulty]
* Description for the issue
*/
```
The issue information can be used to provide additional information such as priority, difficulty and type. For your first issue try to find a issue marked `[d:first]` or `[d:beginner]`. The issue information can be used to provide additional information such as priority, difficulty and type. For your first issue try to find a issue marked `[d:first]` or `[d:beginner]`.

22
Controller/ApiController.php
View File

@ -371,7 +371,7 @@ final class ApiController extends Controller
} }
/** /**
* Api method to update a task * Api method to update a task element
* *
* @param RequestAbstract $request Request * @param RequestAbstract $request Request
* @param ResponseAbstract $response Response * @param ResponseAbstract $response Response
@ -389,13 +389,19 @@ final class ApiController extends Controller
$new = $this->updateTaskElementFromRequest($request); $new = $this->updateTaskElementFromRequest($request);
$this->updateModel($request->header->account, $old, $new, TaskElementMapper::class, 'taskelement', $request->getOrigin()); $this->updateModel($request->header->account, $old, $new, TaskElementMapper::class, 'taskelement', $request->getOrigin());
/** if ($old->getSatus() !== $new->getStatus()
* @todo Orange-Management/oms-Tasks#2 || $old->getPriority() !== $new->getPriority()
* Update task status depending on the new task element or updated task element || $old->getDue() !== $new->getDue()
* The task status is not normalized and relates to the last task element. ) {
* Depending on the task status of the last task element also the task status should change. $task = TaskMapper::get($new->task);
*/
//$this->updateModel($request->header->account, $task, $task, TaskMapper::class, 'task', $request->getOrigin()); $task->setStatus($new->getStatus());
$task->setPriority($new->getPriority());
$task->due = $new->due;
$this->updateModel($request->header->account, $task, $task, TaskMapper::class, 'task', $request->getOrigin());
}
$this->fillJsonResponse($request, $response, NotificationLevel::OK, 'Task element', 'Task element successfully updated.', $new); $this->fillJsonResponse($request, $response, NotificationLevel::OK, 'Task element', 'Task element successfully updated.', $new);
} }