From f462c21eae711840b7c4cfda4d650d337e802554 Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nes.com@googlemail.com>
Date: Sat, 2 May 2020 10:13:21 +0200
Subject: [PATCH] improve docblocks for Mapper:: variables

---
 Controller/ApiController.php     | 4 ++++
 Controller/BackendController.php | 7 ++++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/Controller/ApiController.php b/Controller/ApiController.php
index b750ad1..cf91246 100644
--- a/Controller/ApiController.php
+++ b/Controller/ApiController.php
@@ -78,6 +78,7 @@ final class ApiController extends Controller
      */
     public function apiTagUpdate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
     {
+        /** @var Tag $old */
         $old = clone TagMapper::get((int) $request->getData('id'));
         $new = $this->updateTagFromRequest($request);
         $this->updateModel($request->getHeader()->getAccount(), $old, $new, TagMapper::class, 'tag');
@@ -95,6 +96,7 @@ final class ApiController extends Controller
      */
     private function updateTagFromRequest(RequestAbstract $request) : Tag
     {
+        /** @var Tag $tag */
         $tag = TagMapper::get((int) $request->getData('id'));
         $tag->setTitle((string) ($request->getData('title') ?? $tag->getTitle()));
         $tag->setColor($request->getData('color') ?? $tag->getColor());
@@ -218,6 +220,7 @@ final class ApiController extends Controller
      */
     public function apiTagGet(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
     {
+        /** @var Tag $tag */
         $tag = TagMapper::get((int) $request->getData('id'));
         $this->fillJsonResponse($request, $response, NotificationLevel::OK, 'Tag', 'Tag successfully returned', $tag);
     }
@@ -237,6 +240,7 @@ final class ApiController extends Controller
      */
     public function apiTagDelete(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
     {
+        /** @var Tag $tag */
         $tag = TagMapper::get((int) $request->getData('id'));
         $this->deleteModel($request->getHeader()->getAccount(), $tag, TagMapper::class, 'tag');
         $this->fillJsonResponse($request, $response, NotificationLevel::OK, 'Tag', 'Tag successfully deleted', $tag);
diff --git a/Controller/BackendController.php b/Controller/BackendController.php
index 02eeb5e..f135c26 100644
--- a/Controller/BackendController.php
+++ b/Controller/BackendController.php
@@ -78,11 +78,16 @@ final class BackendController extends Controller
                 TagMapper::withConditional('language', $response->getHeader()->getL11n()->getLanguage())
                     ::getBeforePivot((int) ($request->getData('id') ?? 0), null, 25)
             );
-        } else {
+        } elseif ($request->getData('ptype') === '+') {
             $view->setData('tags',
                 TagMapper::withConditional('language', $response->getHeader()->getL11n()->getLanguage())
                     ::getAfterPivot((int) ($request->getData('id') ?? 0), null, 25)
             );
+        } else {
+            $view->setData('tags',
+                TagMapper::withConditional('language', $response->getHeader()->getL11n()->getLanguage())
+                    ::getAfterPivot(0, null, 25)
+            );
         }
 
         return $view;