Jingga/oms-Tag
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Tag.git synced 2026-01-11 15:48:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

doc fixes

Browse Source
This commit is contained in:
Dennis Eichhorn 2022-04-21 23:52:00 +02:00
parent f3f50714df
commit b8118f4a5b
3 changed files with 16 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CONTRIBUTING.md
View File

@ -16,7 +16,7 @@ Generally, the development philosophy is result orientated. This means that anyo
Developers are encouraged to pick open tasks with high priorities according to their own skill level. Senior developers may directly assign tasks to developers based on their importance. New developers may find it easier to start with a task that has a low priority as they often also have a lower difficulty.
Open tasks can be found in the project overview: [PROJECT.md](../Project/PROJECT.md)
Open tasks can be found in the project overview: [PROJECT.md](https://github.com/Karaka-Management/Organization-Guide/blob/master/Project/PROJECT.md)
Tasks currently in development are prefixed in the priority column with an asterisk `*` and a name tag in the task description of the developer who is working on the task.

16
Controller/ApiController.php
View File

@ -49,8 +49,8 @@ final class ApiController extends Controller
$val = [];
if (($val['title'] = empty($request->getData('title')))
|| ($val['color'] = (!empty($request->getData('color'))
&& (!\ctype_xdigit(\ltrim($request->getData('color') ?? '', '#'))
|| \stripos($request->getData('color') ?? '', '#') !== 0)))
&& (!\ctype_xdigit(\ltrim($request->getData('color'), '#'))
|| \stripos($request->getData('color'), '#') !== 0)))
) {
return $val;
}
@ -71,7 +71,7 @@ final class ApiController extends Controller
*
* @since 1.0.0
*/
public function apiTagUpdate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
public function apiTagUpdate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{
/** @var Tag $old */
$old = clone TagMapper::get()->where('id', (int) $request->getData('id'))->execute();
@ -112,7 +112,7 @@ final class ApiController extends Controller
*
* @since 1.0.0
*/
public function apiTagCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
public function apiTagCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{
if (!empty($val = $this->validateTagCreate($request))) {
$response->set('tag_create', new FormValidation($val));
@ -162,7 +162,7 @@ final class ApiController extends Controller
*
* @since 1.0.0
*/
public function apiTagL11nCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
public function apiTagL11nCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{
if (!empty($val = $this->validateTagL11nCreate($request))) {
$response->set('tag_l11n_create', new FormValidation($val));
@ -229,7 +229,7 @@ final class ApiController extends Controller
*
* @since 1.0.0
*/
public function apiTagGet(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
public function apiTagGet(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{
/** @var Tag $tag */
$tag = TagMapper::get()->where('id', (int) $request->getData('id'))->execute();
@ -249,7 +249,7 @@ final class ApiController extends Controller
*
* @since 1.0.0
*/
public function apiTagDelete(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
public function apiTagDelete(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{
/** @var Tag $tag */
$tag = TagMapper::get()->where('id', (int) $request->getData('id'))->execute();
@ -270,7 +270,7 @@ final class ApiController extends Controller
*
* @since 1.0.0
*/
public function apiTagFind(RequestAbstract $request, ResponseAbstract $response, $data = null) : void
public function apiTagFind(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{
$response->header->set('Content-Type', MimeType::M_JSON, true);
$response->set(

11
Controller/BackendController.php
View File

@ -44,7 +44,7 @@ final class BackendController extends Controller
* @since 1.0.0
* @codeCoverageIgnore
*/
public function viewTagCreate(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface
public function viewTagCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : RenderableInterface
{
$view = new View($this->app->l11nManager, $request, $response);
@ -66,7 +66,7 @@ final class BackendController extends Controller
* @since 1.0.0
* @codeCoverageIgnore
*/
public function viewTagList(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface
public function viewTagList(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : RenderableInterface
{
$view = new View($this->app->l11nManager, $request, $response);
@ -102,15 +102,18 @@ final class BackendController extends Controller
* @since 1.0.0
* @codeCoverageIgnore
*/
public function viewTagSingle(RequestAbstract $request, ResponseAbstract $response, $data = null) : RenderableInterface
public function viewTagSingle(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : RenderableInterface
{
$view = new View($this->app->l11nManager, $request, $response);
$tag = TagMapper::get()->with('title')->where('id', (int) $request->getData('id'))->where('title/language', $response->getLanguage())->execute();
/** @var \Modules\Tag\Models\Tag $tag */
$tag = TagMapper::get()->with('title')->where('id', (int) $request->getData('id'))->where('title/language', $response->getLanguage())->execute();
$view->setTemplate('/Modules/Tag/Theme/Backend/tag-single');
$view->addData('nav', $this->app->moduleManager->get('Navigation')->createNavigationMid(1007501001, $request, $response));
$view->addData('tag', $tag);
/** @var \Modules\Tag\Models\TagL11n[] $l11n */
$l11n = TagL11nMapper::getAll()->where('tag', $tag->getId())->execute();
$view->addData('l11n', $l11n);