From 0bf94eea999144bc7f6951161929b88967ea5577 Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Thu, 26 Nov 2020 20:50:18 +0100 Subject: [PATCH] fix todos/move to todo list --- Controller/ApiController.php | 4 ---- Controller/Controller.php | 1 - Models/TagL11nMapper.php | 18 ------------------ 3 files changed, 23 deletions(-) diff --git a/Controller/ApiController.php b/Controller/ApiController.php index f32b85e..6e4e226 100755 --- a/Controller/ApiController.php +++ b/Controller/ApiController.php @@ -33,10 +33,6 @@ use phpOMS\System\MimeType; * @license OMS License 1.0 * @link https://orange-management.org * @since 1.0.0 - * - * @todo Orange-Management/Modules#153 - * Create Module - * Create a badge module instead of letting modules create their own internal badge/tag system. */ final class ApiController extends Controller { diff --git a/Controller/Controller.php b/Controller/Controller.php index c8f75a0..3f63347 100755 --- a/Controller/Controller.php +++ b/Controller/Controller.php @@ -15,7 +15,6 @@ declare(strict_types=1); namespace Modules\Tag\Controller; use phpOMS\Module\ModuleAbstract; -use phpOMS\Module\WebInterface; /** * Tag controller class. diff --git a/Models/TagL11nMapper.php b/Models/TagL11nMapper.php index 201701b..8af916e 100755 --- a/Models/TagL11nMapper.php +++ b/Models/TagL11nMapper.php @@ -24,8 +24,6 @@ use phpOMS\Localization\Defaults\LanguageMapper; * @license OMS License 1.0 * @link https://orange-management.org * @since 1.0.0 - * - * @todo Do I really want to create a relation to the language mapper? It's not really needed right? */ final class TagL11nMapper extends DataMapperAbstract { @@ -42,22 +40,6 @@ final class TagL11nMapper extends DataMapperAbstract 'tag_l11n_language' => ['name' => 'tag_l11n_language', 'type' => 'string', 'internal' => 'language'], ]; - /** - * Has one relation. - * - * @var array - * @since 1.0.0 - */ - protected static array $ownsOne = [ - 'language' => [ - 'mapper' => LanguageMapper::class, - 'external' => 'tag_l11n_language', - 'by' => 'code2', - 'column' => 'code2', - 'conditional' => true, - ], - ]; - /** * Primary table. *