From 69210b0e38202d3607df41009db744aa165bccdf Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nnes.com@googlemail.com>
Date: Thu, 25 Apr 2024 13:34:46 +0000
Subject: [PATCH] fix tests

---
 Controller/ApiController.php                  |  2 +-
 Models/NullTicketElement.php                  | 47 ---------------
 .../Api/ApiControllerTicketTrait.php          | 16 -----
 tests/Models/NullTicketElementTest.php        | 44 --------------
 tests/Models/TicketElementTest.php            | 58 -------------------
 tests/Models/TicketTest.php                   | 28 ---------
 6 files changed, 1 insertion(+), 194 deletions(-)
 delete mode 100755 Models/NullTicketElement.php
 delete mode 100755 tests/Models/NullTicketElementTest.php
 delete mode 100755 tests/Models/TicketElementTest.php

diff --git a/Controller/ApiController.php b/Controller/ApiController.php
index 502b2d1..4249bf4 100755
--- a/Controller/ApiController.php
+++ b/Controller/ApiController.php
@@ -393,7 +393,7 @@ final class ApiController extends Controller
     {
         $this->app->moduleManager->get('Tasks')->apiTaskElementSet($request, $response);
 
-        /** @var \Modules\Tasks\models\TaskElement $new */
+        /** @var \Modules\Tasks\Models\TaskElement $new */
         $new = $response->getDataArray($request->uri->__toString())['response'];
 
         $ticket = TicketMapper::get()
diff --git a/Models/NullTicketElement.php b/Models/NullTicketElement.php
deleted file mode 100755
index 5bea62e..0000000
--- a/Models/NullTicketElement.php
+++ /dev/null
@@ -1,47 +0,0 @@
-<?php
-/**
- * Jingga
- *
- * PHP Version 8.2
- *
- * @package   Modules\Support\Models
- * @copyright Dennis Eichhorn
- * @license   OMS License 2.0
- * @version   1.0.0
- * @link      https://jingga.app
- */
-declare(strict_types=1);
-
-namespace Modules\Support\Models;
-
-/**
- * Null model
- *
- * @package Modules\Support\Models
- * @license OMS License 2.0
- * @link    https://jingga.app
- * @since   1.0.0
- */
-final class NullTicketElement extends TicketElement
-{
-    /**
-     * Constructor
-     *
-     * @param int $id Model id
-     *
-     * @since 1.0.0
-     */
-    public function __construct(int $id = 0)
-    {
-        $this->id = $id;
-        parent::__construct();
-    }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function jsonSerialize() : mixed
-    {
-        return ['id' => $this->id];
-    }
-}
diff --git a/tests/Controller/Api/ApiControllerTicketTrait.php b/tests/Controller/Api/ApiControllerTicketTrait.php
index a80e54e..efb5527 100755
--- a/tests/Controller/Api/ApiControllerTicketTrait.php
+++ b/tests/Controller/Api/ApiControllerTicketTrait.php
@@ -123,22 +123,6 @@ trait ApiControllerTicketTrait
         self::assertGreaterThan(0, $response->getDataArray('')['response']->id);
     }
 
-    /**
-     * @covers \Modules\Support\Controller\ApiController
-     */
-    #[\PHPUnit\Framework\Attributes\Group('module')]
-    public function testApiTicketElementGet() : void
-    {
-        $response = new HttpResponse();
-        $request  = new HttpRequest();
-
-        $request->header->account = 1;
-        $request->setData('id', '1');
-
-        $this->module->apiTicketElementGet($request, $response);
-        self::assertGreaterThan(0, $response->getDataArray('')['response']->id);
-    }
-
     /**
      * @covers \Modules\Support\Controller\ApiController
      */
diff --git a/tests/Models/NullTicketElementTest.php b/tests/Models/NullTicketElementTest.php
deleted file mode 100755
index 969b7b5..0000000
--- a/tests/Models/NullTicketElementTest.php
+++ /dev/null
@@ -1,44 +0,0 @@
-<?php
-/**
- * Jingga
- *
- * PHP Version 8.2
- *
- * @package   tests
- * @copyright Dennis Eichhorn
- * @license   OMS License 2.0
- * @version   1.0.0
- * @link      https://jingga.app
- */
-declare(strict_types=1);
-
-namespace Modules\Support\tests\Models;
-
-use Modules\Support\Models\NullTicketElement;
-
-/**
- * @internal
- */
-#[\PHPUnit\Framework\Attributes\CoversClass(\Modules\Support\Models\NullTicketElement::class)]
-final class NullTicketElementTest extends \PHPUnit\Framework\TestCase
-{
-    #[\PHPUnit\Framework\Attributes\Group('module')]
-    public function testNull() : void
-    {
-        self::assertInstanceOf('\Modules\Support\Models\TicketElement', new NullTicketElement());
-    }
-
-    #[\PHPUnit\Framework\Attributes\Group('module')]
-    public function testId() : void
-    {
-        $null = new NullTicketElement(2);
-        self::assertEquals(2, $null->id);
-    }
-
-    #[\PHPUnit\Framework\Attributes\Group('module')]
-    public function testJsonSerialize() : void
-    {
-        $null = new NullTicketElement(2);
-        self::assertEquals(['id' => 2], $null->jsonSerialize());
-    }
-}
diff --git a/tests/Models/TicketElementTest.php b/tests/Models/TicketElementTest.php
deleted file mode 100755
index 7505d5a..0000000
--- a/tests/Models/TicketElementTest.php
+++ /dev/null
@@ -1,58 +0,0 @@
-<?php
-/**
- * Jingga
- *
- * PHP Version 8.2
- *
- * @package   tests
- * @copyright Dennis Eichhorn
- * @license   OMS License 2.0
- * @version   1.0.0
- * @link      https://jingga.app
- */
-declare(strict_types=1);
-
-namespace Modules\Support\tests\Models;
-
-use Modules\Support\Models\TicketElement;
-
-/**
- * @internal
- */
-#[\PHPUnit\Framework\Attributes\CoversClass(\Modules\Support\Models\TicketElement::class)]
-final class TicketElementTest extends \PHPUnit\Framework\TestCase
-{
-    private TicketElement $element;
-
-    /**
-     * {@inheritdoc}
-     */
-    protected function setUp() : void
-    {
-        $this->element = new TicketElement();
-    }
-
-    #[\PHPUnit\Framework\Attributes\Group('module')]
-    public function testDefault() : void
-    {
-        self::assertEquals(0, $this->element->id);
-        self::assertEquals(0, $this->element->ticket);
-    }
-
-    #[\PHPUnit\Framework\Attributes\Group('module')]
-    public function testSerialize() : void
-    {
-        $this->element->ticket = 2;
-
-        $serialized = $this->element->jsonSerialize();
-        unset($serialized['taskElement']);
-
-        self::assertEquals(
-            [
-                'id'     => 0,
-                'ticket' => 2,
-            ],
-            $serialized
-        );
-    }
-}
diff --git a/tests/Models/TicketTest.php b/tests/Models/TicketTest.php
index 3c2b92f..b9378a2 100755
--- a/tests/Models/TicketTest.php
+++ b/tests/Models/TicketTest.php
@@ -38,37 +38,10 @@ final class TicketTest extends \PHPUnit\Framework\TestCase
     {
         self::assertEquals(0, $this->ticket->id);
         self::assertNull($this->ticket->task->for);
-        self::assertEquals([], $this->ticket->getTicketElements());
         self::assertInstanceOf('\Modules\Tasks\Models\Task', $this->ticket->task);
-        self::assertInstanceOf('\Modules\Support\Models\TicketElement', $this->ticket->getTicketElement(999));
         self::assertInstanceOf('\Modules\Support\Models\SupportApp', $this->ticket->app);
     }
 
-    #[\PHPUnit\Framework\Attributes\Group('module')]
-    public function testElementInputOutput() : void
-    {
-        $element1 = new TicketElement();
-        $element2 = new TicketElement();
-
-        self::assertEquals(0, $this->ticket->addElement($element1));
-        self::assertEquals(1, $this->ticket->addElement($element2));
-        self::assertCount(2, $this->ticket->getTicketElements());
-        self::assertEquals($element1, $this->ticket->getTicketElement(0));
-        self::assertEquals([$element2, $element1], $this->ticket->invertTicketElements());
-    }
-
-    #[\PHPUnit\Framework\Attributes\Group('module')]
-    public function testElementRemove() : void
-    {
-        $element1 = new TicketElement();
-
-        $this->ticket->addElement($element1);
-        self::assertCount(1, $this->ticket->getTicketElements());
-        self::assertTrue($this->ticket->removeElement(0));
-        self::assertCount(0, $this->ticket->getTicketElements());
-        self::assertFalse($this->ticket->removeElement(0));
-    }
-
     #[\PHPUnit\Framework\Attributes\Group('module')]
     public function testSerialize() : void
     {
@@ -79,7 +52,6 @@ final class TicketTest extends \PHPUnit\Framework\TestCase
         self::assertEquals(
             [
                 'id'             => 0,
-                'ticketElements' => [],
             ],
             $serialized
         );