From 5b7af365ba33fa5da0152b9cd9ac8ad239345c3f Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nnes.com@googlemail.com>
Date: Sun, 24 Sep 2023 14:56:45 +0000
Subject: [PATCH] rector fixes

---
 Controller/ApiController.php         | 2 +-
 Controller/BackendController.php     | 4 +---
 Theme/Backend/support-ticket.tpl.php | 4 ++--
 tests/Bootstrap.php                  | 4 ++--
 4 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/Controller/ApiController.php b/Controller/ApiController.php
index fd19cd2..755f9e0 100755
--- a/Controller/ApiController.php
+++ b/Controller/ApiController.php
@@ -196,7 +196,7 @@ final class ApiController extends Controller
         if (($val['status'] = !TaskStatus::isValidValue((int) $request->getData('status')))
             || ($val['due'] = !((bool) \strtotime((string) $request->getData('due'))))
             || ($val['ticket'] = !(\is_numeric($request->getData('ticket'))))
-            || ($val['forward'] = !(\is_numeric(!$request->hasData('forward') ? $request->header->account : $request->getData('forward'))))
+            || ($val['forward'] = !(\is_numeric($request->hasData('forward') ? $request->getData('forward') : $request->header->account)))
         ) {
             return $val;
         }
diff --git a/Controller/BackendController.php b/Controller/BackendController.php
index 4b261b6..59ec278 100755
--- a/Controller/BackendController.php
+++ b/Controller/BackendController.php
@@ -49,9 +49,7 @@ final class BackendController extends Controller
      */
     public function viewSettings(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : RenderableInterface
     {
-        $view = new View($this->app->l11nManager, $request, $response);
-
-        return $view;
+        return new View($this->app->l11nManager, $request, $response);
     }
 
     /**
diff --git a/Theme/Backend/support-ticket.tpl.php b/Theme/Backend/support-ticket.tpl.php
index 3b7b372..10762d8 100755
--- a/Theme/Backend/support-ticket.tpl.php
+++ b/Theme/Backend/support-ticket.tpl.php
@@ -101,7 +101,7 @@ echo $this->data['nav']->render(); ?>
                             <?php endif; ?>
 
                             <?php $tags = $task->getTags(); foreach ($tags as $tag) : ?>
-                                <span class="tag" style="background: <?= $this->printHtml($tag->color); ?>"><?= !empty($tag->icon) ? '<i class="' . $this->printHtml($tag->icon) . '"></i>' : ''; ?><?= $this->printHtml($tag->getL11n()); ?></span>
+                                <span class="tag" style="background: <?= $this->printHtml($tag->color); ?>"><?= empty($tag->icon) ? '' : '<i class="' . $this->printHtml($tag->icon) . '"></i>'; ?><?= $this->printHtml($tag->getL11n()); ?></span>
                             <?php endforeach; ?>
                         </div>
                     </div>
@@ -369,7 +369,7 @@ echo $this->data['nav']->render(); ?>
                             <div class="form-group">
                                 <label for="iDue"><?= $this->getHtml('Due'); ?></label>
                                 <input type="datetime-local" id="iDue" name="due" value="<?= $this->printHtml(
-                                        !empty($elements) ? \end($elements)->taskElement->due->format('Y-m-d\TH:i:s') : $task->due->format('Y-m-d\TH:i:s')
+                                        empty($elements) ? $task->due->format('Y-m-d\TH:i:s') : \end($elements)->taskElement->due->format('Y-m-d\TH:i:s')
                                     ); ?>">
                             </div>
                         </div>
diff --git a/tests/Bootstrap.php b/tests/Bootstrap.php
index b904f0c..44438e2 100755
--- a/tests/Bootstrap.php
+++ b/tests/Bootstrap.php
@@ -381,7 +381,7 @@ function phpServe() : void
 
     // Execute the command and store the process ID
     $output = [];
-    echo \sprintf('Starting server...') . \PHP_EOL;
+    echo 'Starting server...' . \PHP_EOL;
     echo \sprintf(' Current directory: %s', \getcwd()) . \PHP_EOL;
     echo \sprintf(' %s', $command);
     \exec($command, $output);
@@ -406,7 +406,7 @@ function phpServe() : void
 
     // Kill the web server when the process ends
     \register_shutdown_function(function() use ($killCommand, $pid) : void {
-        echo \PHP_EOL . \sprintf('Stopping server...') . \PHP_EOL;
+        echo \PHP_EOL . 'Stopping server...' . \PHP_EOL;
         echo \sprintf(' %s - Killing process with ID %d', \date('r'), $pid) . \PHP_EOL;
         \exec($killCommand . $pid);
     });