Test fixes
Some checks failed
Image optimization / general_image_workflow (push) Has been cancelled
CI / general_module_workflow_php (push) Has been cancelled
CI / general_module_workflow_js (push) Has been cancelled

This commit is contained in:
Dennis Eichhorn 2024-05-16 02:14:55 +00:00
parent de0445b026
commit 5ab5247fc5
6 changed files with 15 additions and 13 deletions

View File

@ -12,7 +12,7 @@
},
"creator": {
"name": "Jingga",
"website": "jingga.app"
"website": "https://jingga.app"
},
"description": "The shop application.",
"directory": "Shop",

View File

@ -26,7 +26,6 @@ use Modules\Support\Models\TicketMapper;
use Modules\Tasks\Models\TaskElementMapper;
use Modules\Tasks\Models\TaskMapper;
use Modules\Tasks\Models\TaskStatus;
use Modules\Tasks\Models\TaskType;
use phpOMS\Message\Http\RequestStatusCode;
use phpOMS\Message\RequestAbstract;
use phpOMS\Message\ResponseAbstract;
@ -393,7 +392,11 @@ final class ApiController extends Controller
$this->app->moduleManager->get('Tasks')->apiTaskElementSet($request, $response);
/** @var \Modules\Tasks\Models\TaskElement $new */
$new = $response->getDataArray($request->uri->__toString())['response'];
$new = $response->getDataArray($request->uri->__toString())['response'] ?? null;
if ($new === null) {
$response->header->status = RequestStatusCode::R_400;
$this->createInvalidUpdateResponse($request, $response, $new);
}
$ticket = TicketMapper::get()
->with('task')
@ -503,7 +506,12 @@ final class ApiController extends Controller
}
/** @var \Modules\Editor\Models\EditorDoc $model */
$model = $response->getDataArray($request->uri->__toString())['response'];
$model = $response->getDataArray($request->uri->__toString())['response'] ?? null;
if ($model === null) {
$response->header->status = RequestStatusCode::R_400;
$this->createInvalidUpdateResponse($request, $response, $model);
}
$this->createModelRelation($request->header->account, $request->getDataInt('id'), $model->id, TicketMapper::class, 'notes', '', $request->getOrigin());
}

View File

@ -1,5 +0,0 @@
# Structure
## ER
![ER](Modules/Support/Docs/Dev/img/er.png)

Binary file not shown.

Before

Width:  |  Height:  |  Size: 162 KiB

View File

@ -12,7 +12,7 @@
},
"creator": {
"name": "Jingga",
"website": "jingga.app"
"website": "https://jingga.app"
},
"description": "Support module.",
"directory": "Support",

View File

@ -15,7 +15,6 @@ declare(strict_types=1);
namespace Modules\Support\tests\Models;
use Modules\Support\Models\Ticket;
use Modules\Support\Models\TicketElement;
/**
* @internal