From 17ac2139a3fc81158754f278da2bf55a85ceac35 Mon Sep 17 00:00:00 2001
From: Dennis Eichhorn <spl1nes.com@googlemail.com>
Date: Sun, 30 Aug 2020 20:13:11 +0200
Subject: [PATCH] autofixes

---
 Models/PermissionState.php          |  3 +++
 Theme/Backend/support-list.tpl.php  | 42 ++++++++++++++---------------
 Theme/Backend/ticket-single.tpl.php | 18 ++++++-------
 tests/Admin/AdminTest.php           |  1 +
 4 files changed, 34 insertions(+), 30 deletions(-)

diff --git a/Models/PermissionState.php b/Models/PermissionState.php
index 5f43221..e9e86c6 100644
--- a/Models/PermissionState.php
+++ b/Models/PermissionState.php
@@ -27,7 +27,10 @@ use phpOMS\Stdlib\Base\Enum;
 abstract class PermissionState extends Enum
 {
     public const SUPPORT   = 1;
+
     public const ANALYSIS  = 2;
+
     public const SETTINGS  = 3;
+
     public const DASHBOARD = 4;
 }
diff --git a/Theme/Backend/support-list.tpl.php b/Theme/Backend/support-list.tpl.php
index 6a82a83..0343251 100644
--- a/Theme/Backend/support-list.tpl.php
+++ b/Theme/Backend/support-list.tpl.php
@@ -22,14 +22,14 @@ echo $this->getData('nav')->render(); ?>
 <div class="row">
     <div class="col-xs-12 col-md-9">
         <section class="portlet">
-            <div class="portlet-head"><?= $this->getHtml('Tickets') ?><i class="fa fa-download floatRight download btn"></i></div>
+            <div class="portlet-head"><?= $this->getHtml('Tickets'); ?><i class="fa fa-download floatRight download btn"></i></div>
             <table class="default">
                 <thead>
-                    <td><?= $this->getHtml('Status') ?>
-                    <td><?= $this->getHtml('Due') ?>
-                    <td class="full"><?= $this->getHtml('Title') ?>
-                    <td><?= $this->getHtml('Creator') ?>
-                    <td><?= $this->getHtml('Created') ?>
+                    <td><?= $this->getHtml('Status'); ?>
+                    <td><?= $this->getHtml('Due'); ?>
+                    <td class="full"><?= $this->getHtml('Title'); ?>
+                    <td><?= $this->getHtml('Creator'); ?>
+                    <td><?= $this->getHtml('Created'); ?>
                 <tfoot>
                 <tbody>
                 <?php $c = 0; foreach ($tickets as $key => $ticket) : ++$c;
@@ -41,7 +41,7 @@ echo $this->getData('nav')->render(); ?>
                 elseif ($ticket->getTask()->getStatus() === \Modules\Tasks\Models\TaskStatus::CANCELED) { $color = 'red'; }
                 elseif ($ticket->getTask()->getStatus() === \Modules\Tasks\Models\TaskStatus::SUSPENDED) { $color = 'yellow'; } ?>
                     <tr data-href="<?= $url; ?>">
-                        <td><a href="<?= $url; ?>"><span class="tag <?= $this->printHtml($color); ?>"><?= $this->getHtml('S' . $ticket->getTask()->getStatus(), 'Tasks') ?></span></a>
+                        <td><a href="<?= $url; ?>"><span class="tag <?= $this->printHtml($color); ?>"><?= $this->getHtml('S' . $ticket->getTask()->getStatus(), 'Tasks'); ?></span></a>
                         <td><a href="<?= $url; ?>"><?= $this->printHtml($ticket->getTask()->getDue()->format('Y-m-d H:i')); ?></a>
                         <td><a href="<?= $url; ?>"><?= $this->printHtml($ticket->getTask()->getTitle()); ?></a>
                         <td><a href="<?= $url; ?>"><?= $this->printHtml($ticket->getTask()->getCreatedBy()->getName1()); ?></a>
@@ -55,17 +55,17 @@ echo $this->getData('nav')->render(); ?>
 
     <div class="col-xs-12 col-md-3">
         <section class="portlet">
-            <div class="portlet-head"><?= $this->getHtml('Settings') ?></div>
+            <div class="portlet-head"><?= $this->getHtml('Settings'); ?></div>
             <div class="portlet-body">
                 <form>
                     <table class="layout wf-100">
-                        <tr><td><label for="iIntervarl"><?= $this->getHtml('Interval') ?></label>
+                        <tr><td><label for="iIntervarl"><?= $this->getHtml('Interval'); ?></label>
                         <tr><td><select id="iIntervarl" name="interval">
-                                    <option><?= $this->getHtml('All') ?>
-                                    <option><?= $this->getHtml('Day') ?>
-                                    <option><?= $this->getHtml('Week') ?>
-                                    <option selected><?= $this->getHtml('Month') ?>
-                                    <option><?= $this->getHtml('Year') ?>
+                                    <option><?= $this->getHtml('All'); ?>
+                                    <option><?= $this->getHtml('Day'); ?>
+                                    <option><?= $this->getHtml('Week'); ?>
+                                    <option selected><?= $this->getHtml('Month'); ?>
+                                    <option><?= $this->getHtml('Year'); ?>
                                 </select>
                     </table>
                 </form>
@@ -73,15 +73,15 @@ echo $this->getData('nav')->render(); ?>
         </section>
 
         <section class="portlet">
-            <div class="portlet-head"><?= $this->getHtml('Settings') ?></div>
+            <div class="portlet-head"><?= $this->getHtml('Settings'); ?></div>
             <div class="portlet-body">
                 <table class="list">
-                    <tr><th><?= $this->getHtml('Received') ?><td>0
-                    <tr><th><?= $this->getHtml('Created') ?><td>0
-                    <tr><th><?= $this->getHtml('Forwarded') ?><td>0
-                    <tr><th><?= $this->getHtml('AverageAmount') ?><td>0
-                    <tr><th><?= $this->getHtml('AverageProcessTime') ?><td>0
-                    <tr><th><?= $this->getHtml('InTime') ?><td>0
+                    <tr><th><?= $this->getHtml('Received'); ?><td>0
+                    <tr><th><?= $this->getHtml('Created'); ?><td>0
+                    <tr><th><?= $this->getHtml('Forwarded'); ?><td>0
+                    <tr><th><?= $this->getHtml('AverageAmount'); ?><td>0
+                    <tr><th><?= $this->getHtml('AverageProcessTime'); ?><td>0
+                    <tr><th><?= $this->getHtml('InTime'); ?><td>0
                 </table>
             </div>
         </section>
diff --git a/Theme/Backend/ticket-single.tpl.php b/Theme/Backend/ticket-single.tpl.php
index a17ddf8..f8da40b 100644
--- a/Theme/Backend/ticket-single.tpl.php
+++ b/Theme/Backend/ticket-single.tpl.php
@@ -43,7 +43,7 @@ echo $this->getData('nav')->render(); ?>
             <div class="inner">
                 <div class="pAlignTable">
                     <div class="vC wf-100">Created <?= $this->printHtml($ticket->getTask()->getCreatedBy()->getName1()); ?></div>
-                    <span class="vC nobreak tag"><?= $this->getHtml('S' . $ticket->getTask()->getStatus()) ?></span>
+                    <span class="vC nobreak tag"><?= $this->getHtml('S' . $ticket->getTask()->getStatus()); ?></span>
                 </div>
             </div>
         </section>
@@ -58,7 +58,7 @@ echo $this->getData('nav')->render(); ?>
             <section class="box wf-100">
                 <div class="inner pAlignTable">
                     <div class="vC wf-100"><?= $this->printHtml($element->getCreatedBy()->getName1()); ?> - <?= $this->printHtml($element->getCreatedAt()->format('Y-m-d H:i')); ?></div>
-                    <span class="vC tag <?= $this->printHtml($color); ?>"><?= $this->getHtml('S' . $element->getStatus()) ?></span>
+                    <span class="vC tag <?= $this->printHtml($color); ?>"><?= $this->getHtml('S' . $element->getStatus()); ?></span>
                 </div>
 
             <?php if ($element->getDescription() !== '') : ?>
@@ -86,11 +86,11 @@ echo $this->getData('nav')->render(); ?>
             <div class="inner">
                 <form id="taskElementCreate" method="POST" action="<?= \phpOMS\Uri\UriFactory::build('{/api}task/element?{?}&csrf={$CSRF}'); ?>">
                     <table class="layout wf-100">
-                        <tr><td><label for="iMessage"><?= $this->getHtml('Message') ?></label>
+                        <tr><td><label for="iMessage"><?= $this->getHtml('Message'); ?></label>
                         <tr><td><textarea id="iMessage" name="description"></textarea>
-                        <tr><td><label for="iDue"><?= $this->getHtml('Due') ?></label>
+                        <tr><td><label for="iDue"><?= $this->getHtml('Due'); ?></label>
                         <tr><td><input type="datetime-local" id="iDue" name="due" value="<?= $this->printHtml(!empty($elements) ? \end($elements)->getDue()->format('Y-m-d\TH:i:s') : $ticket->getTask()->getDue()->format('Y-m-d\TH:i:s')); ?>">
-                        <tr><td><label for="iStatus"><?= $this->getHtml('Status') ?></label>
+                        <tr><td><label for="iStatus"><?= $this->getHtml('Status'); ?></label>
                         <tr><td><select id="iStatus" name="status">
                                     <option value="<?= $this->printHtml(\Modules\Tasks\Models\TaskStatus::OPEN); ?>" selected>Open
                                     <option value="<?= $this->printHtml(\Modules\Tasks\Models\TaskStatus::WORKING); ?>">Working
@@ -98,11 +98,11 @@ echo $this->getData('nav')->render(); ?>
                                     <option value="<?= $this->printHtml(\Modules\Tasks\Models\TaskStatus::CANCELED); ?>">Canceled
                                     <option value="<?= $this->printHtml(\Modules\Tasks\Models\TaskStatus::DONE); ?>">Done
                                 </select>
-                        <tr><td><label for="iReceiver"><?= $this->getHtml('To') ?></label>
+                        <tr><td><label for="iReceiver"><?= $this->getHtml('To'); ?></label>
                         <tr><td><input type="text" id="iReceiver" name="forward" value="<?= $this->printHtml($this->request->getHeader()->getAccount()); ?>" placeholder="&#xf007; Guest">
-                        <tr><td colspan="2"><label for="iMedia"><?= $this->getHtml('Media') ?></label>
-                        <tr><td><input type="text" id="iMedia" placeholder="&#xf15b; File"><td><button><?= $this->getHtml('Select') ?></button>
-                        <tr><td colspan="2"><label for="iUpload"><?= $this->getHtml('Upload') ?></label>
+                        <tr><td colspan="2"><label for="iMedia"><?= $this->getHtml('Media'); ?></label>
+                        <tr><td><input type="text" id="iMedia" placeholder="&#xf15b; File"><td><button><?= $this->getHtml('Select'); ?></button>
+                        <tr><td colspan="2"><label for="iUpload"><?= $this->getHtml('Upload'); ?></label>
                         <tr><td><input type="file" id="iUpload" form="fTask"><input form="fTask" type="hidden" name="type"><td>
                         <tr><td><input type="submit" value="<?= $this->getHtml('Create', '0', '0'); ?>"><input type="hidden" name="task" value="<?= $this->printHtml($this->request->getData('id')); ?>"><input type="hidden" name="type" value="1">
                     </table>
diff --git a/tests/Admin/AdminTest.php b/tests/Admin/AdminTest.php
index 081904e..f13e623 100644
--- a/tests/Admin/AdminTest.php
+++ b/tests/Admin/AdminTest.php
@@ -20,6 +20,7 @@ namespace Modules\Support\tests\Admin;
 class AdminTest extends \PHPUnit\Framework\TestCase
 {
     protected const MODULE_NAME = 'Support';
+
     protected const URI_LOAD = '';
 
     use \Modules\tests\ModuleTestTrait;