Jingga/oms-SupplierManagement
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-SupplierManagement.git synced 2026-02-17 17:08:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix phpstan/phpcs

Browse Source
This commit is contained in:
Dennis Eichhorn 2021-06-26 14:38:08 +02:00
parent 06cf2797c4
commit 5032cf7541
5 changed files with 18 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Controller/ApiController.php
View File

@ -201,10 +201,10 @@ final class ApiController extends Controller
*/ */
private function createSupplierAttributeFromRequest(RequestAbstract $request) : SupplierAttribute private function createSupplierAttributeFromRequest(RequestAbstract $request) : SupplierAttribute
{ {
$attribute = new SupplierAttribute(); $attribute = new SupplierAttribute();
$attribute->supplier = (int) $request->getData('supplier'); $attribute->supplier = (int) $request->getData('supplier');
$attribute->type = new NullSupplierAttributeType((int) $request->getData('type')); $attribute->type = new NullSupplierAttributeType((int) $request->getData('type'));
$attribute->value = new NullSupplierAttributeValue((int) $request->getData('value')); $attribute->value = new NullSupplierAttributeValue((int) $request->getData('value'));
return $attribute; return $attribute;
} }

12
Models/SupplierAttributeType.php
View File

@ -68,9 +68,7 @@ class SupplierAttributeType implements \JsonSerializable, ArrayableInterface
* *
* @var string | SupplierAttributeTypeL11n * @var string | SupplierAttributeTypeL11n
*/ */
protected string | protected string|SupplierAttributeTypeL11n $l11n;
SupplierAttributeTypeL11n $l11n;
/** /**
* Possible default attribute values * Possible default attribute values
@ -113,16 +111,16 @@ class SupplierAttributeType implements \JsonSerializable, ArrayableInterface
* *
* @since 1.0.0 * @since 1.0.0
*/ */
public function setL11n($l11n, string $lang = ISO639x1Enum::_EN) : void public function setL11n(string|SupplierAttributeTypeL11n $l11n, string $lang = ISO639x1Enum::_EN) : void
{ {
if ($l11n instanceof SupplierAttributeTypeL11n) { if ($l11n instanceof SupplierAttributeTypeL11n) {
$this->l11n = $l11n; $this->l11n = $l11n;
} elseif (\is_string($l11n)) { } elseif ($this->l11n instanceof SupplierAttributeTypeL11n) {
$this->l11n->title = $l11n;
} else {
$this->l11n = new SupplierAttributeTypeL11n(); $this->l11n = new SupplierAttributeTypeL11n();
$this->l11n->title = $l11n; $this->l11n->title = $l11n;
$this->l11n->setLanguage($lang); $this->l11n->setLanguage($lang);
} elseif ($this->l11n instanceof SupplierAttributeTypeL11n && \is_string($l11n)) {
$this->l11n->title = $l11n;
} }
} }

4
Models/SupplierAttributeTypeL11n.php
View File

@ -41,9 +41,7 @@ class SupplierAttributeTypeL11n implements \JsonSerializable, ArrayableInterface
* @var int|SupplierAttributeType * @var int|SupplierAttributeType
* @since 1.0.0 * @since 1.0.0
*/ */
protected int | protected int|SupplierAttributeType $type = 0;
SupplierAttributeType $type = 0;
/** /**
* Language. * Language.

7
Models/SupplierAttributeValue.php
View File

@ -153,6 +153,13 @@ class SupplierAttributeValue implements \JsonSerializable, ArrayableInterface
} }
} }
/**
* Get value
*
* @return null|int|string|float|\DateTimeInterface
*
* @since 1.0.0
*/
public function getValue() : mixed public function getValue() : mixed
{ {
if (!empty($this->valueStr)) { if (!empty($this->valueStr)) {

2
composer.json
View File

@ -9,7 +9,7 @@
], ],
"require-dev": { "require-dev": {
"phpunit/phpunit": ">=9.4", "phpunit/phpunit": ">=9.4",
"friendsofphp/php-cs-fixer": ">=2.18", "friendsofphp/php-cs-fixer": ">=3.0",
"squizlabs/php_codesniffer": ">=3.5", "squizlabs/php_codesniffer": ">=3.5",
"phpmd/phpmd": ">=2.9", "phpmd/phpmd": ">=2.9",
"phpstan/phpstan": ">=0.12.58", "phpstan/phpstan": ">=0.12.58",