Jingga/oms-SupplierManagement
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-SupplierManagement.git synced 2026-02-17 17:08:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

use direct data access for response data

Browse Source
This commit is contained in:
Dennis Eichhorn 2023-05-30 03:42:51 +02:00
parent 2a6958b3e9
commit 1086f9bd9a
3 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Controller/ApiController.php
View File

@ -68,7 +68,7 @@ final class ApiController extends Controller
public function apiSupplierCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void public function apiSupplierCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{ {
if (!empty($val = $this->validateSupplierCreate($request))) { if (!empty($val = $this->validateSupplierCreate($request))) {
$response->set('supplier_create', new FormValidation($val)); $response->data['supplier_create'] = new FormValidation($val);
$response->header->status = RequestStatusCode::R_400; $response->header->status = RequestStatusCode::R_400;
return; return;
@ -148,7 +148,7 @@ final class ApiController extends Controller
public function apiSupplierL11nCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void public function apiSupplierL11nCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{ {
if (!empty($val = $this->validateSupplierL11nCreate($request))) { if (!empty($val = $this->validateSupplierL11nCreate($request))) {
$response->set('supplier_l11n_create', new FormValidation($val)); $response->data['supplier_l11n_create'] = new FormValidation($val);
$response->header->status = RequestStatusCode::R_400; $response->header->status = RequestStatusCode::R_400;
return; return;
@ -219,7 +219,7 @@ final class ApiController extends Controller
public function apiSupplierL11nTypeCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void public function apiSupplierL11nTypeCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{ {
if (!empty($val = $this->validateSupplierL11nTypeCreate($request))) { if (!empty($val = $this->validateSupplierL11nTypeCreate($request))) {
$response->set('supplier_l11n_type_create', new FormValidation($val)); $response->data['supplier_l11n_type_create'] = new FormValidation($val);
$response->header->status = RequestStatusCode::R_400; $response->header->status = RequestStatusCode::R_400;
return; return;
@ -283,7 +283,7 @@ final class ApiController extends Controller
public function apiSupplierAttributeCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void public function apiSupplierAttributeCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{ {
if (!empty($val = $this->validateSupplierAttributeCreate($request))) { if (!empty($val = $this->validateSupplierAttributeCreate($request))) {
$response->set('attribute_create', new FormValidation($val)); $response->data['attribute_create'] = new FormValidation($val);
$response->header->status = RequestStatusCode::R_400; $response->header->status = RequestStatusCode::R_400;
return; return;
@ -351,7 +351,7 @@ final class ApiController extends Controller
public function apiSupplierAttributeTypeL11nCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void public function apiSupplierAttributeTypeL11nCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{ {
if (!empty($val = $this->validateSupplierAttributeTypeL11nCreate($request))) { if (!empty($val = $this->validateSupplierAttributeTypeL11nCreate($request))) {
$response->set('attr_type_l11n_create', new FormValidation($val)); $response->data['attr_type_l11n_create'] = new FormValidation($val);
$response->header->status = RequestStatusCode::R_400; $response->header->status = RequestStatusCode::R_400;
return; return;
@ -420,7 +420,7 @@ final class ApiController extends Controller
public function apiSupplierAttributeTypeCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void public function apiSupplierAttributeTypeCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{ {
if (!empty($val = $this->validateSupplierAttributeTypeCreate($request))) { if (!empty($val = $this->validateSupplierAttributeTypeCreate($request))) {
$response->set('attr_type_create', new FormValidation($val)); $response->data['attr_type_create'] = new FormValidation($val);
$response->header->status = RequestStatusCode::R_400; $response->header->status = RequestStatusCode::R_400;
return; return;
@ -491,7 +491,7 @@ final class ApiController extends Controller
public function apiSupplierAttributeValueCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void public function apiSupplierAttributeValueCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{ {
if (!empty($val = $this->validateSupplierAttributeValueCreate($request))) { if (!empty($val = $this->validateSupplierAttributeValueCreate($request))) {
$response->set('attr_value_create', new FormValidation($val)); $response->data['attr_value_create'] = new FormValidation($val);
$response->header->status = RequestStatusCode::R_400; $response->header->status = RequestStatusCode::R_400;
return; return;
@ -576,7 +576,7 @@ final class ApiController extends Controller
public function apiSupplierAttributeValueL11nCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void public function apiSupplierAttributeValueL11nCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{ {
if (!empty($val = $this->validateSupplierAttributeValueL11nCreate($request))) { if (!empty($val = $this->validateSupplierAttributeValueL11nCreate($request))) {
$response->set('attr_value_l11n_create', new FormValidation($val)); $response->data['attr_value_l11n_create'] = new FormValidation($val);
$response->header->status = RequestStatusCode::R_400; $response->header->status = RequestStatusCode::R_400;
return; return;
@ -644,7 +644,7 @@ final class ApiController extends Controller
*/ */
public function apiFileCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void public function apiFileCreate(RequestAbstract $request, ResponseAbstract $response, mixed $data = null) : void
{ {
$uploadedFiles = $request->getFiles(); $uploadedFiles = $request->files;
if (empty($uploadedFiles)) { if (empty($uploadedFiles)) {
$this->fillJsonResponse($request, $response, NotificationLevel::ERROR, 'Item', 'Invalid supplier image', $uploadedFiles); $this->fillJsonResponse($request, $response, NotificationLevel::ERROR, 'Item', 'Invalid supplier image', $uploadedFiles);

2
Theme/Backend/supplier-profile.tpl.php
View File

@ -23,7 +23,7 @@ $countries = \phpOMS\Localization\ISO3166NameEnum::getConstants();
*/ */
$supplier = $this->getData('supplier'); $supplier = $this->getData('supplier');
$notes = $supplier->getNotes(); $notes = $supplier->getNotes();
$files = $supplier->getFiles(); $files = $supplier->files;
$newestInvoices = $this->getData('newestInvoices') ?? []; $newestInvoices = $this->getData('newestInvoices') ?? [];
$monthlyPurchaseCosts = $this->getData('monthlyPurchaseCosts') ?? []; $monthlyPurchaseCosts = $this->getData('monthlyPurchaseCosts') ?? [];

4
tests/Models/SupplierTest.php
View File

@ -48,7 +48,7 @@ final class SupplierTest extends \PHPUnit\Framework\TestCase
self::assertEquals(SupplierStatus::ACTIVE, $this->supplier->getStatus()); self::assertEquals(SupplierStatus::ACTIVE, $this->supplier->getStatus());
self::assertEquals(0, $this->supplier->getType()); self::assertEquals(0, $this->supplier->getType());
self::assertEquals([], $this->supplier->getNotes()); self::assertEquals([], $this->supplier->getNotes());
self::assertEquals([], $this->supplier->getFiles()); self::assertEquals([], $this->supplier->files);
self::assertEquals([], $this->supplier->getAddresses()); self::assertEquals([], $this->supplier->getAddresses());
self::assertEquals([], $this->supplier->getContactElements()); self::assertEquals([], $this->supplier->getContactElements());
self::assertEquals((new \DateTime('now'))->format('Y-m-d'), $this->supplier->createdAt->format('Y-m-d')); self::assertEquals((new \DateTime('now'))->format('Y-m-d'), $this->supplier->createdAt->format('Y-m-d'));
@ -84,7 +84,7 @@ final class SupplierTest extends \PHPUnit\Framework\TestCase
public function testFileInputOutput() : void public function testFileInputOutput() : void
{ {
$this->supplier->addFile($temp = new Media()); $this->supplier->addFile($temp = new Media());
self::assertCount(1, $this->supplier->getFiles()); self::assertCount(1, $this->supplier->files);
} }
/** /**