From bd291f26aa95b91008564a4002efb11b660a57ca Mon Sep 17 00:00:00 2001 From: Dennis Eichhorn Date: Fri, 8 Dec 2023 21:52:33 +0000 Subject: [PATCH] bug fixes --- Controller/ApiController.php | 10 +++++----- ICAL.txt | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Controller/ApiController.php b/Controller/ApiController.php index e8e31ea..e7657ca 100755 --- a/Controller/ApiController.php +++ b/Controller/ApiController.php @@ -15,7 +15,6 @@ declare(strict_types=1); namespace Modules\Shop\Controller; use Modules\Admin\Models\AccountMapper; -use Modules\Admin\Models\NullAddress; use Modules\Billing\Models\BillMapper; use Modules\Billing\Models\BillStatus; use Modules\ClientManagement\Models\ClientMapper; @@ -30,6 +29,7 @@ use phpOMS\Message\Http\HttpResponse; use phpOMS\Message\Http\RequestStatusCode; use phpOMS\Message\RequestAbstract; use phpOMS\Message\ResponseAbstract; +use phpOMS\Stdlib\Base\NullAddress; use phpOMS\System\MimeType; /** @@ -79,13 +79,13 @@ final class ApiController extends Controller } // Handle private files - // @todo: this is another example where it would be useful to have clients and items as models in the bill and bill element + // @todo this is another example where it would be useful to have clients and items as models in the bill and bill element /** @var \Modules\ClientManagement\Models\Client $client */ $client = ClientMapper::get() ->where('account', $request->header->account) ->execute(); - // @todo: only for sales invoice, currently also for offers + // @todo only for sales invoice, currently also for offers /** @var \Modules\Billing\Models\Bill[] $bills */ $bills = BillMapper::getAll() ->with('elements') @@ -326,7 +326,7 @@ final class ApiController extends Controller ->where('id', $request->header->account) ->execute(); - // @todo: what if the primary address is not in position 1? + // @todo what if the primary address is not in position 1? $address = \reset($account->locations); $address = $address === false ? new NullAddress() : $address; @@ -391,7 +391,7 @@ final class ApiController extends Controller /** @var \Modules\ItemManagement\Models\Item $item */ $item = $itemMapper->execute(); - // @todo: consider to first create an offer = cart and only when paid turn it into an invoice. This way it's also easy to analyse the conversion rate. + // @todo consider to first create an offer = cart and only when paid turn it into an invoice. This way it's also easy to analyse the conversion rate. $billElement = $this->app->moduleManager->get('Billing', 'ApiBill')->createBaseBillElement($client, $item, $bill, $request); $bill->addElement($billElement); diff --git a/ICAL.txt b/ICAL.txt index 019045f..f1b55ed 100755 --- a/ICAL.txt +++ b/ICAL.txt @@ -1,6 +1,6 @@ # Individual Contributor License Agreement ("CLA") 1.0 -Thank you for your interest in Karaka-Management (the "Company"). In order to clarify the intellectual property license granted with Contributions from any person or entity, the Company must provide a Contributor License Agreement ("CLA") on file that has been made available to each Contributor. This license is for your protection as a Contributor as well as the protection of the Company and its users; it does not change your rights to use your own Contributions for any other purpose. +Thank you for your interest in Jingga e. K. (the "Company"). In order to clarify the intellectual property license granted with Contributions from any person or entity, the Company must provide a Contributor License Agreement ("CLA") on file that has been made available to each Contributor. This license is for your protection as a Contributor as well as the protection of the Company and its users; it does not change your rights to use your own Contributions for any other purpose. By contributing to the Company You accept and agree to the following terms and conditions for Your present and future Contributions submitted to the Company. In return, the Company shall not use Your Contributions in a way that is contrary to the public benefit or inconsistent with its bylaws in effect at the time of the Contribution. Except for the license granted herein to the Company and recipients of software distributed by the Company, You reserve all right, title, and interest in and to Your Contributions.