Jingga/oms-Shop
1
0
Fork 0
mirror of https://github.com/Karaka-Management/oms-Shop.git synced 2026-02-13 08:38:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

continue optimizing todos

Browse Source
This commit is contained in:
Dennis Eichhorn 2020-01-05 21:38:42 +01:00
parent 1b651837ab
commit bb3bbebf00
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Admin/Install/Application/Shop/Application.php
View File

@ -24,6 +24,7 @@ use Modules\Profile\Models\ProfileMapper;
use phpOMS\Account\Account; use phpOMS\Account\Account;
use phpOMS\Account\AccountManager; use phpOMS\Account\AccountManager;
use phpOMS\Account\NullAccount; use phpOMS\Account\NullAccount;
use phpOMS\Account\PermissionType;
use phpOMS\Asset\AssetType; use phpOMS\Asset\AssetType;
use phpOMS\Auth\Auth; use phpOMS\Auth\Auth;
use phpOMS\DataStorage\Cache\CachePool; use phpOMS\DataStorage\Cache\CachePool;
@ -212,16 +213,11 @@ final class Application
} }
/* No reading permission */ /* No reading permission */
/** todo: fix by checking for special permission like read, orgid, appname, ...., component = login must be set if (!$account->hasPermission(PermissionType::READ, $this->app->orgId, $this->app->appName, 'Dashboard')) {
* the current solution is bad because if a user has read, orgid, appname he can read everything so you don't
* want to give this to users. if i don't understand what this means at a later stage... just trust me future me.
* create a permission e.g. 1, Shop, ...., 1 which will be the login permission and check it below.
*/
/*if (!$account->hasPermission(PermissionType::READ, $this->app->orgId, $this->app->appName)) {
$this->create403Response($response, $pageView); $this->create403Response($response, $pageView);
return; return;
}*/ }
$this->app->moduleManager->initRequestModules($request); $this->app->moduleManager->initRequestModules($request);
$this->createDefaultPageView($request, $response, $pageView); $this->createDefaultPageView($request, $response, $pageView);