diff --git a/Controller/ApiController.php b/Controller/ApiController.php index d52ab98..b44e87b 100755 --- a/Controller/ApiController.php +++ b/Controller/ApiController.php @@ -92,7 +92,7 @@ final class ApiController extends Controller $isExport = \in_array($request->getData('type'), ['xlsx', 'pdf', 'docx', 'pptx', 'csv', 'json']); // is allowed to read - if (!$this->app->accountManager->get($accountId)->hasPermission(PermissionType::READ, $this->app->unitId, null, self::NAME, PermissionCategory::REPORT, $template->getId()) + if (!$this->app->accountManager->get($accountId)->hasPermission(PermissionType::READ, $this->app->unitId, null, self::NAME, PermissionCategory::REPORT, $template->id) || ($isExport && !$this->app->accountManager->get($accountId)->hasPermission(PermissionType::READ, $this->app->unitId, $this->app->appId, self::NAME, PermissionCategory::EXPORT)) ) { $response->header->status = RequestStatusCode::R_403; @@ -354,7 +354,7 @@ final class ApiController extends Controller ->with('template') ->with('source') ->with('source/sources') - ->where('template', $template->getId()) + ->where('template', $template->id) ->sort('id', OrderType::DESC) ->limit(1) ->execute(); @@ -362,7 +362,7 @@ final class ApiController extends Controller $rcoll = []; $report = $report === false ? new NullReport() : $report; - if (!($report instanceof NullReport)) { + if ($report->id > 0) { $files = $report->source->getSources(); foreach ($files as $media) { @@ -429,7 +429,7 @@ final class ApiController extends Controller ); foreach ($uploaded as $upload) { - if ($upload instanceof NullMedia) { + if ($upload->id === 0) { continue; } @@ -448,7 +448,7 @@ final class ApiController extends Controller $request->header->account ); - if ($collection instanceof NullCollection) { + if ($collection->id === 0) { $response->header->status = RequestStatusCode::R_403; $this->fillJsonResponse($request, $response, NotificationLevel::ERROR, 'Template', 'Couldn\'t create collection for template', null); @@ -460,7 +460,7 @@ final class ApiController extends Controller $this->createModel($request->header->account, $collection, CollectionMapper::class, 'collection', $request->getOrigin()); - $template = $this->createTemplateFromRequest($request, $collection->getId()); + $template = $this->createTemplateFromRequest($request, $collection->id); $this->app->moduleManager->get('Admin')->createAccountModelPermission( new AccountPermission( @@ -470,7 +470,7 @@ final class ApiController extends Controller self::NAME, self::NAME, PermissionCategory::TEMPLATE, - $template->getId(), + $template->id, null, PermissionType::READ | PermissionType::MODIFY | PermissionType::DELETE | PermissionType::PERMISSION, ), @@ -601,7 +601,7 @@ final class ApiController extends Controller $collection->setPath('/Modules/Media/Files/Modules/Helper/' . ($request->getDataString('name') ?? '')); $collection->setVirtualPath('/Modules/Helper'); - if ($collection instanceof NullCollection) { + if ($collection->id === 0) { $response->header->status = RequestStatusCode::R_403; $this->fillJsonResponse($request, $response, NotificationLevel::ERROR, 'Report', 'Couldn\'t create collection for report', null); @@ -610,7 +610,7 @@ final class ApiController extends Controller $this->createModel($request->header->account, $collection, CollectionMapper::class, 'collection', $request->getOrigin()); - $report = $this->createReportFromRequest($request, $response, $collection->getId()); + $report = $this->createReportFromRequest($request, $response, $collection->id); $this->app->moduleManager->get('Admin')->createAccountModelPermission( new AccountPermission( @@ -620,7 +620,7 @@ final class ApiController extends Controller self::NAME, self::NAME, PermissionCategory::REPORT, - $report->getId(), + $report->id, null, PermissionType::READ | PermissionType::MODIFY | PermissionType::DELETE | PermissionType::PERMISSION, ), diff --git a/Controller/BackendController.php b/Controller/BackendController.php index f601973..3d9147e 100755 --- a/Controller/BackendController.php +++ b/Controller/BackendController.php @@ -205,13 +205,13 @@ final class BackendController extends Controller } /** @var \Modules\Helper\Models\Report[] $report */ - $report = ReportMapper::get()->where('template', $template->getId())->sort('id', OrderType::DESC)->limit(1)->execute(); + $report = ReportMapper::get()->where('template', $template->id)->sort('id', OrderType::DESC)->limit(1)->execute(); $rcoll = []; $report = \end($report); $report = $report === false ? new NullReport() : $report; - if (!($report instanceof NullReport)) { + if ($report->id > 0) { /** @var Media[] $files */ $files = $report->source->getSources(); diff --git a/Models/Report.php b/Models/Report.php index ab62de2..017b8ec 100755 --- a/Models/Report.php +++ b/Models/Report.php @@ -35,7 +35,7 @@ class Report implements \JsonSerializable * @var int * @since 1.0.0 */ - protected int $id = 0; + public int $id = 0; /** * Report status. @@ -43,7 +43,7 @@ class Report implements \JsonSerializable * @var int * @since 1.0.0 */ - private int $status = HelperStatus::INACTIVE; + public int $status = HelperStatus::INACTIVE; /** * Report title. diff --git a/Models/Template.php b/Models/Template.php index 45a92ce..3f2b032 100755 --- a/Models/Template.php +++ b/Models/Template.php @@ -38,7 +38,7 @@ class Template implements \JsonSerializable * @var int * @since 1.0.0 */ - protected int $id = 0; + public int $id = 0; /** * Unit. @@ -54,7 +54,7 @@ class Template implements \JsonSerializable * @var int * @since 1.0.0 */ - private int $status = HelperStatus::INACTIVE; + public int $status = HelperStatus::INACTIVE; /** * Template data type. diff --git a/Theme/Backend/helper-list.tpl.php b/Theme/Backend/helper-list.tpl.php index 076d7c2..7e2dc22 100755 --- a/Theme/Backend/helper-list.tpl.php +++ b/Theme/Backend/helper-list.tpl.php @@ -23,14 +23,14 @@ $templates = $this->getData('reports'); /** @var \Modules\Admin\Models\Account $account */ $account = $this->getData('account'); -$accountDir = $account->getId() . ' ' . $account->login; +$accountDir = $account->id . ' ' . $account->login; /** @var \Modules\Media\Models\Collection[] */ $collections = $this->getData('collections'); $mediaPath = \urldecode($this->getData('path') ?? '/'); -$previous = empty($templates) ? '{/base}/helper/list' : '{/base}/helper/list?{?}&id=' . \reset($templates)->getId() . '&ptype=p'; -$next = empty($templates) ? '{/base}/helper/list' : 'helper/list?{?}&id=' . \end($templates)->getId() . '&ptype=n'; +$previous = empty($templates) ? '{/base}/helper/list' : '{/base}/helper/list?{?}&id=' . \reset($templates)->id . '&ptype=p'; +$next = empty($templates) ? '{/base}/helper/list' : 'helper/list?{?}&id=' . \end($templates)->id . '&ptype=n'; echo $this->getData('nav')->render(); ?>