Test fixes
Some checks failed
Image optimization / general_image_workflow (push) Has been cancelled
CI / general_module_workflow_php (push) Has been cancelled
CI / general_module_workflow_js (push) Has been cancelled

This commit is contained in:
Dennis Eichhorn 2024-05-16 02:14:55 +00:00
parent 2a422a7222
commit 537468555a
6 changed files with 22 additions and 16 deletions

View File

@ -14,7 +14,6 @@ declare(strict_types=1);
namespace Modules\QualityManagement\Controller; namespace Modules\QualityManagement\Controller;
use Attribute;
use Modules\Admin\Models\NullAccount; use Modules\Admin\Models\NullAccount;
use Modules\Notification\Models\NotificationType; use Modules\Notification\Models\NotificationType;
use Modules\QualityManagement\Models\Report; use Modules\QualityManagement\Models\Report;
@ -23,7 +22,7 @@ use Modules\Tasks\Models\Attribute\TaskAttributeTypeMapper;
use Modules\Tasks\Models\TaskElementMapper; use Modules\Tasks\Models\TaskElementMapper;
use Modules\Tasks\Models\TaskMapper; use Modules\Tasks\Models\TaskMapper;
use Modules\Tasks\Models\TaskStatus; use Modules\Tasks\Models\TaskStatus;
use Modules\Tasks\Models\TaskType; use phpOMS\Message\Http\HttpRequest;
use phpOMS\Message\Http\RequestStatusCode; use phpOMS\Message\Http\RequestStatusCode;
use phpOMS\Message\RequestAbstract; use phpOMS\Message\RequestAbstract;
use phpOMS\Message\ResponseAbstract; use phpOMS\Message\ResponseAbstract;
@ -115,7 +114,7 @@ final class ApiController extends Controller
->execute(); ->execute();
if ($attrType->id !== 0) { if ($attrType->id !== 0) {
$internalRequest = new RequestAbstract(); $internalRequest = new HttpRequest();
$internalRequest->setData('value', $value); $internalRequest->setData('value', $value);
$attribute = $this->app->moduleManager->get('Attribute', 'Api')->createAttributeFromRequest($internalRequest, $attrType); $attribute = $this->app->moduleManager->get('Attribute', 'Api')->createAttributeFromRequest($internalRequest, $attrType);
@ -129,7 +128,7 @@ final class ApiController extends Controller
->execute(); ->execute();
if ($attrType->id !== 0) { if ($attrType->id !== 0) {
$internalRequest = new RequestAbstract(); $internalRequest = new HttpRequest();
$internalRequest->setData('value', $value); $internalRequest->setData('value', $value);
$attribute = $this->app->moduleManager->get('Attribute', 'Api')->createAttributeFromRequest($internalRequest, $attrType); $attribute = $this->app->moduleManager->get('Attribute', 'Api')->createAttributeFromRequest($internalRequest, $attrType);
@ -143,7 +142,7 @@ final class ApiController extends Controller
->execute(); ->execute();
if ($attrType->id !== 0) { if ($attrType->id !== 0) {
$internalRequest = new RequestAbstract(); $internalRequest = new HttpRequest();
$internalRequest->setData('value', $value); $internalRequest->setData('value', $value);
$attribute = $this->app->moduleManager->get('Attribute', 'Api')->createAttributeFromRequest($internalRequest, $attrType); $attribute = $this->app->moduleManager->get('Attribute', 'Api')->createAttributeFromRequest($internalRequest, $attrType);
@ -302,7 +301,14 @@ final class ApiController extends Controller
$this->app->moduleManager->get('Tasks')->apiTaskElementSet($request, $response); $this->app->moduleManager->get('Tasks')->apiTaskElementSet($request, $response);
/** @var \Modules\Tasks\Models\TaskElement $new */ /** @var \Modules\Tasks\Models\TaskElement $new */
$new = $response->getDataArray($request->uri->__toString())['response']; $new = $response->getDataArray($request->uri->__toString())['response'] ?? null;
if ($new === null) {
$response->header->status = RequestStatusCode::R_400;
$this->createInvalidUpdateResponse($request, $response, $new);
return;
}
//$this->updateModel($request->header->account, $report, $report, ReportMapper::class, 'report', $request->getOrigin()); //$this->updateModel($request->header->account, $report, $report, ReportMapper::class, 'report', $request->getOrigin());
$this->createStandardUpdateResponse($request, $response, $new); $this->createStandardUpdateResponse($request, $response, $new);

View File

@ -15,6 +15,7 @@ declare(strict_types=1);
namespace Modules\QualityManagement\Controller; namespace Modules\QualityManagement\Controller;
use Modules\Media\Models\MediaMapper; use Modules\Media\Models\MediaMapper;
use Modules\Profile\Models\SettingsEnum as ProfileSettingsEnum;
use Modules\QualityManagement\Models\ReportMapper; use Modules\QualityManagement\Models\ReportMapper;
use Modules\QualityManagement\Views\ReportView; use Modules\QualityManagement\Views\ReportView;
use Modules\Tasks\Models\AccountRelationMapper; use Modules\Tasks\Models\AccountRelationMapper;
@ -25,11 +26,10 @@ use Modules\Tasks\Models\TaskType;
use phpOMS\Contract\RenderableInterface; use phpOMS\Contract\RenderableInterface;
use phpOMS\DataStorage\Database\Query\Builder; use phpOMS\DataStorage\Database\Query\Builder;
use phpOMS\DataStorage\Database\Query\OrderType; use phpOMS\DataStorage\Database\Query\OrderType;
use phpOMS\Message\Http\RequestStatusCode;
use phpOMS\Message\RequestAbstract; use phpOMS\Message\RequestAbstract;
use phpOMS\Message\ResponseAbstract; use phpOMS\Message\ResponseAbstract;
use phpOMS\Views\View; use phpOMS\Views\View;
use Modules\Profile\Models\SettingsEnum as ProfileSettingsEnum;
use phpOMS\Message\Http\RequestStatusCode;
/** /**
* QualityManagement controller class. * QualityManagement controller class.

View File

@ -2,7 +2,7 @@
"name": { "name": {
"id": 1008500000, "id": 1008500000,
"internal": "QualityManagement", "internal": "QualityManagement",
"external": "QualityManagement" "external": "Quality Management"
}, },
"category": "Tools", "category": "Tools",
"version": "1.0.0", "version": "1.0.0",
@ -12,7 +12,7 @@
}, },
"creator": { "creator": {
"name": "Jingga", "name": "Jingga",
"website": "jingga.app" "website": "https://jingga.app"
}, },
"directory": "QualityManagement", "directory": "QualityManagement",
"dependencies": { "dependencies": {